Re: [malware-list] [PATCHv2 3/5] VFS: DazukoFS, stackable-fs, file access control

[Frantisek Hrbata <frantisek.hrbata@avg.com>]

On Tue, 3 Feb 2009 20:18:29 +0100
John Ogness <dazukocode@ogness.net> wrote:

> +/**
> + * dazukofs_add_group - add a new group
> + * @name: the name of the group to add
> + *
> + * Description: This function is called by the device layer to add a new
> + * group. It returns success if the group has been successfully created
> + * or if the group already exists.
> + *
> + * Returns 0 on success.
> + */
> +int dazukofs_add_group(const char *name)
> +{
> +       int ret = 0;
> +       int already_exists;
> +       int available_id = 0;
> +       struct dazukofs_group *grp;
> +
> +       write_lock(&group_count_rwlock);
> +
> +       mutex_lock(&work_mutex);

Hi,

you cannot hold spinlock and try to acquire mutex.

write_lock() -> preempt_disable() vs mutex_lock -> schedule()

-FH