From: ebiederm@xmission.com (Eric W. Biederman)
To: John Ogness <dazukocode@ogness.net>
Cc: linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk,
malware-list@lists.printk.net, eparis@redhat.com,
hch@infradead.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCHv2 2/5] VFS: DazukoFS, stackable-fs, file access control
Date: Thu, 12 Feb 2009 12:14:02 -0800 [thread overview]
Message-ID: <m1r623ct11.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <86wsc7fhzc.fsf_-_@johno.fn.ogness.net> (John Ogness's message of "Tue\, 03 Feb 2009 20\:17\:11 +0100")
John Ogness <dazukocode@ogness.net> writes:
> Patch 2: Creates /dev/dazukofs.0 for userspace applications to perform
> file access control. At this point, all applications are
> considered to be working together (in the same group).
Please use struct pid properly.
There is no guarantee that whoever opens /dev/dazukofs.0 will
be in the global pid namespace.
So you need to properly store a struct pid reference in your
data structures, and call pid_vnr just before you pass the value to userspace.
As it is your code is broken.
Eric
next prev parent reply other threads:[~2009-02-12 20:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 19:14 [PATCHv2 0/5] VFS: DazukoFS, stackable-fs, file access control John Ogness
2009-02-03 19:15 ` [PATCHv2 1/5] " John Ogness
2009-02-03 19:17 ` [PATCHv2 2/5] " John Ogness
2009-02-03 19:18 ` [PATCHv2 3/5] " John Ogness
2009-02-03 19:19 ` [PATCHv2 4/5] " John Ogness
2009-02-03 19:20 ` [PATCHv2 5/5] " John Ogness
2009-02-12 20:24 ` Eric W. Biederman
2009-02-12 20:20 ` [PATCHv2 3/5] " Eric W. Biederman
2009-02-17 8:55 ` John Ogness
2009-02-18 0:41 ` Eric W. Biederman
2009-02-21 18:11 ` [malware-list] " Frantisek Hrbata
2009-02-12 16:00 ` [PATCHv2 2/5] " Jan Engelhardt
2009-02-13 19:33 ` John Ogness
2009-02-12 20:14 ` Eric W. Biederman [this message]
2009-02-13 19:39 ` John Ogness
2009-02-12 15:27 ` [PATCHv2 1/5] " Jan Engelhardt
2009-02-12 15:31 ` Al Viro
2009-02-12 15:59 ` Jan Engelhardt
2009-02-12 16:47 ` Al Viro
2009-02-13 19:31 ` John Ogness
2009-02-13 19:48 ` Al Viro
2009-02-13 20:00 ` Jan Engelhardt
2009-02-13 20:25 ` Al Viro
2009-02-14 8:43 ` John Ogness
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1r623ct11.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dazukocode@ogness.net \
--cc=eparis@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=malware-list@lists.printk.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.