From: David Brownell <david-b@pacbell.net>
To: Kyungmin Park <kyungmin.park@samsung.com>,
Adrian Hunter <ext-adrian.hunter@nokia.com>
Cc: "Kim Kyuwon" <chammoru@gmail.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"drzeus-mmc@drzeus.cx" <drzeus-mmc@drzeus.cx>,
김규원 <q1.kim@samsung.com>
Subject: Re: [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming
Date: Mon, 23 Feb 2009 10:30:24 -0800 [thread overview]
Message-ID: <200902231030.25137.david-b@pacbell.net> (raw)
In-Reply-To: <9c9fda240902230426s2003d208xebeb6630c61b3bec@mail.gmail.com>
On Monday 23 February 2009, Kyungmin Park wrote:
> > Although I have not tested it, I very much doubt
> > dual-voltage cards work. That is because VMMC1_185V
> > is zero, which has the side-effect of turning the
> > regulator off (see arch/arm/mach-omap2/mmc-twl4030.c)
Right, looks like a longstanding bug in that glue.
So IMO, no rush to fix for 2.6.29-rc ...
> It's also to difficult to test in our H/W since it's configured only
> support 3.0V.
Easily tested with a Beagle or SDP though, if you
have a 1.8V or dual-voltage card (maybe RS-MMC, as
for an N770 tablet).
> How about to separate it two phases, first fix the mmc suspend/resume
> works again, and then verify dual voltage if there are these hardware
Well, two patches for sure; I don't know that the order
will matter. I just sent a patch fixing that code in
the current OMAP git tree, which has some fixes that are
scheduled to merge for 2.6.30-rc.
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: David Brownell <david-b@pacbell.net>
To: Kyungmin Park <kyungmin.park@samsung.com>,
Adrian Hunter <ext-adrian.hunter@nokia.com>
Cc: "Kim Kyuwon" <chammoru@gmail.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"drzeus-mmc@drzeus.cx" <drzeus-mmc@drzeus.cx>,
김규원 <q1.kim@samsung.com>
Subject: Re: [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming
Date: Mon, 23 Feb 2009 10:30:24 -0800 [thread overview]
Message-ID: <200902231030.25137.david-b@pacbell.net> (raw)
In-Reply-To: <9c9fda240902230426s2003d208xebeb6630c61b3bec@mail.gmail.com>
On Monday 23 February 2009, Kyungmin Park wrote:
> > Although I have not tested it, I very much doubt
> > dual-voltage cards work. That is because VMMC1_185V
> > is zero, which has the side-effect of turning the
> > regulator off (see arch/arm/mach-omap2/mmc-twl4030.c)
Right, looks like a longstanding bug in that glue.
So IMO, no rush to fix for 2.6.29-rc ...
> It's also to difficult to test in our H/W since it's configured only
> support 3.0V.
Easily tested with a Beagle or SDP though, if you
have a 1.8V or dual-voltage card (maybe RS-MMC, as
for an N770 tablet).
> How about to separate it two phases, first fix the mmc suspend/resume
> works again, and then verify dual voltage if there are these hardware
Well, two patches for sure; I don't know that the order
will matter. I just sent a patch fixing that code in
the current OMAP git tree, which has some fixes that are
scheduled to merge for 2.6.30-rc.
- Dave
next prev parent reply other threads:[~2009-02-23 18:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-20 12:00 [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming Kim Kyuwon
2009-02-20 12:00 ` Kim Kyuwon
2009-02-20 21:11 ` David Brownell
2009-02-20 21:11 ` David Brownell
2009-02-23 5:41 ` Kim Kyuwon
2009-02-23 5:41 ` Kim Kyuwon
2009-02-23 8:04 ` Adrian Hunter
2009-02-23 12:26 ` Kyungmin Park
2009-02-23 12:26 ` Kyungmin Park
2009-02-23 13:47 ` Adrian Hunter
2009-02-23 18:23 ` David Brownell
2009-02-23 18:23 ` David Brownell
2009-02-24 13:01 ` Adrian Hunter
2009-02-24 22:10 ` David Brownell
2009-02-24 22:10 ` David Brownell
2009-02-27 22:08 ` Tony Lindgren
2009-02-27 22:08 ` Tony Lindgren
2009-03-02 12:27 ` Adrian Hunter
2009-03-02 16:44 ` Tony Lindgren
2009-03-02 21:23 ` Pierre Ossman
2009-02-24 22:12 ` David Brownell
2009-02-24 22:12 ` David Brownell
2009-02-23 18:30 ` David Brownell [this message]
2009-02-23 18:30 ` David Brownell
2009-03-11 3:33 ` David Brownell
2009-03-11 3:33 ` David Brownell
2009-03-11 6:50 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902231030.25137.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=chammoru@gmail.com \
--cc=drzeus-mmc@drzeus.cx \
--cc=ext-adrian.hunter@nokia.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=q1.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.