* [PATCH] x86: enable DMAR by default
@ 2009-02-26 17:57 Kyle McMartin
2009-02-26 18:03 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Kyle McMartin @ 2009-02-26 17:57 UTC (permalink / raw)
To: x86; +Cc: dwmw2, linux-kernel
From: Kyle McMartin <kyle@redhat.com>
Now that the obvious bugs have been worked out, specifically
the iwlagn issue, and the write buffer errata, DMAR should be safe
to turn back on by default. (We've had it on since those patches were
first written a few weeks ago, without any noticeable bug reports
(most have been due to the dma-api debug patchset.))
Signed-off-by: Kyle McMartin <kyle@redhat.com>
---
Probably 2.6.29 material, but should definitely go in for 2.6.30.
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 9c39095..bc2fbad 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1803,7 +1803,7 @@ config DMAR
remapping devices.
config DMAR_DEFAULT_ON
- def_bool n
+ def_bool y
prompt "Enable DMA Remapping Devices by default"
depends on DMAR
help
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: enable DMAR by default
2009-02-26 17:57 [PATCH] x86: enable DMAR by default Kyle McMartin
@ 2009-02-26 18:03 ` Ingo Molnar
2009-02-26 18:54 ` David Woodhouse
0 siblings, 1 reply; 3+ messages in thread
From: Ingo Molnar @ 2009-02-26 18:03 UTC (permalink / raw)
To: Kyle McMartin, H. Peter Anvin, Thomas Gleixner; +Cc: x86, dwmw2, linux-kernel
* Kyle McMartin <kyle@infradead.org> wrote:
> From: Kyle McMartin <kyle@redhat.com>
>
> Now that the obvious bugs have been worked out, specifically
> the iwlagn issue, and the write buffer errata, DMAR should be
> safe to turn back on by default. (We've had it on since those
> patches were first written a few weeks ago, without any
> noticeable bug reports (most have been due to the dma-api
> debug patchset.))
>
> Signed-off-by: Kyle McMartin <kyle@redhat.com>
>
> ---
> Probably 2.6.29 material, but should definitely go in for 2.6.30.
Definitely agreed on .30. Can do it in .29 as well if David and
the rest of the Cc: agrees.
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: enable DMAR by default
2009-02-26 18:03 ` Ingo Molnar
@ 2009-02-26 18:54 ` David Woodhouse
0 siblings, 0 replies; 3+ messages in thread
From: David Woodhouse @ 2009-02-26 18:54 UTC (permalink / raw)
To: Ingo Molnar
Cc: Kyle McMartin, H. Peter Anvin, Thomas Gleixner, x86, linux-kernel
On Thu, 2009-02-26 at 19:03 +0100, Ingo Molnar wrote:
> * Kyle McMartin <kyle@infradead.org> wrote:
>
> > From: Kyle McMartin <kyle@redhat.com>
> >
> > Now that the obvious bugs have been worked out, specifically
> > the iwlagn issue, and the write buffer errata, DMAR should be
> > safe to turn back on by default. (We've had it on since those
> > patches were first written a few weeks ago, without any
> > noticeable bug reports (most have been due to the dma-api
> > debug patchset.))
> >
> > Signed-off-by: Kyle McMartin <kyle@redhat.com>
> >
> > ---
> > Probably 2.6.29 material, but should definitely go in for 2.6.30.
>
> Definitely agreed on .30. Can do it in .29 as well if David and
> the rest of the Cc: agrees.
Definitely. I wasn't any happier than you were with the patch which
disabled it in the first place.... but it was necessary at the time.
Enthusiastically-Acked-by: David Woodhouse <David.Woodhouse@intel.com>
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-02-26 18:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-26 17:57 [PATCH] x86: enable DMAR by default Kyle McMartin
2009-02-26 18:03 ` Ingo Molnar
2009-02-26 18:54 ` David Woodhouse
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.