From: Christoph Hellwig <hch@lst.de>
To: torvalds@osdl.org
Cc: Takashi Sato <t-sato@yk.jp.nec.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [hch: [PATCH] fix FREEZE/THAW compat_ioctl regression]
Date: Thu, 26 Feb 2009 21:32:51 +0100 [thread overview]
Message-ID: <20090226203251.GA31003@lst.de> (raw)
[I sent this 10 days ago to lkml and fsdevel and didn't get a single
reply yet, can we please get this in so we don't have that regression
in 2.6.29?]
Commit 8e961870bb9804110d5c8211d5d9d500451c4518 removed the FREEZE/THAW
handling in xfs_compat_ioctl but never added any compat handler back, so
now any freeze/thaw request from a 32-bit binary ond 64-bit userspace
will fail.
As these ioctls are 32/64-bit compatible two simple COMPATIBLE_IOCTL
entries in fs/compat_ioctl.c will do the job.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfs/fs/compat_ioctl.c
===================================================================
--- xfs.orig/fs/compat_ioctl.c 2009-02-16 12:48:23.000000000 +0000
+++ xfs/fs/compat_ioctl.c 2009-02-16 12:49:34.000000000 +0000
@@ -1913,6 +1913,9 @@
/* 0x00 */
COMPATIBLE_IOCTL(FIBMAP)
COMPATIBLE_IOCTL(FIGETBSZ)
+/* 'X' - originally XFS but some now in the VFS */
+COMPATIBLE_IOCTL(FIFREEZE)
+COMPATIBLE_IOCTL(FITHAW)
/* RAID */
COMPATIBLE_IOCTL(RAID_VERSION)
COMPATIBLE_IOCTL(GET_ARRAY_INFO)
----- End forwarded message -----
reply other threads:[~2009-02-26 20:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090226203251.GA31003@lst.de \
--to=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=t-sato@yk.jp.nec.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.