* [Qemu-devel] [PATCH] Document some missing options in configure -h
@ 2009-02-28 16:57 Andreas Färber
2009-02-28 17:04 ` M. Warner Losh
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Färber @ 2009-02-28 16:57 UTC (permalink / raw)
To: qemu-devel
Signed-off-by: Andreas Faerber <andreas.faerber@web.de>
---
This patch documents only these two for now.
Still undocumented here is --disable-gfx-checks.
diff --git a/configure b/configure
index 62925d8..75e1099 100755
--- a/configure
+++ b/configure
@@ -531,6 +531,8 @@ echo " --cc=CC use C compiler CC
[$cc]"
echo " --host-cc=CC use C compiler CC [$host_cc] for
dyngen etc."
echo " --make=MAKE use specified make [$make]"
echo " --install=INSTALL use specified install [$install]"
+echo " --extra-cflags=CFLAGS add C compiler flags CFLAGS"
+echo " --extra-ldflags=LDFLAGS add linker flags LDFLAGS"
echo " --static enable static build [$static]"
echo " --enable-sparse enable sparse checker"
echo " --disable-sparse disable sparse checker (default)"
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] Document some missing options in configure -h
2009-02-28 16:57 [Qemu-devel] [PATCH] Document some missing options in configure -h Andreas Färber
@ 2009-02-28 17:04 ` M. Warner Losh
2009-02-28 17:22 ` Andreas Färber
0 siblings, 1 reply; 5+ messages in thread
From: M. Warner Losh @ 2009-02-28 17:04 UTC (permalink / raw)
To: qemu-devel, andreas.faerber
In message: <AC188EDD-6AB8-46C2-82B7-D728022FFDDF@web.de>
Andreas_Färber <andreas.faerber@web.de> writes:
: Signed-off-by: Andreas Faerber <andreas.faerber@web.de>
: ---
: This patch documents only these two for now.
: Still undocumented here is --disable-gfx-checks.
:
: diff --git a/configure b/configure
: index 62925d8..75e1099 100755
: --- a/configure
: +++ b/configure
: @@ -531,6 +531,8 @@ echo " --cc=CC use C compiler CC
: [$cc]"
: echo " --host-cc=CC use C compiler CC [$host_cc] for
: dyngen etc."
: echo " --make=MAKE use specified make [$make]"
: echo " --install=INSTALL use specified install [$install]"
: +echo " --extra-cflags=CFLAGS add C compiler flags CFLAGS"
: +echo " --extra-ldflags=LDFLAGS add linker flags LDFLAGS"
This spacing doesn't look like it lines up to me...
: echo " --static enable static build [$static]"
: echo " --enable-sparse enable sparse checker"
: echo " --disable-sparse disable sparse checker (default)"
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] Document some missing options in configure -h
2009-02-28 17:04 ` M. Warner Losh
@ 2009-02-28 17:22 ` Andreas Färber
2009-03-08 18:46 ` [Qemu-devel] [PATCH] [RESEND] " Andreas Färber
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Färber @ 2009-02-28 17:22 UTC (permalink / raw)
To: qemu-devel
Am 28.02.2009 um 18:04 schrieb M. Warner Losh:
> In message: <AC188EDD-6AB8-46C2-82B7-D728022FFDDF@web.de>
> Andreas_Färber <andreas.faerber@web.de> writes:
> : Signed-off-by: Andreas Faerber <andreas.faerber@web.de>
> : ---
> : This patch documents only these two for now.
> : Still undocumented here is --disable-gfx-checks.
> :
> : diff --git a/configure b/configure
> : index 62925d8..75e1099 100755
> : --- a/configure
> : +++ b/configure
> : @@ -531,6 +531,8 @@ echo " --cc=CC use C
> compiler CC
> : [$cc]"
> : echo " --host-cc=CC use C compiler CC [$host_cc] for
> : dyngen etc."
> : echo " --make=MAKE use specified make [$make]"
> : echo " --install=INSTALL use specified install [$install]"
> : +echo " --extra-cflags=CFLAGS add C compiler flags CFLAGS"
> : +echo " --extra-ldflags=LDFLAGS add linker flags LDFLAGS"
>
> This spacing doesn't look like it lines up to me...
It did, they're indented by spaces.
This reminds me that, as seen above, some lines use "specified",
others "XYZ" notation... My choice was arbitrary, copying the --cc line.
> : echo " --static enable static build [$static]"
> : echo " --enable-sparse enable sparse checker"
> : echo " --disable-sparse disable sparse checker (default)"
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [PATCH] [RESEND] Document some missing options in configure -h
2009-02-28 17:22 ` Andreas Färber
@ 2009-03-08 18:46 ` Andreas Färber
2009-04-07 19:58 ` Aurelien Jarno
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Färber @ 2009-03-08 18:46 UTC (permalink / raw)
To: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1289 bytes --]
Am 28.02.2009 um 18:22 schrieb Andreas Färber:
>
> Am 28.02.2009 um 18:04 schrieb M. Warner Losh:
>
>> In message: <AC188EDD-6AB8-46C2-82B7-D728022FFDDF@web.de>
>> Andreas_Färber <andreas.faerber@web.de> writes:
>> : Signed-off-by: Andreas Faerber <andreas.faerber@web.de>
>> : ---
>> : This patch documents only these two for now.
>> : Still undocumented here is --disable-gfx-checks.
>> :
>> : diff --git a/configure b/configure
>> : index 62925d8..75e1099 100755
>> : --- a/configure
>> : +++ b/configure
>> : @@ -531,6 +531,8 @@ echo " --cc=CC use C
>> compiler CC
>> : [$cc]"
>> : echo " --host-cc=CC use C compiler CC [$host_cc] for
>> : dyngen etc."
>> : echo " --make=MAKE use specified make [$make]"
>> : echo " --install=INSTALL use specified install
>> [$install]"
>> : +echo " --extra-cflags=CFLAGS add C compiler flags CFLAGS"
>> : +echo " --extra-ldflags=LDFLAGS add linker flags LDFLAGS"
>>
>> This spacing doesn't look like it lines up to me...
>
> It did, they're indented by spaces.
Here's the unmodified patch as an attachment. I honestly can't see
what's wrong with the indentation. If there is, you'll have to tell me
what exactly.
Andreas
[-- Attachment #2: qemu-extraflags-doc.diff --]
[-- Type: application/octet-stream, Size: 698 bytes --]
diff --git a/configure b/configure
index 62925d8..75e1099 100755
--- a/configure
+++ b/configure
@@ -531,6 +531,8 @@ echo " --cc=CC use C compiler CC [$cc]"
echo " --host-cc=CC use C compiler CC [$host_cc] for dyngen etc."
echo " --make=MAKE use specified make [$make]"
echo " --install=INSTALL use specified install [$install]"
+echo " --extra-cflags=CFLAGS add C compiler flags CFLAGS"
+echo " --extra-ldflags=LDFLAGS add linker flags LDFLAGS"
echo " --static enable static build [$static]"
echo " --enable-sparse enable sparse checker"
echo " --disable-sparse disable sparse checker (default)"
[-- Attachment #3: Type: text/plain, Size: 1 bytes --]
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] [RESEND] Document some missing options in configure -h
2009-03-08 18:46 ` [Qemu-devel] [PATCH] [RESEND] " Andreas Färber
@ 2009-04-07 19:58 ` Aurelien Jarno
0 siblings, 0 replies; 5+ messages in thread
From: Aurelien Jarno @ 2009-04-07 19:58 UTC (permalink / raw)
To: Andreas_Färber; +Cc: qemu-devel
On Sun, Mar 08, 2009 at 07:46:21PM +0100, Andreas Färber wrote:
>
> Am 28.02.2009 um 18:22 schrieb Andreas Färber:
>
>>
>> Am 28.02.2009 um 18:04 schrieb M. Warner Losh:
>>
>>> In message: <AC188EDD-6AB8-46C2-82B7-D728022FFDDF@web.de>
>>> Andreas_Färber <andreas.faerber@web.de> writes:
>>> : Signed-off-by: Andreas Faerber <andreas.faerber@web.de>
>>> : ---
>>> : This patch documents only these two for now.
>>> : Still undocumented here is --disable-gfx-checks.
>>> :
>>> : diff --git a/configure b/configure
>>> : index 62925d8..75e1099 100755
>>> : --- a/configure
>>> : +++ b/configure
>>> : @@ -531,6 +531,8 @@ echo " --cc=CC use C
>>> compiler CC
>>> : [$cc]"
>>> : echo " --host-cc=CC use C compiler CC [$host_cc] for
>>> : dyngen etc."
>>> : echo " --make=MAKE use specified make [$make]"
>>> : echo " --install=INSTALL use specified install
>>> [$install]"
>>> : +echo " --extra-cflags=CFLAGS add C compiler flags CFLAGS"
>>> : +echo " --extra-ldflags=LDFLAGS add linker flags LDFLAGS"
>>>
>>> This spacing doesn't look like it lines up to me...
>>
>> It did, they're indented by spaces.
>
> Here's the unmodified patch as an attachment. I honestly can't see
> what's wrong with the indentation. If there is, you'll have to tell me
> what exactly.
>
Thanks, applied.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-04-07 19:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-28 16:57 [Qemu-devel] [PATCH] Document some missing options in configure -h Andreas Färber
2009-02-28 17:04 ` M. Warner Losh
2009-02-28 17:22 ` Andreas Färber
2009-03-08 18:46 ` [Qemu-devel] [PATCH] [RESEND] " Andreas Färber
2009-04-07 19:58 ` Aurelien Jarno
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.