From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: roel.kluin@gmail.com, netdev@vger.kernel.org,
linux-net-drivers@solarflare.com
Subject: Re: [PATCH 2/9] sfc: Fix test for MDIO read failure
Date: Mon, 02 Mar 2009 03:26:17 -0800 (PST) [thread overview]
Message-ID: <20090302.032617.91189355.davem@davemloft.net> (raw)
In-Reply-To: <1235775972.3164.17.camel@achroite>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Fri, 27 Feb 2009 23:06:12 +0000
> Commit 27dd2caca4eabe7c13a052b7456495ba75535e6a changed
> mdio_clause45_check_mmds() to read both DEVS0 and DEVS1 registers and
> to combine their values into an unsigned 32-bit mask. This made the
> following test for a negative (failure) value useless. Fix it to
> check whether either read failed.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Applied.
next prev parent reply other threads:[~2009-03-02 11:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-27 23:04 [PATCH 1/9] sfc: SFT9001: Include non-breaking cable diagnostics in online self-tests Ben Hutchings
2009-02-27 23:06 ` [PATCH 2/9] sfc: Fix test for MDIO read failure Ben Hutchings
2009-03-02 11:26 ` David Miller [this message]
2009-02-27 23:06 ` [PATCH 3/9] sfc: SFT9001/SFN4111T: Check PHY boot status during board initialisation Ben Hutchings
2009-03-02 11:26 ` David Miller
2009-02-27 23:06 ` [PATCH 4/9] sfc: Remove "XFP" from log messages that are not specific to XFP Ben Hutchings
2009-03-02 11:26 ` David Miller
2009-02-27 23:07 ` [PATCH 5/9] sfc: Fix reporting of PHY id Ben Hutchings
2009-03-02 11:26 ` David Miller
2009-02-27 23:07 ` [PATCH 6/9] sfc: Add support for QT2025C PHY Ben Hutchings
2009-03-02 11:26 ` David Miller
2009-02-27 23:07 ` [PATCH 7/9] sfc: Delete unused efx_blinker::led_num field Ben Hutchings
2009-03-02 11:26 ` David Miller
2009-02-27 23:08 ` [PATCH 8/9] sfc: Clean up LED control Ben Hutchings
2009-03-02 11:26 ` David Miller
2009-02-27 23:08 ` [PATCH 9/9] sfc: Add support for SFN4112F SFP+ reference design Ben Hutchings
2009-03-02 11:26 ` David Miller
2009-03-02 11:26 ` [PATCH 1/9] sfc: SFT9001: Include non-breaking cable diagnostics in online self-tests David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090302.032617.91189355.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.