From: "ext George G. Davis" <gdavis@mvista.com>
To: Jarkko Nikula <jarkko.nikula@nokia.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [RFC][PATCH] Fix SND_OMAP_SOC_MCBSP=m undefined symbols
Date: Mon, 2 Mar 2009 09:43:00 -0500 [thread overview]
Message-ID: <20090302144259.GC18140@mvista.com> (raw)
In-Reply-To: <20090302101812.0d8af61d.jarkko.nikula@nokia.com>
Hi,
On Mon, Mar 02, 2009 at 10:18:12AM +0200, Jarkko Nikula wrote:
> On Fri, 27 Feb 2009 18:33:39 +0100
> "ext George G. Davis" <gdavis@mvista.com> wrote:
>
> >
> > When building ASoC drivers as modules for SND_OMAP_SOC_MCBSP based
> > targets, the build fails because omap_ctrl_{read,write}l lack exports.
> > So add the missing exports for omap_ctrl_{read,write}[bwl] to allow
> > building these ASoC (and other) drivers as modules.
> >
> > Signed-off-by: George G. Davis <gdavis@mvista.com>
> >
> Thanks! CONFIG_SND_OMAP_SOC_N810=m works fine. And which indicates that
> I haven't tested to compile them as modules...
>
> I would use "ARM: OMAP2: Fix missing system control module exports"
> or something as a subject. But otherwise fine to me.
Ok, thanks!
>
> Acked-by: Jarkko Nikula <jarkko.nikula@nokia.com>
Added, thanks!
--
Regards,
George
prev parent reply other threads:[~2009-03-02 14:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-27 17:33 [RFC][PATCH] Fix SND_OMAP_SOC_MCBSP=m undefined symbols George G. Davis
2009-03-02 8:18 ` Jarkko Nikula
2009-03-02 14:43 ` ext George G. Davis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090302144259.GC18140@mvista.com \
--to=gdavis@mvista.com \
--cc=jarkko.nikula@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.