[RFC][PATCH] Fix SND_OMAP_SOC_MCBSP=m undefined symbols

[RFC][PATCH] Fix SND_OMAP_SOC_MCBSP=m undefined symbols

[George G. Davis]

When building ASoC drivers as modules for SND_OMAP_SOC_MCBSP based
targets, the build fails because omap_ctrl_{read,write}l lack exports.
So add the missing exports for omap_ctrl_{read,write}[bwl] to allow
building these ASoC (and other) drivers as modules.

Signed-off-by: George G. Davis <gdavis@mvista.com>

diff --git a/arch/arm/mach-omap2/control.c b/arch/arm/mach-omap2/control.c
index 5f3aad9..6b14639 100644
--- a/arch/arm/mach-omap2/control.c
+++ b/arch/arm/mach-omap2/control.c
@@ -36,29 +36,35 @@ u8 omap_ctrl_readb(u16 offset)
 {
 	return __raw_readb(OMAP_CTRL_REGADDR(offset));
 }
+EXPORT_SYMBOL(omap_ctrl_readb);
 
 u16 omap_ctrl_readw(u16 offset)
 {
 	return __raw_readw(OMAP_CTRL_REGADDR(offset));
 }
+EXPORT_SYMBOL(omap_ctrl_readw);
 
 u32 omap_ctrl_readl(u16 offset)
 {
 	return __raw_readl(OMAP_CTRL_REGADDR(offset));
 }
+EXPORT_SYMBOL(omap_ctrl_readl);
 
 void omap_ctrl_writeb(u8 val, u16 offset)
 {
 	__raw_writeb(val, OMAP_CTRL_REGADDR(offset));
 }
+EXPORT_SYMBOL(omap_ctrl_writeb);
 
 void omap_ctrl_writew(u16 val, u16 offset)
 {
 	__raw_writew(val, OMAP_CTRL_REGADDR(offset));
 }
+EXPORT_SYMBOL(omap_ctrl_writew);
 
 void omap_ctrl_writel(u32 val, u16 offset)
 {
 	__raw_writel(val, OMAP_CTRL_REGADDR(offset));
 }
+EXPORT_SYMBOL(omap_ctrl_writel);
 

Re: [RFC][PATCH] Fix SND_OMAP_SOC_MCBSP=m undefined symbols

[Jarkko Nikula]

On Fri, 27 Feb 2009 18:33:39 +0100
"ext George G. Davis" <gdavis@mvista.com> wrote:

> 
> When building ASoC drivers as modules for SND_OMAP_SOC_MCBSP based
> targets, the build fails because omap_ctrl_{read,write}l lack exports.
> So add the missing exports for omap_ctrl_{read,write}[bwl] to allow
> building these ASoC (and other) drivers as modules.
> 
> Signed-off-by: George G. Davis <gdavis@mvista.com>
> 
Thanks! CONFIG_SND_OMAP_SOC_N810=m works fine. And which indicates that
I haven't tested to compile them as modules...

I would use "ARM: OMAP2: Fix missing system control module exports"
or something as a subject. But otherwise fine to me.

Acked-by: Jarkko Nikula <jarkko.nikula@nokia.com>

Re: [RFC][PATCH] Fix SND_OMAP_SOC_MCBSP=m undefined symbols

[ext George G. Davis]

Hi,

On Mon, Mar 02, 2009 at 10:18:12AM +0200, Jarkko Nikula wrote:
> On Fri, 27 Feb 2009 18:33:39 +0100
> "ext George G. Davis" <gdavis@mvista.com> wrote:
> 
> > 
> > When building ASoC drivers as modules for SND_OMAP_SOC_MCBSP based
> > targets, the build fails because omap_ctrl_{read,write}l lack exports.
> > So add the missing exports for omap_ctrl_{read,write}[bwl] to allow
> > building these ASoC (and other) drivers as modules.
> > 
> > Signed-off-by: George G. Davis <gdavis@mvista.com>
> > 
> Thanks! CONFIG_SND_OMAP_SOC_N810=m works fine. And which indicates that
> I haven't tested to compile them as modules...
> 
> I would use "ARM: OMAP2: Fix missing system control module exports"
> or something as a subject. But otherwise fine to me.

Ok, thanks!

> 
> Acked-by: Jarkko Nikula <jarkko.nikula@nokia.com>

Added, thanks!

--
Regards,
George