From: Akinobu Mita <akinobu.mita@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] generic debug pagealloc
Date: Wed, 4 Mar 2009 23:17:23 +0900 [thread overview]
Message-ID: <20090304141721.GC7168@localhost.localdomain> (raw)
In-Reply-To: <20090303133610.cb771fef.akpm@linux-foundation.org>
On Tue, Mar 03, 2009 at 01:36:10PM -0800, Andrew Morton wrote:
> Alternatively, we could just not do the kmap_atomic() at all. i386
> won't be using this code and IIRC the only other highmem architecture
> is powerpc32, and ppc32 appears to also have its own DEBUG_PAGEALLOC
> implementation. So you could remove the kmap_atomic() stuff and put
>
> #ifdef CONFIG_HIGHMEM
> #error i goofed
> #endif
>
> in there.
I'll take the variant of this. Then poison_page() will be
static void poison_page(struct page *page)
{
void *addr;
if (PageHighmem(page))
return; // i goofed
page->poison = true;
addr = page_address(page);
memset(addr, PAGE_POISON, PAGE_SIZE);
}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Akinobu Mita <akinobu.mita@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] generic debug pagealloc
Date: Wed, 4 Mar 2009 23:17:23 +0900 [thread overview]
Message-ID: <20090304141721.GC7168@localhost.localdomain> (raw)
Message-ID: <20090304141723.5lmJDDMh9j5OoFK0rF1tTpYGQUGbk8hmJNjuBheYJfo@z> (raw)
In-Reply-To: <20090303133610.cb771fef.akpm@linux-foundation.org>
On Tue, Mar 03, 2009 at 01:36:10PM -0800, Andrew Morton wrote:
> Alternatively, we could just not do the kmap_atomic() at all. i386
> won't be using this code and IIRC the only other highmem architecture
> is powerpc32, and ppc32 appears to also have its own DEBUG_PAGEALLOC
> implementation. So you could remove the kmap_atomic() stuff and put
>
> #ifdef CONFIG_HIGHMEM
> #error i goofed
> #endif
>
> in there.
I'll take the variant of this. Then poison_page() will be
static void poison_page(struct page *page)
{
void *addr;
if (PageHighmem(page))
return; // i goofed
page->poison = true;
addr = page_address(page);
memset(addr, PAGE_POISON, PAGE_SIZE);
}
next prev parent reply other threads:[~2009-03-04 14:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 16:01 [PATCH] generic debug pagealloc Akinobu Mita
2009-03-03 16:01 ` Akinobu Mita
2009-03-03 16:05 ` Ingo Molnar
2009-03-03 16:05 ` Ingo Molnar
2009-03-04 14:12 ` Akinobu Mita
2009-03-04 14:12 ` Akinobu Mita
2009-03-03 16:12 ` Jiri Slaby
2009-03-03 16:12 ` Jiri Slaby
2009-03-04 14:13 ` Akinobu Mita
2009-03-04 14:13 ` Akinobu Mita
2009-03-03 21:36 ` Andrew Morton
2009-03-03 21:36 ` Andrew Morton
2009-03-03 22:07 ` Russell King
2009-03-03 22:07 ` Russell King
2009-03-04 14:17 ` Akinobu Mita [this message]
2009-03-04 14:17 ` Akinobu Mita
2009-03-06 9:14 ` Benjamin Herrenschmidt
2009-03-06 9:14 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090304141721.GC7168@localhost.localdomain \
--to=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.