From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
netdev@vger.kernel.org, davem@davemloft.net,
kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net
Subject: Re: [Patch 3/5] Network Drop Monitor: Adding kfree_skb_clean for non-drops and modifying end-of-line points for skbs
Date: Wed, 4 Mar 2009 13:13:35 -0300 [thread overview]
Message-ID: <20090304161335.GC6392@ghostprotocols.net> (raw)
In-Reply-To: <20090304141831.GB6139@hmsreliant.think-freely.org>
Em Wed, Mar 04, 2009 at 09:18:31AM -0500, Neil Horman escreveu:
> On Wed, Mar 04, 2009 at 10:54:15AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Mar 03, 2009 at 12:03:07PM -0500, Neil Horman escreveu:
> > >
> > > Network Drop Monitor: Adding kfree_skb_clean for non-drops and modifying end-of-line points for skbs
> > > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> >
> > Why just not add a "drop_skb()" instead? kfree_skb_clean sounds as if we
> > will do some cleanup on the skb being freed. "drop_skb()" seems much
> > clearer.
> >
> > - Arnaldo
> >
>
> Check the RFC thread. The cases in which we are dropping far outnumber the set
> of cases in which we free the skb simply because its the end of the line.
> Theres far less churn this way
I wouldn't mind the churn, as I really think drop_skb() would be
clearer, but then this is up to Dave.
- Arnaldo
next prev parent reply other threads:[~2009-03-04 16:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 17:03 [Patch 3/5] Network Drop Monitor: Adding kfree_skb_clean for non-drops and modifying end-of-line points for skbs Neil Horman
2009-03-04 13:54 ` Arnaldo Carvalho de Melo
2009-03-04 14:18 ` Neil Horman
2009-03-04 16:13 ` Arnaldo Carvalho de Melo [this message]
2009-03-04 21:06 ` David Miller
2009-03-04 22:45 ` Arnaldo Carvalho de Melo
2009-03-04 22:47 ` David Miller
2009-03-04 22:51 ` Arnaldo Carvalho de Melo
2009-03-04 23:57 ` Patrick McHardy
2009-03-05 21:01 ` Neil Horman
2009-03-11 16:18 ` David Miller
2009-03-11 16:34 ` Eric Dumazet
2009-03-11 16:48 ` David Miller
2009-03-11 17:07 ` Neil Horman
2009-03-11 21:39 ` Evgeniy Polyakov
2009-03-12 0:30 ` Neil Horman
2009-03-11 19:49 ` Neil Horman
2009-03-13 19:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090304161335.GC6392@ghostprotocols.net \
--to=acme@redhat.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=pekkas@netcore.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.