From: Eric Dumazet <dada1@cosmosbay.com>
To: David Miller <davem@davemloft.net>
Cc: nhorman@tuxdriver.com, netdev@vger.kernel.org,
kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net
Subject: Re: [Patch 3/5] Network Drop Monitor: Adding kfree_skb_clean for non-drops and modifying end-of-line points for skbs
Date: Wed, 11 Mar 2009 17:34:47 +0100 [thread overview]
Message-ID: <49B7E827.3070203@cosmosbay.com> (raw)
In-Reply-To: <20090311.091830.152269823.davem@davemloft.net>
David Miller a écrit :
> From: Neil Horman <nhorman@tuxdriver.com>
> Date: Thu, 5 Mar 2009 16:01:05 -0500
>
>> Ok, as requested, new version of this patch to add in bifurcation of kfree_skb
>> into two versions, one for legitimate kfree's, and one for drops
>>
>> Modification Notes:
>> 1) Renamed kfree_skb_clean to consume_skb, to better identify points where we
>> are finished with an skb
>>
>> 2) checkpatch cleanups
>
> Looks good.
>
> Respin everything with the requested changes I asked for in #4
> and I can likely toss this into net-next-2.6, thanks!
I was wondering if packets droped at NIC level are handled by "Network Drop Monitor".
(See recent discussion about Multicast packet loss)
I believe not, maybe I missed something ...
next prev parent reply other threads:[~2009-03-11 16:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 17:03 [Patch 3/5] Network Drop Monitor: Adding kfree_skb_clean for non-drops and modifying end-of-line points for skbs Neil Horman
2009-03-04 13:54 ` Arnaldo Carvalho de Melo
2009-03-04 14:18 ` Neil Horman
2009-03-04 16:13 ` Arnaldo Carvalho de Melo
2009-03-04 21:06 ` David Miller
2009-03-04 22:45 ` Arnaldo Carvalho de Melo
2009-03-04 22:47 ` David Miller
2009-03-04 22:51 ` Arnaldo Carvalho de Melo
2009-03-04 23:57 ` Patrick McHardy
2009-03-05 21:01 ` Neil Horman
2009-03-11 16:18 ` David Miller
2009-03-11 16:34 ` Eric Dumazet [this message]
2009-03-11 16:48 ` David Miller
2009-03-11 17:07 ` Neil Horman
2009-03-11 21:39 ` Evgeniy Polyakov
2009-03-12 0:30 ` Neil Horman
2009-03-11 19:49 ` Neil Horman
2009-03-13 19:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B7E827.3070203@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=pekkas@netcore.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.