From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Support up to 256 SCSI disks on Linux
Date: Wed, 4 Mar 2009 22:23:56 +0100 [thread overview]
Message-ID: <20090304212356.GL31201@thorin> (raw)
In-Reply-To: <20090304211629.GJ31201@thorin>
On Wed, Mar 04, 2009 at 10:16:29PM +0100, Robert Millan wrote:
> > else if (major == SCSI_DISK0_MAJOR)
> > - sprintf (name, "/dev/sd%c", 'a' + minor / 16);
> > + grub_util_getdiskname_scsi (name, 0, minor / 16);
> > + else if (major == SCSI_DISK1_MAJOR)
> > + grub_util_getdiskname_scsi (name, 1, minor / 16);
> > [...]
>
> Can this be factorized somehow? Space in raid.mod is quite critical; when
> used it usually ends up in core.img, which needs to fit in the embed area.
Oh, I'm sorry. I thought you were editting disk/raid.c. util/raid.c has no
size issues. A macro would still be nice though.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
next prev parent reply other threads:[~2009-03-04 21:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 16:35 [PATCH] Support up to 256 SCSI disks on Linux Colin Watson
2009-03-04 21:16 ` Robert Millan
2009-03-04 21:23 ` Robert Millan [this message]
2009-04-10 23:05 ` phcoder
2009-04-13 13:59 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090304212356.GL31201@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.