Re: [PATCH 4/4] pxa-ssp: switch from network mode to psp

[Daniel Mack <daniel@caiaq.de>]

On Thu, Mar 05, 2009 at 12:03:01AM +0100, Daniel Mack wrote:
> > >                switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
> > >                case SND_SOC_DAIFMT_NB_NF:
> > > -                       sspsp |= SSPSP_FSRT;
> > >                        break;
> > >                case SND_SOC_DAIFMT_NB_IF:
> > > -                       sspsp |= SSPSP_SFRMP | SSPSP_FSRT;
> > > -                       break;
> > > -               case SND_SOC_DAIFMT_IB_IF:
> > >                        sspsp |= SSPSP_SFRMP;
> > >                        break;
> > 
> > Removal of SSPSP_FSRT from NB/IB selection seems to be correct from the docs.
> 
> SSPSP_FSRT has a totally different meaning according to the PXA3xx docs,
> but I'll have a look at the PXA2x specs - maybe we need a special case
> here.

Sorry, got you wrong. I compared that to the PXA27x spec and it turns
out that this bit has no different meaning there. So it is definitely
wrong to use it for inverting the bitclk, no special case needed.

Daniel