From: Daniel Mack <daniel@caiaq.de>
To: Mark Brown <broonie@sirena.org.uk>
Cc: alsa-devel@alsa-project.org, Tim Ruetz <tim@caiaq.de>,
Liam Girdwood <lrg@kernel.org>,
pHilipp Zabel <philipp.zabel@gmail.com>
Subject: Re: [PATCH 4/4] pxa-ssp: switch from network mode to psp
Date: Thu, 5 Mar 2009 12:26:24 +0100 [thread overview]
Message-ID: <20090305112624.GA29699@buzzloop.caiaq.de> (raw)
In-Reply-To: <20090305112133.GD2416@sirena.org.uk>
On Thu, Mar 05, 2009 at 11:21:33AM +0000, Mark Brown wrote:
> > > Shouldn't this be somehow set by set_dai_clkdiv instead?
>
> > This is actually a very common case - MCLK is BCLK*4, so I put it here.
> > We could still move it to some more configurable place if it turns out
> > we need to configure it per board.
>
> It's a common option but far from universal - apart from anything else
> normally the MCLK requirement is a multiple of the sampling frequency
> rather than the bitclock rate so the ratio with BCLK will often vary
> with sample size. I've seen devices able to operate as low as 64fs and
> IIRC I've seen things up to 512fs, though 256fs is more common.
Ok, agreed. I moved that to my board file (using DIV_SCR) and will drop
that piece in the next patches.
Daniel
next prev parent reply other threads:[~2009-03-05 11:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 20:15 PXA SSP and external clocked I2S again Daniel Mack
2009-03-04 20:16 ` [PATCH 1/4] pxa-ssp: fix name of register bit Daniel Mack
2009-03-04 20:16 ` [PATCH 2/4] soc-dai: add bitfields for hardware I2S formats Daniel Mack
2009-03-04 20:16 ` [PATCH 3/4] pxa-ssp: don't touch ssp registers when stream is running Daniel Mack
2009-03-04 20:17 ` [PATCH 4/4] pxa-ssp: switch from network mode to psp Daniel Mack
2009-03-04 20:56 ` pHilipp Zabel
2009-03-04 23:03 ` Daniel Mack
2009-03-05 10:36 ` Daniel Mack
2009-03-05 11:21 ` Mark Brown
2009-03-05 11:26 ` Daniel Mack [this message]
2009-03-05 16:01 ` pHilipp Zabel
2009-03-05 13:21 ` Daniel Mack
2009-03-05 13:34 ` Mark Brown
2009-03-04 20:33 ` [PATCH 3/4] pxa-ssp: don't touch ssp registers when stream is running Mark Brown
2009-03-04 20:39 ` Daniel Mack
2009-03-04 20:42 ` Mark Brown
2009-03-05 10:23 ` Daniel Mack
2009-03-10 15:41 ` Daniel Mack
2009-03-10 15:56 ` Mark Brown
2009-03-04 22:30 ` [PATCH 2/4] soc-dai: add bitfields for hardware I2S formats Mark Brown
2009-03-04 23:12 ` Daniel Mack
2009-03-05 10:53 ` Mark Brown
2009-03-05 11:31 ` Daniel Mack
2009-03-05 12:03 ` Mark Brown
2009-03-05 12:55 ` Daniel Mack
2009-03-05 12:57 ` Mark Brown
2009-03-05 15:58 ` pHilipp Zabel
2009-03-05 11:40 ` [PATCH 1/4] pxa-ssp: fix name of register bit Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090305112624.GA29699@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=lrg@kernel.org \
--cc=philipp.zabel@gmail.com \
--cc=tim@caiaq.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.