All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Matthew Wilcox <matthew@wil.cx>, Yinghai Lu <yinghai@kernel.org>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH] x86/pci: try to detect host_bridge pci_cfg_space
Date: Sun, 8 Mar 2009 23:28:04 +0100	[thread overview]
Message-ID: <20090308222804.GA25376@elte.hu> (raw)
In-Reply-To: <49B44182.1030707@zytor.com>


* H. Peter Anvin <hpa@zytor.com> wrote:

> Matthew Wilcox wrote:
> > On Sun, Mar 08, 2009 at 02:21:40PM -0700, Yinghai Lu wrote:
> >> Jesse or Matthew, can you pick this patch?
> > 
> > Having reviewed it in light of HPA's comment, I don't have a problem
> > with it:
> > 
> > Reviewed-by: Matthew Wilcox <willy@linux.intel.com>
> > 
> > However, I don't think it's my place to take this patch while Jesse is
> > away; it doesn't feel like it's needed to be submitted between -rc7 and
> > 2.6.29.  Do you have a reason that it needs to be merged more urgently
> > than 2.6.30-rc1?
> > 
> 
> I didn't see one... I was assuming it was a submission to be 
> pushed upstream during the merge window.
> 
> It doesn't fix a regression, so it doesn't seem to me to be a 
> case for a late -rc merge.  It's hardware enablement, so it 
> *might* qualify for 2.6.29-stable, as far as I understand Greg 
> and Chris' policies.

Yeah. The patch is replacing a slowly-but-surely-bitrotting and 
always-behind quirk table with a more generic 
approach/workaround.

So there's no regression technically - but non-fully-working 
cards are obviously quite annoying on new systems. So i'd 
suggest a .30 merge with a Cc: <stable@kernel.org> tag.

	Ingo

  reply	other threads:[~2009-03-08 22:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-07  0:51 [PATCH] x86/pci: try to detect host_bridge pci_cfg_space Yinghai Lu
2009-03-07  0:58 ` H. Peter Anvin
2009-03-07  1:03   ` Yinghai Lu
2009-03-07  1:08     ` H. Peter Anvin
2009-03-07  1:11       ` Yinghai Lu
2009-03-07  1:04   ` H. Peter Anvin
2009-03-07  1:07     ` Yinghai Lu
2009-03-08 11:04       ` Ingo Molnar
2009-03-08 14:58         ` Matthew Wilcox
2009-03-08 21:05           ` H. Peter Anvin
2009-03-08 21:10             ` Yinghai Lu
2009-03-08 21:15               ` H. Peter Anvin
2009-03-08 21:21                 ` Yinghai Lu
2009-03-08 21:31                   ` Ingo Molnar
2009-03-08 22:01                   ` Matthew Wilcox
2009-03-08 22:06                     ` H. Peter Anvin
2009-03-08 22:28                       ` Ingo Molnar [this message]
2009-03-08 23:00                         ` Yinghai Lu
2009-03-09  4:35                           ` [PATCH] pci/x86: try to detect host_bridge pci_cfg_space -v2 Yinghai Lu
2009-03-20  2:02                             ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090308222804.GA25376@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.