All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
	Matthew Wilcox <matthew@wil.cx>, Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH] x86/pci: try to detect host_bridge pci_cfg_space
Date: Fri, 06 Mar 2009 16:58:07 -0800	[thread overview]
Message-ID: <49B1C69F.70904@zytor.com> (raw)
In-Reply-To: <49B1C50E.5010209@kernel.org>

Yinghai Lu wrote:
> Impact: get correct pci_cfg_size for host_bridge
> 
> more host bridges support 4k cfg, so check them directly
> instead of quirks.
> 
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>

I'm utterly confused by this.  This is basically saying we should try to 
probe for an extended device space for every host bridge.  Logically 
speaking, this is valid: if there is a valid path by which we can probe 
for byte 256 then it should succeed.

HOWEVER, the same argument applies for *every single device*.  So if 
this does indeed work, why should we limit it to host bridges?

	-hpa

  reply	other threads:[~2009-03-07  0:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-07  0:51 [PATCH] x86/pci: try to detect host_bridge pci_cfg_space Yinghai Lu
2009-03-07  0:58 ` H. Peter Anvin [this message]
2009-03-07  1:03   ` Yinghai Lu
2009-03-07  1:08     ` H. Peter Anvin
2009-03-07  1:11       ` Yinghai Lu
2009-03-07  1:04   ` H. Peter Anvin
2009-03-07  1:07     ` Yinghai Lu
2009-03-08 11:04       ` Ingo Molnar
2009-03-08 14:58         ` Matthew Wilcox
2009-03-08 21:05           ` H. Peter Anvin
2009-03-08 21:10             ` Yinghai Lu
2009-03-08 21:15               ` H. Peter Anvin
2009-03-08 21:21                 ` Yinghai Lu
2009-03-08 21:31                   ` Ingo Molnar
2009-03-08 22:01                   ` Matthew Wilcox
2009-03-08 22:06                     ` H. Peter Anvin
2009-03-08 22:28                       ` Ingo Molnar
2009-03-08 23:00                         ` Yinghai Lu
2009-03-09  4:35                           ` [PATCH] pci/x86: try to detect host_bridge pci_cfg_space -v2 Yinghai Lu
2009-03-20  2:02                             ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49B1C69F.70904@zytor.com \
    --to=hpa@zytor.com \
    --cc=akpm@linux-foundation.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.