All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frans Pop <elendil@planet.nl>
To: Mark Lord <liml@rtr.ca>
Cc: linux-arm@vger.kernel.org, linux-ide@vger.kernel.org,
	Saeed Bishara <saeed@marvell.com>, Nicolas Pitre <nico@cam.org>,
	Lennert Buytenhek <buytenh@wantstofly.org>
Subject: Re: [PATCH,v2][1/2] sata-mv: enable HDD led blinking when NCQ is active for GenIIe
Date: Wed, 11 Mar 2009 14:08:34 +0100	[thread overview]
Message-ID: <200903111408.37298.elendil@planet.nl> (raw)
In-Reply-To: <49B7B2C9.10203@rtr.ca>

On Wednesday 11 March 2009, Mark Lord wrote:
> > +static const struct mv_hw_ops mv6xxx_iie_ops = {
> > +	.inherits		= &mv6xxx_ops,
> > +	.enable_led_blink	= mv_iie_enable_led_blink,
> > +};
> > +
>
> I'm afraid I just don't understand the purpose of "inherits" above.
> This field appears to never be referenced anywhere.

Fun, as it's also used in mv6_ops and mv_iie_ops. That's where I copied it 
from. I really don't have anywhere near the C fu to think up such 
constructs all by myself :-D

What it does (I've been assuming) is include any ops defined in the struct 
that is being referred to. So mv6xxx_iie_ops gets all the ops defined for 
mv6xxx_ops plus mv_iie_enable_led_blink.

> (or did I miss an update to the C programming language at some point? 
> :)
>

You're still way ahead of me.

  reply	other threads:[~2009-03-11 13:08 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-11  7:13 [PATCH,v2][0/2] sata_mv: harddisk activity led no longer responsive on QNAP TS-109 Frans Pop
2009-03-11  7:15 ` [PATCH,v2][1/2] sata-mv: enable HDD led blinking when NCQ is active for GenIIe Frans Pop
2009-03-11 12:47   ` Mark Lord
2009-03-11 13:08     ` Frans Pop [this message]
2009-03-11 14:15       ` Mark Lord
2009-03-12 11:40         ` Frans Pop
2009-03-12 14:14           ` Mark Lord
2009-03-12 14:15             ` Mark Lord
2009-03-12 14:26               ` Mark Lord
2009-03-13  8:07                 ` Frans Pop
2009-03-13 13:04                   ` Mark Lord
2009-03-13 18:19                     ` Frans Pop
2009-03-13 19:09                       ` Mark Lord
2009-03-14 11:57                       ` Frans Pop
2009-03-14 14:53                         ` Mark Lord
2009-03-15 10:18                           ` Frans Pop
2009-03-12 14:27             ` Frans Pop
2009-03-12 14:31               ` Mark Lord
2009-03-11  7:17 ` [PATCH,v2][2/2] sata-mv: add module parameter msq_blink_led to enable quirk " Frans Pop
2009-03-11 12:33 ` [PATCH,v2][0/2] sata_mv: harddisk activity led no longer responsive on QNAP TS-109 Mark Lord
2009-03-11 12:58   ` Mark Lord
2009-03-11 13:01   ` Frans Pop

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200903111408.37298.elendil@planet.nl \
    --to=elendil@planet.nl \
    --cc=buytenh@wantstofly.org \
    --cc=liml@rtr.ca \
    --cc=linux-arm@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=nico@cam.org \
    --cc=saeed@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.