All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <liml@rtr.ca>
To: Frans Pop <elendil@planet.nl>
Cc: linux-arm@vger.kernel.org, linux-ide@vger.kernel.org,
	Saeed Bishara <saeed@marvell.com>, Nicolas Pitre <nico@cam.org>,
	Lennert Buytenhek <buytenh@wantstofly.org>
Subject: Re: [PATCH,v2][1/2] sata-mv: enable HDD led blinking when NCQ is active for GenIIe
Date: Thu, 12 Mar 2009 10:14:41 -0400	[thread overview]
Message-ID: <49B918D1.7020407@rtr.ca> (raw)
In-Reply-To: <200903121240.55194.elendil@planet.nl>

Frans Pop wrote:
> On Wednesday 11 March 2009, Mark Lord wrote:
..
>> Can you test this there and confirm that it still works for you?
>> Please try switching NCQ on/off etc.. just to make sure.
> 
> The LED behavior is correct with NCQ enabled: slow blink.
> But if I disable NCQ blink mode is not turned off, the led continues the 
> slow blinking. So it looks as if just calling mv_soc_led_blink_disable in 
> mv_edma_cfg is not sufficient.
..

Exactly, *how*, did you "disable NCQ blink mode".

thanks

  reply	other threads:[~2009-03-12 14:14 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-11  7:13 [PATCH,v2][0/2] sata_mv: harddisk activity led no longer responsive on QNAP TS-109 Frans Pop
2009-03-11  7:15 ` [PATCH,v2][1/2] sata-mv: enable HDD led blinking when NCQ is active for GenIIe Frans Pop
2009-03-11 12:47   ` Mark Lord
2009-03-11 13:08     ` Frans Pop
2009-03-11 14:15       ` Mark Lord
2009-03-12 11:40         ` Frans Pop
2009-03-12 14:14           ` Mark Lord [this message]
2009-03-12 14:15             ` Mark Lord
2009-03-12 14:26               ` Mark Lord
2009-03-13  8:07                 ` Frans Pop
2009-03-13 13:04                   ` Mark Lord
2009-03-13 18:19                     ` Frans Pop
2009-03-13 19:09                       ` Mark Lord
2009-03-14 11:57                       ` Frans Pop
2009-03-14 14:53                         ` Mark Lord
2009-03-15 10:18                           ` Frans Pop
2009-03-12 14:27             ` Frans Pop
2009-03-12 14:31               ` Mark Lord
2009-03-11  7:17 ` [PATCH,v2][2/2] sata-mv: add module parameter msq_blink_led to enable quirk " Frans Pop
2009-03-11 12:33 ` [PATCH,v2][0/2] sata_mv: harddisk activity led no longer responsive on QNAP TS-109 Mark Lord
2009-03-11 12:58   ` Mark Lord
2009-03-11 13:01   ` Frans Pop

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49B918D1.7020407@rtr.ca \
    --to=liml@rtr.ca \
    --cc=buytenh@wantstofly.org \
    --cc=elendil@planet.nl \
    --cc=linux-arm@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=nico@cam.org \
    --cc=saeed@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.