* feature-removal-schedule.txt for some I2C functions
@ 2009-03-12 13:26 Mauro Carvalho Chehab
2009-03-12 14:06 ` Jean Delvare
0 siblings, 1 reply; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2009-03-12 13:26 UTC (permalink / raw)
To: Jean Delvare, LKML
Hi Jean,
On your entry at Documentation/feature-removal-schedule.txt:
What: i2c_attach_client(), i2c_detach_client(), i2c_driver->detach_client()
When: 2.6.29 (ideally) or 2.6.30 (more likely)
Why: Deprecated by the new (standard) device driver binding model. Use
i2c_driver->probe() and ->remove() instead.
Who: Jean Delvare <khali@linux-fr.org>
You forgot to add a check entry, like:
Check: i2c_attach_client i2c_detach_client i2c_driver->detach_client
The check entry is used by checkpatch.pl to warn about the usage of a legacy function.
Please fix it, since me and others rely on this tool to discover about the
usage of legacy functions.
Cheers,
Mauro
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: feature-removal-schedule.txt for some I2C functions
2009-03-12 13:26 feature-removal-schedule.txt for some I2C functions Mauro Carvalho Chehab
@ 2009-03-12 14:06 ` Jean Delvare
0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2009-03-12 14:06 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: LKML
Hi Mauro,
On Thu, 12 Mar 2009 10:26:17 -0300, Mauro Carvalho Chehab wrote:
> Hi Jean,
>
> On your entry at Documentation/feature-removal-schedule.txt:
>
> What: i2c_attach_client(), i2c_detach_client(), i2c_driver->detach_client()
> When: 2.6.29 (ideally) or 2.6.30 (more likely)
> Why: Deprecated by the new (standard) device driver binding model. Use
> i2c_driver->probe() and ->remove() instead.
> Who: Jean Delvare <khali@linux-fr.org>
>
> You forgot to add a check entry, like:
> Check: i2c_attach_client i2c_detach_client i2c_driver->detach_client
>
> The check entry is used by checkpatch.pl to warn about the usage of a legacy function.
>
> Please fix it, since me and others rely on this tool to discover about the
> usage of legacy functions.
Thanks for the tip, I didn't know about this. Is there some
documentation about the Check: entry format? If checkpatch.pl simply
matches the strings then i2c_driver->detach_client is never going to
match, so there's no point in adding it.
--
Jean Delvare
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-12 14:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-12 13:26 feature-removal-schedule.txt for some I2C functions Mauro Carvalho Chehab
2009-03-12 14:06 ` Jean Delvare
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.