From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 0/6] [XFS] introduce a AG inode tree walker
Date: Mon, 16 Mar 2009 20:40:19 +1100 [thread overview]
Message-ID: <20090316094019.GD26138@disturbed> (raw)
In-Reply-To: <20090316075338.GA19858@infradead.org>
On Mon, Mar 16, 2009 at 03:53:38AM -0400, Christoph Hellwig wrote:
> On Sun, Mar 15, 2009 at 10:46:37PM +1100, Dave Chinner wrote:
> > This series splits up the sync and reclaim code into three
> > separate actions. The first is the tree walker, the second is
> > the inode validation and the third is the operation to execute
> > on the inode.
> >
> > This allows us to somewhat abstract the radix tree away from the
> > act of walking the cached inodes and puts in place mechanisms that
> > can be extended for bulk inode cache lookups.
> >
> > This also splits the inode writeback into separate data and metadata
> > sync operations and optimises them a little......
>
> Just did a quick XFSQA run with your whole patch series applied and
> I get this oops in 001:
I haven't seen that - it runs through a UML test run just fine.
I'll see if I can reproduce it...
If you drop the last patch (the iterator patch) does it work
ok?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-03-16 9:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-15 11:46 [PATCH 0/6] [XFS] introduce a AG inode tree walker Dave Chinner
2009-03-15 11:46 ` [PATCH 1/6] [XFS] Split inode data writeback from inode sync Dave Chinner
2009-03-16 10:10 ` Christoph Hellwig
2009-03-16 10:47 ` Dave Chinner
2009-03-15 11:46 ` [PATCH 2/6] [XFS] Use xfs_inode_flush() in xfs_sync_inodes_ag() Dave Chinner
2009-03-15 11:46 ` [PATCH 3/6] [XFS] Factor out inode validation for sync Dave Chinner
2009-03-15 11:46 ` [PATCH 4/6] [XFS] Factor out inode validation for reclaim Dave Chinner
2009-03-15 11:46 ` [PATCH 5/6] [XFS] Remove unused parameter from xfs_reclaim_inodes Dave Chinner
2009-03-15 11:46 ` [PATCH 6/6] [XFS] introduce a per-ag inode iterator Dave Chinner
2009-03-16 7:53 ` [PATCH 0/6] [XFS] introduce a AG inode tree walker Christoph Hellwig
2009-03-16 9:40 ` Dave Chinner [this message]
2009-03-16 10:01 ` Christoph Hellwig
2009-03-16 10:35 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090316094019.GD26138@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.