From: Christoph Hellwig <hch@infradead.org>
To: xfs@oss.sgi.com, linux-mm@kvack.org
Subject: fput under mmap_sem
Date: Wed, 18 Mar 2009 03:13:13 -0400 [thread overview]
Message-ID: <20090318071313.GA30011@infradead.org> (raw)
In-Reply-To: <20090315221921.GY26138@disturbed>
On Mon, Mar 16, 2009 at 09:19:21AM +1100, Dave Chinner wrote:
> This is a VM problem where it calls fput() with the mmap_sem() held
> in remove_vma(). It makes the incorrect assumption that filesystems
> will never use the same lock in the IO path and the inode release path.
>
> This can deadlock if you are really unlucky.
I really wonder why other filesystems haven't hit this yet. Any chance
we can get the fput moved out of mmap_sem to get rid of this class of
problems?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: xfs@oss.sgi.com, linux-mm@kvack.org
Subject: fput under mmap_sem
Date: Wed, 18 Mar 2009 03:13:13 -0400 [thread overview]
Message-ID: <20090318071313.GA30011@infradead.org> (raw)
In-Reply-To: <20090315221921.GY26138@disturbed>
On Mon, Mar 16, 2009 at 09:19:21AM +1100, Dave Chinner wrote:
> This is a VM problem where it calls fput() with the mmap_sem() held
> in remove_vma(). It makes the incorrect assumption that filesystems
> will never use the same lock in the IO path and the inode release path.
>
> This can deadlock if you are really unlucky.
I really wonder why other filesystems haven't hit this yet. Any chance
we can get the fput moved out of mmap_sem to get rid of this class of
problems?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-03-18 7:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-15 12:59 XFS lock warning, 2.6.29-rc8 Denys Fedoryschenko
2009-03-15 22:19 ` Dave Chinner
2009-03-15 22:19 ` Dave Chinner
2009-03-18 7:13 ` Christoph Hellwig [this message]
2009-03-18 7:13 ` fput under mmap_sem Christoph Hellwig
2009-03-18 12:37 ` Nick Piggin
2009-03-18 12:37 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090318071313.GA30011@infradead.org \
--to=hch@infradead.org \
--cc=linux-mm@kvack.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.