From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
linuxppc-dev@ozlabs.org,
systemtap-ml <systemtap@sources.redhat.com>,
Ingo Molnar <mingo@elte.hu>,
Masami Hiramatsu <mhiramat@redhat.com>
Subject: Re: [RFC][PATCH -tip 4/9] power: add kernel_trap_sp()
Date: Fri, 20 Mar 2009 13:03:34 +0530 [thread overview]
Message-ID: <20090320073334.GA10519@in.ibm.com> (raw)
In-Reply-To: <1237527760.25062.567.camel@pasglop>
On Fri, Mar 20, 2009 at 04:42:40PM +1100, Benjamin Herrenschmidt wrote:
> On Thu, 2009-03-19 at 17:10 -0400, Masami Hiramatsu wrote:
> > Add kernel_trap_sp() on powerpc, based on systemtap's runtime/regs.h.
> >
> > Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
>
> I haven't looked at the usage of it, but it's weird to have something
> call "kernel_trap_sp" that returns the -user- stack pointer... is
> this really what's expected here ?
In the current usage scenario, this gets called only with a pt_regs
snapshot from in kernel. user_stack_pointer() is a misnomer though;
all this macro needs is to return the stack pointer from the given
pt_regs.
Ananth
WARNING: multiple messages have this Message-ID (diff)
From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Masami Hiramatsu <mhiramat@redhat.com>,
Ingo Molnar <mingo@elte.hu>,
linuxppc-dev@ozlabs.org,
systemtap-ml <systemtap@sources.redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH -tip 4/9] power: add kernel_trap_sp()
Date: Fri, 20 Mar 2009 13:03:34 +0530 [thread overview]
Message-ID: <20090320073334.GA10519@in.ibm.com> (raw)
In-Reply-To: <1237527760.25062.567.camel@pasglop>
On Fri, Mar 20, 2009 at 04:42:40PM +1100, Benjamin Herrenschmidt wrote:
> On Thu, 2009-03-19 at 17:10 -0400, Masami Hiramatsu wrote:
> > Add kernel_trap_sp() on powerpc, based on systemtap's runtime/regs.h.
> >
> > Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
>
> I haven't looked at the usage of it, but it's weird to have something
> call "kernel_trap_sp" that returns the -user- stack pointer... is
> this really what's expected here ?
In the current usage scenario, this gets called only with a pt_regs
snapshot from in kernel. user_stack_pointer() is a misnomer though;
all this macro needs is to return the stack pointer from the given
pt_regs.
Ananth
next prev parent reply other threads:[~2009-03-20 7:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-19 21:10 [RFC][PATCH -tip 4/9] power: add kernel_trap_sp() Masami Hiramatsu
2009-03-19 21:10 ` Masami Hiramatsu
2009-03-20 5:42 ` Benjamin Herrenschmidt
2009-03-20 5:42 ` Benjamin Herrenschmidt
2009-03-20 7:33 ` Ananth N Mavinakayanahalli [this message]
2009-03-20 7:33 ` Ananth N Mavinakayanahalli
2009-03-20 10:53 ` Masami Hiramatsu
2009-03-20 10:53 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090320073334.GA10519@in.ibm.com \
--to=ananth@in.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.