From: Paul Moore <paul.moore@hp.com>
To: Miloslav Trmac <mitr@redhat.com>
Cc: linux-audit@redhat.com, viro <viro@zeniv.linux.org.uk>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Add SELinux context and TTY name to AUDIT_TTY records
Date: Fri, 20 Mar 2009 09:51:25 -0400 [thread overview]
Message-ID: <200903200951.25699.paul.moore@hp.com> (raw)
In-Reply-To: <1666981128.1772561237539207343.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
On Friday 20 March 2009 04:53:27 am Miloslav Trmac wrote:
> ----- "Paul Moore" <paul.moore@hp.com> wrote:
> > There are several audit experts which should review this code but two
> > things jumped out at me when glancing at your patch:
> >
> > 1. SELinux SIDs should not be recorded
>
> Almost all code that logs SELinux contexts in kernel/audit* does the same
> thing as this patch, falling back to a SID if it can't be converted to a
> string.
Ungh, that's ugly and questionably useful (I suppose I know why this is done)
but if that convention then who am I to argue.
> > 2. From a SELinux/security point of view ttys are considered objects
> > and their labels/contexts should be recorded with "obj=" not
> > "subj="
>
> The patch logs the context of the process, not of the TTY.
Okay, that is what I get for just glancing at patches and not looking at them
closer :)
--
paul moore
linux @ hp
WARNING: multiple messages have this Message-ID (diff)
From: Paul Moore <paul.moore@hp.com>
To: Miloslav Trmac <mitr@redhat.com>
Cc: viro <viro@zeniv.linux.org.uk>, Eric Paris <eparis@redhat.com>,
"linux-kernel" <linux-kernel@vger.kernel.org>,
linux-audit@redhat.com
Subject: Re: [PATCH] Add SELinux context and TTY name to AUDIT_TTY records
Date: Fri, 20 Mar 2009 09:51:25 -0400 [thread overview]
Message-ID: <200903200951.25699.paul.moore@hp.com> (raw)
In-Reply-To: <1666981128.1772561237539207343.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
On Friday 20 March 2009 04:53:27 am Miloslav Trmac wrote:
> ----- "Paul Moore" <paul.moore@hp.com> wrote:
> > There are several audit experts which should review this code but two
> > things jumped out at me when glancing at your patch:
> >
> > 1. SELinux SIDs should not be recorded
>
> Almost all code that logs SELinux contexts in kernel/audit* does the same
> thing as this patch, falling back to a SID if it can't be converted to a
> string.
Ungh, that's ugly and questionably useful (I suppose I know why this is done)
but if that convention then who am I to argue.
> > 2. From a SELinux/security point of view ttys are considered objects
> > and their labels/contexts should be recorded with "obj=" not
> > "subj="
>
> The patch logs the context of the process, not of the TTY.
Okay, that is what I get for just glancing at patches and not looking at them
closer :)
--
paul moore
linux @ hp
next prev parent reply other threads:[~2009-03-20 13:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1446383553.1772511237538977759.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
2009-03-20 8:53 ` [PATCH] Add SELinux context and TTY name to AUDIT_TTY records Miloslav Trmac
2009-03-20 8:53 ` Miloslav Trmac
2009-03-20 13:51 ` Paul Moore [this message]
2009-03-20 13:51 ` Paul Moore
[not found] <230738142.1737601237483061914.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
2009-03-19 17:18 ` Miloslav Trmac
2009-03-19 17:18 ` Miloslav Trmac
2009-03-19 20:58 ` Paul Moore
2009-03-19 20:58 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903200951.25699.paul.moore@hp.com \
--to=paul.moore@hp.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mitr@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.