From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>, Jens Axboe <jens.axboe@oracle.com>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 7/7] blktrace: avoid accessing NULL bdev->bd_disk
Date: Fri, 20 Mar 2009 10:08:39 -0300 [thread overview]
Message-ID: <20090320130839.GM30407@ghostprotocols.net> (raw)
In-Reply-To: <49C2F63C.2090107@cn.fujitsu.com>
Em Fri, Mar 20, 2009 at 09:49:48AM +0800, Li Zefan escreveu:
> bdev->bd_disk can be NULL, if the block device is not opened.
>
> Try this against an unmounted partition, and you'll see NULL dereference:
> # echo 1 > /sys/block/sda/sda5/enable
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
I guess this can be discounted on my block layer newbeeness 8)
But as an extra check in non hot-paths are usually a good thing...
Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
- Arnaldo
next prev parent reply other threads:[~2009-03-20 13:09 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 1:47 [PATCH 0/7] blktrace: various cleanups and fixes Li Zefan
2009-03-20 1:47 ` [PATCH 1/7] blktrace: fix possible memory leak Li Zefan
2009-03-20 10:25 ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 12:53 ` [PATCH 1/7] " Arnaldo Carvalho de Melo
2009-03-21 15:18 ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 1:48 ` [PATCH 2/7] blktrace: make blk_tracer_enabled a bool flag Li Zefan
2009-03-20 8:47 ` Frederic Weisbecker
2009-03-20 10:26 ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 12:58 ` [PATCH 2/7] " Arnaldo Carvalho de Melo
2009-03-21 15:18 ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 1:48 ` [PATCH 3/7] blktrace: remove blk_probe_mutex Li Zefan
2009-03-20 8:50 ` Frederic Weisbecker
2009-03-20 10:26 ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 13:03 ` [PATCH 3/7] " Arnaldo Carvalho de Melo
2009-03-22 6:04 ` Li Zefan
2009-03-22 15:09 ` Arnaldo Carvalho de Melo
2009-03-21 15:18 ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 1:48 ` [PATCH 4/7] blktrace: don't increase blk_probes_ref if failed to setup blk trace Li Zefan
2009-03-20 10:26 ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 13:04 ` [PATCH 4/7] " Arnaldo Carvalho de Melo
2009-03-21 15:18 ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 1:49 ` [PATCH 5/7] blktrace: report EBUSY correctly Li Zefan
2009-03-20 10:26 ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 13:10 ` [PATCH 5/7] " Arnaldo Carvalho de Melo
2009-03-21 15:18 ` Ingo Molnar
2009-03-21 15:19 ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 1:49 ` [PATCH 6/7] blktrace: remove sysfs_blk_trace_enable_show/store() Li Zefan
2009-03-20 3:33 ` Li Zefan
2009-03-20 10:26 ` [tip:tracing/blktrace] " Li Zefan
2009-03-21 15:19 ` Li Zefan
2009-03-20 13:07 ` [PATCH 6/7] " Arnaldo Carvalho de Melo
2009-03-20 1:49 ` [PATCH 7/7] blktrace: avoid accessing NULL bdev->bd_disk Li Zefan
2009-03-20 2:34 ` Li Zefan
2009-03-20 10:26 ` [tip:tracing/blktrace] " Li Zefan
2009-03-21 15:19 ` Li Zefan
2009-03-20 13:08 ` Arnaldo Carvalho de Melo [this message]
2009-03-20 10:20 ` [PATCH 0/7] blktrace: various cleanups and fixes Ingo Molnar
2009-03-20 11:09 ` Ingo Molnar
2009-03-23 14:48 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090320130839.GM30407@ghostprotocols.net \
--to=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.