From: Li Zefan <lizf@cn.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Jens Axboe <jens.axboe@oracle.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 4/7] blktrace: don't increase blk_probes_ref if failed to setup blk trace
Date: Fri, 20 Mar 2009 09:48:47 +0800 [thread overview]
Message-ID: <49C2F5FF.80002@cn.fujitsu.com> (raw)
In-Reply-To: <49C2F599.3060306@cn.fujitsu.com>
do_blk_trace_setup() may return EBUSY, but the current code doesn't
decrease blk_probes_ref in this case.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
kernel/trace/blktrace.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index 223b92e..11e7c8d 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -468,9 +468,6 @@ int do_blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
bt->pid = buts->pid;
bt->trace_state = Blktrace_setup;
- if (atomic_add_return(1, &blk_probes_ref) == 1)
- blk_register_tracepoints();
-
ret = -EBUSY;
old_bt = xchg(&q->blk_trace, bt);
if (old_bt) {
@@ -478,6 +475,9 @@ int do_blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
goto err;
}
+ if (atomic_add_return(1, &blk_probes_ref) == 1)
+ blk_register_tracepoints();
+
return 0;
err:
if (bt) {
--
1.5.4.rc3
next prev parent reply other threads:[~2009-03-20 1:48 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 1:47 [PATCH 0/7] blktrace: various cleanups and fixes Li Zefan
2009-03-20 1:47 ` [PATCH 1/7] blktrace: fix possible memory leak Li Zefan
2009-03-20 10:25 ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 12:53 ` [PATCH 1/7] " Arnaldo Carvalho de Melo
2009-03-21 15:18 ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 1:48 ` [PATCH 2/7] blktrace: make blk_tracer_enabled a bool flag Li Zefan
2009-03-20 8:47 ` Frederic Weisbecker
2009-03-20 10:26 ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 12:58 ` [PATCH 2/7] " Arnaldo Carvalho de Melo
2009-03-21 15:18 ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 1:48 ` [PATCH 3/7] blktrace: remove blk_probe_mutex Li Zefan
2009-03-20 8:50 ` Frederic Weisbecker
2009-03-20 10:26 ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 13:03 ` [PATCH 3/7] " Arnaldo Carvalho de Melo
2009-03-22 6:04 ` Li Zefan
2009-03-22 15:09 ` Arnaldo Carvalho de Melo
2009-03-21 15:18 ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 1:48 ` Li Zefan [this message]
2009-03-20 10:26 ` [tip:tracing/blktrace] blktrace: don't increase blk_probes_ref if failed to setup blk trace Li Zefan
2009-03-20 13:04 ` [PATCH 4/7] " Arnaldo Carvalho de Melo
2009-03-21 15:18 ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 1:49 ` [PATCH 5/7] blktrace: report EBUSY correctly Li Zefan
2009-03-20 10:26 ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 13:10 ` [PATCH 5/7] " Arnaldo Carvalho de Melo
2009-03-21 15:18 ` Ingo Molnar
2009-03-21 15:19 ` [tip:tracing/blktrace] " Li Zefan
2009-03-20 1:49 ` [PATCH 6/7] blktrace: remove sysfs_blk_trace_enable_show/store() Li Zefan
2009-03-20 3:33 ` Li Zefan
2009-03-20 10:26 ` [tip:tracing/blktrace] " Li Zefan
2009-03-21 15:19 ` Li Zefan
2009-03-20 13:07 ` [PATCH 6/7] " Arnaldo Carvalho de Melo
2009-03-20 1:49 ` [PATCH 7/7] blktrace: avoid accessing NULL bdev->bd_disk Li Zefan
2009-03-20 2:34 ` Li Zefan
2009-03-20 10:26 ` [tip:tracing/blktrace] " Li Zefan
2009-03-21 15:19 ` Li Zefan
2009-03-20 13:08 ` [PATCH 7/7] " Arnaldo Carvalho de Melo
2009-03-20 10:20 ` [PATCH 0/7] blktrace: various cleanups and fixes Ingo Molnar
2009-03-20 11:09 ` Ingo Molnar
2009-03-23 14:48 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C2F5FF.80002@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.