All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] Alsa-state: Wildcard removed and all *.state put back in the recipes
Date: Sun, 22 Mar 2009 20:15:33 +0100	[thread overview]
Message-ID: <200903222015.34575.marcin@juszkiewicz.com.pl> (raw)
In-Reply-To: <200903221929.57400.marcin@juszkiewicz.com.pl>


> > diff --git a/recipes/alsa/alsa-state.bb

I looked more at that recipe and found few bugs in it:

1. It assumes that 'asound.conf' is same for all devices. This is not
   true for 'at91sam9263ek' which kernel oops with default file.

2. It plays with INITSCRIPT_PARAMS in postinst script. I do not know
   maybe it was required in past but why it is present now? No idea and
   no info in recipe why it is that way.

3. Postinst script restore default ALSA settings which is ugly too - 
   what if user just muted all channels to have device quiet during 
   night and postinst just makes his 1000W 7.1 audio system goes to full
   volume at 02:00 at night?

4. With current version is is broken for a780 device which has few
   states files available.

Regards, 
-- 
JID:      hrw@jabber.org
Website:  http://marcin.juszkiewicz.com.pl/
LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz





  reply	other threads:[~2009-03-22 19:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-22 14:12 [PATCH] Alsa-state: Wildcard removed and all *.state put back in the recipes Matthieu Poullet
2009-03-22 14:49 ` Philip Balister
2009-03-22 16:39   ` Andrea Adami
2009-03-22 18:29 ` Marcin Juszkiewicz
2009-03-22 19:15   ` Marcin Juszkiewicz [this message]
2009-03-22 19:26     ` Marcin Juszkiewicz
2009-03-22 19:26   ` Marcin Juszkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200903222015.34575.marcin@juszkiewicz.com.pl \
    --to=marcin@juszkiewicz.com.pl \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.