Re: [PATCH] Alsa-state: Wildcard removed and all *.state put back in the recipes

[Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>]

Dnia niedziela, 22 marca 2009 o 20:15:33 Marcin Juszkiewicz napisał(a):
> > > diff --git a/recipes/alsa/alsa-state.bb
>
> I looked more at that recipe and found few bugs in it:
>
> 1. It assumes that 'asound.conf' is same for all devices. This is not
>    true for 'at91sam9263ek' which kernel oops with default file.

fixed in 139b0c1bad85fb628bc6a265a6da08dd190f684a

> 2. It plays with INITSCRIPT_PARAMS in postinst script. I do not know
>    maybe it was required in past but why it is present now? No idea
>    and no info in recipe why it is that way.

> 3. Postinst script restore default ALSA settings which is ugly too -
>    what if user just muted all channels to have device quiet during
>    night and postinst just makes his 1000W 7.1 audio system goes to
>    full volume at 02:00 at night?

> 4. With current version is is broken for a780 device which has few
>    states files available.

fixed in 30b5d30c274b2ae748ed65edea62cef40a23ce32

Regards, 
-- 
JID:      hrw@jabber.org
Website:  http://marcin.juszkiewicz.com.pl/
LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz