From: David Miller <davem@davemloft.net>
To: mchan@broadcom.com
Cc: waldi@debian.org, ben@decadent.org.uk, davem@davemloft.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] bnx2: Use request_firmware()
Date: Mon, 23 Mar 2009 15:02:22 -0700 (PDT) [thread overview]
Message-ID: <20090323.150222.165400092.davem@davemloft.net> (raw)
In-Reply-To: <1237844879.18617.20.camel@HP1>
From: "Michael Chan" <mchan@broadcom.com>
Date: Mon, 23 Mar 2009 14:47:59 -0700
> Yes, the patch looks good. I just noticed one problem while reviewing.
> The following logic to let the firmware know about the host CPU's page
> size is missing and I'll need to add it back. Otherwise it will only
> work on CPUs with 4K page size.
Ok.
> I'd also like to add the version information to the bnx2_fw_file_entry
> struct instead of embedding it in the file name. It is more flexible
> this way as each section can have different versions and can be updated
> separately. So it will look something like:
Fair enough.
> I'll generate an incremental patch on top of this one for review.
Thanks.
next prev parent reply other threads:[~2009-03-23 22:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-19 22:29 [PATCH] bnx2: Use request_firmware() Ben Hutchings
2009-03-19 23:04 ` Michael Chan
2009-03-19 23:25 ` Bastian Blank
2009-03-20 22:50 ` David Miller
2009-03-23 21:47 ` Michael Chan
2009-03-23 22:02 ` David Miller [this message]
2009-03-23 22:29 ` Bastian Blank
2009-03-23 23:24 ` Michael Chan
2009-03-24 0:14 ` Rick Jones
2009-03-24 1:11 ` Michael Chan
2009-03-24 1:26 ` Rick Jones
2009-03-24 1:44 ` Michael Chan
2009-03-24 4:27 ` Ben Hutchings
2009-03-24 7:42 ` Bastian Blank
2009-03-24 15:27 ` Michael Chan
2009-03-23 22:32 ` Bastian Blank
2009-03-23 23:28 ` Michael Chan
2009-04-01 18:01 ` Michael Chan
2009-04-02 8:05 ` David Miller
[not found] <1238778120-8132-1-git-send-email-mchan@broadcom.com>
2009-04-04 23:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090323.150222.165400092.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=waldi@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.