From: Theodore Tso <tytso@mit.edu>
To: Greg KH <greg@kroah.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>, Jan Kara <jack@suse.cz>,
Greg KH <gregkh@suse.de>,
mfasheh@suse.com, Andrew Morton <akpm@linux-foundation.org>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
stable@kernel.org, Dan Carpenter <error27@gmail.com>,
mfasheh@suse.de, linux-ext4@vger.kernel.org,
ocfs2-devel@oss.oracle.com
Subject: Re: [stable] Linux 2.6.28.8 (ocfs2 build failure)
Date: Sun, 22 Mar 2009 22:44:04 -0400 [thread overview]
Message-ID: <20090323024404.GA14082@mit.edu> (raw)
In-Reply-To: <20090320221750.GA32416@kroah.com>
On Fri, Mar 20, 2009 at 03:17:50PM -0700, Greg KH wrote:
>
> I tracked this down to commit 54dc90 in the 2.6.28.8 tree.
>
> I've included it below. Jan and Ted, any ideas on how to fix this
> error?
2.6.29 dropped the CONFIG_OCFS2_COMPAT_JBD option; if you enable it,
causes a compile failure in 2.6.28.8. This should fix it...
diff --git a/fs/ocfs2/ocfs2_jbd_compat.h b/fs/ocfs2/ocfs2_jbd_compat.h
index b91c78f..268949b 100644
--- a/fs/ocfs2/ocfs2_jbd_compat.h
+++ b/fs/ocfs2/ocfs2_jbd_compat.h
@@ -60,7 +60,8 @@ static inline int jbd2_journal_file_inode(handle_t *handle,
return 0;
}
-static inline int jbd2_journal_begin_ordered_truncate(struct jbd2_inode *inode,
+static inline int jbd2_journal_begin_ordered_truncate(journal_t *journal,
+ struct jbd2_inode *inode,
loff_t new_size)
{
return 0;
> Should I just revert this from the 2.6.28 tree? Or does no one really
> care about ocfs2 in the stable tree?
I'm not sure how much people will care about CONFIG_OCFS2_COMPAT_JBD,
given that it disappears in 2.6.29, but the above patch should fix
things.
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: Theodore Tso <tytso@mit.edu>
To: Greg KH <greg@kroah.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>, Jan Kara <jack@suse.cz>,
Greg KH <gregkh@suse.de>,
mfasheh@suse.com, Andrew Morton <akpm@linux-foundation.org>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
stable@kernel.org, Dan Carpenter <error27@gmail.com>,
mfasheh@suse.de, linux-ext4@vger.kernel.org,
ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [stable] Linux 2.6.28.8 (ocfs2 build failure)
Date: Mon, 23 Mar 2009 02:44:13 -0000 [thread overview]
Message-ID: <20090323024404.GA14082@mit.edu> (raw)
In-Reply-To: <20090320221750.GA32416@kroah.com>
On Fri, Mar 20, 2009 at 03:17:50PM -0700, Greg KH wrote:
>
> I tracked this down to commit 54dc90 in the 2.6.28.8 tree.
>
> I've included it below. Jan and Ted, any ideas on how to fix this
> error?
2.6.29 dropped the CONFIG_OCFS2_COMPAT_JBD option; if you enable it,
causes a compile failure in 2.6.28.8. This should fix it...
diff --git a/fs/ocfs2/ocfs2_jbd_compat.h b/fs/ocfs2/ocfs2_jbd_compat.h
index b91c78f..268949b 100644
--- a/fs/ocfs2/ocfs2_jbd_compat.h
+++ b/fs/ocfs2/ocfs2_jbd_compat.h
@@ -60,7 +60,8 @@ static inline int jbd2_journal_file_inode(handle_t *handle,
return 0;
}
-static inline int jbd2_journal_begin_ordered_truncate(struct jbd2_inode *inode,
+static inline int jbd2_journal_begin_ordered_truncate(journal_t *journal,
+ struct jbd2_inode *inode,
loff_t new_size)
{
return 0;
> Should I just revert this from the 2.6.28 tree? Or does no one really
> care about ocfs2 in the stable tree?
I'm not sure how much people will care about CONFIG_OCFS2_COMPAT_JBD,
given that it disappears in 2.6.29, but the above patch should fix
things.
- Ted
next prev parent reply other threads:[~2009-03-23 2:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 1:20 Linux 2.6.28.8 Greg KH
2009-03-17 1:20 ` Greg KH
2009-03-17 20:26 ` Linux 2.6.28.8 (ocfs2 build failure) Randy Dunlap
2009-03-17 20:55 ` [stable] " Greg KH
2009-03-17 21:02 ` Randy Dunlap
2009-03-20 22:17 ` Greg KH
2009-03-20 22:18 ` [Ocfs2-devel] " Greg KH
2009-03-23 2:44 ` Theodore Tso [this message]
2009-03-23 2:44 ` Theodore Tso
2009-03-24 0:13 ` Greg KH
2009-03-24 0:16 ` [Ocfs2-devel] " Greg KH
2009-03-24 0:13 ` Greg KH
2009-03-24 3:05 ` Theodore Tso
2009-03-24 3:05 ` [Ocfs2-devel] " Theodore Tso
2009-03-24 19:05 ` Mark Fasheh
2009-03-24 19:05 ` [Ocfs2-devel] " Mark Fasheh
2009-03-24 19:05 ` Mark Fasheh
2009-03-23 15:08 ` Linux 2.6.28.8 Martin Knoblauch
2009-03-23 23:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090323024404.GA14082@mit.edu \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=error27@gmail.com \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=mfasheh@suse.de \
--cc=ocfs2-devel@oss.oracle.com \
--cc=randy.dunlap@oracle.com \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.