All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
To: Christian Lamparter <chunkeey-S0/GAf8tV78@public.gmane.org>
Cc: Kalle Valo <kalle.valo-X3B1VOXEql0@public.gmane.org>,
	Michael Buesch <mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>,
	Randy Dunlap
	<randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>,
	linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] p54: fix SoftLED compile dependencies
Date: Mon, 23 Mar 2009 10:13:20 -0400	[thread overview]
Message-ID: <20090323141320.GC3285@tuxdriver.com> (raw)
In-Reply-To: <200903211322.01654.chunkeey-S0/GAf8tV78@public.gmane.org>

On Sat, Mar 21, 2009 at 01:22:01PM +0100, Christian Lamparter wrote:
> On Saturday 21 March 2009 07:36:33 Kalle Valo wrote:
> > Christian Lamparter <chunkeey-S0/GAf8tV78@public.gmane.org> writes:
> > 
> > > This patch fixes a compile problem when the MAC80211_LEDS
> > > triggers are enabled but not LED class itself. 
> > > (which is sort of pointless, but anyway...)
> > 
> > [...]
> > 
> > > @@ -17,31 +18,6 @@ config P54_USB
> > >  	select CRC32
> > >  	---help---
> > >  	  This driver is for USB isl38xx based wireless cards.
> > > -	  These are USB based adapters found in devices such as:
> > > -
> > > -	  3COM 3CRWE254G72
> > > -	  SMC 2862W-G
> > > -	  Accton 802.11g WN4501 USB
> > > -	  Siemens Gigaset USB
> > > -	  Netgear WG121
> > > -	  Netgear WG111
> > > -	  Medion 40900, Roper Europe
> > > -	  Shuttle PN15, Airvast WM168g, IOGear GWU513
> > > -	  Linksys WUSB54G
> > > -	  Linksys WUSB54G Portable
> > > -	  DLink DWL-G120 Spinnaker
> > > -	  DLink DWL-G122
> > > -	  Belkin F5D7050 ver 1000
> > > -	  Cohiba Proto board
> > > -	  SMC 2862W-G version 2
> > > -	  U.S. Robotics U5 802.11g Adapter
> > > -	  FUJITSU E-5400 USB D1700
> > > -	  Sagem XG703A
> > > -	  DLink DWL-G120 Cohiba
> > > -	  Spinnaker Proto board
> > > -	  Linksys WUSB54AG
> > > -	  Inventel UR054G
> > > -	  Spinnaker DUT
> > 
> > This change wasn't mentioned in the commit log. Did this get included
> > by accident?
> > 
> heh true... should I add them back? after all this list hasn't changed in years
> and we have a much nicer one on http://www.prism54.org/
> ( http://wireless.kernel.org/en/users/Drivers/p54/devices )

Getting rid of them is fine, but it should probably be done in a different patch.

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville@tuxdriver.com>
To: Christian Lamparter <chunkeey@web.de>
Cc: Kalle Valo <kalle.valo@iki.fi>, Michael Buesch <mb@bu3sch.de>,
	Randy Dunlap <randy.dunlap@oracle.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH] p54: fix SoftLED compile dependencies
Date: Mon, 23 Mar 2009 10:13:20 -0400	[thread overview]
Message-ID: <20090323141320.GC3285@tuxdriver.com> (raw)
In-Reply-To: <200903211322.01654.chunkeey@web.de>

On Sat, Mar 21, 2009 at 01:22:01PM +0100, Christian Lamparter wrote:
> On Saturday 21 March 2009 07:36:33 Kalle Valo wrote:
> > Christian Lamparter <chunkeey@web.de> writes:
> > 
> > > This patch fixes a compile problem when the MAC80211_LEDS
> > > triggers are enabled but not LED class itself. 
> > > (which is sort of pointless, but anyway...)
> > 
> > [...]
> > 
> > > @@ -17,31 +18,6 @@ config P54_USB
> > >  	select CRC32
> > >  	---help---
> > >  	  This driver is for USB isl38xx based wireless cards.
> > > -	  These are USB based adapters found in devices such as:
> > > -
> > > -	  3COM 3CRWE254G72
> > > -	  SMC 2862W-G
> > > -	  Accton 802.11g WN4501 USB
> > > -	  Siemens Gigaset USB
> > > -	  Netgear WG121
> > > -	  Netgear WG111
> > > -	  Medion 40900, Roper Europe
> > > -	  Shuttle PN15, Airvast WM168g, IOGear GWU513
> > > -	  Linksys WUSB54G
> > > -	  Linksys WUSB54G Portable
> > > -	  DLink DWL-G120 Spinnaker
> > > -	  DLink DWL-G122
> > > -	  Belkin F5D7050 ver 1000
> > > -	  Cohiba Proto board
> > > -	  SMC 2862W-G version 2
> > > -	  U.S. Robotics U5 802.11g Adapter
> > > -	  FUJITSU E-5400 USB D1700
> > > -	  Sagem XG703A
> > > -	  DLink DWL-G120 Cohiba
> > > -	  Spinnaker Proto board
> > > -	  Linksys WUSB54AG
> > > -	  Inventel UR054G
> > > -	  Spinnaker DUT
> > 
> > This change wasn't mentioned in the commit log. Did this get included
> > by accident?
> > 
> heh true... should I add them back? after all this list hasn't changed in years
> and we have a much nicer one on http://www.prism54.org/
> ( http://wireless.kernel.org/en/users/Drivers/p54/devices )

Getting rid of them is fine, but it should probably be done in a different patch.

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  parent reply	other threads:[~2009-03-23 14:13 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-19 11:10 linux-next: Tree for March 19 Stephen Rothwell
2009-03-19 13:20 ` Next March 19: drivers/comedi build break Sachin Sant
2009-03-19 15:33   ` Greg KH
2009-03-19 18:51     ` Greg KH
2009-03-19 16:54 ` linux-next: Tree for March 19 (media/video/au0828) Randy Dunlap
2009-03-19 22:28   ` Mauro Carvalho Chehab
2009-03-19 17:07 ` linux-next: Tree for March 19 (staging/psb) Randy Dunlap
2009-03-19 18:51   ` Greg KH
2009-03-19 17:11 ` linux-next: Tree for March 19 (media/au8522) Randy Dunlap
2009-03-20  0:06   ` Mauro Carvalho Chehab
2009-03-19 17:13 ` linux-next: Tree for March 19 (media/video/cx231xx/) Randy Dunlap
2009-03-19 17:28 ` linux-next: Tree for March 19 (wireless/p54) Randy Dunlap
     [not found]   ` <49C280BE.8090106-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2009-03-19 17:50     ` Michael Buesch
2009-03-19 17:50       ` Michael Buesch
2009-03-19 18:49       ` Randy Dunlap
2009-03-19 18:55         ` Michael Buesch
     [not found]           ` <200903191955.00718.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2009-03-20 23:57             ` [PATCH] p54: fix SoftLED compile dependencies Christian Lamparter
2009-03-20 23:57               ` Christian Lamparter
2009-03-21  6:36               ` Kalle Valo
2009-03-21  6:36                 ` Kalle Valo
2009-03-21 12:22                 ` Christian Lamparter
     [not found]                   ` <200903211322.01654.chunkeey-S0/GAf8tV78@public.gmane.org>
2009-03-21 12:27                     ` Kalle Valo
2009-03-21 12:27                       ` Kalle Valo
     [not found]                       ` <873ad7dpru.fsf-4yk3W8r0N7SEazanehQPrg@public.gmane.org>
2009-03-21 15:26                         ` Larry Finger
2009-03-21 15:26                           ` Larry Finger
2009-03-23 14:13                     ` John W. Linville [this message]
2009-03-23 14:13                       ` John W. Linville
     [not found]                       ` <20090323141320.GC3285-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2009-03-23 14:37                         ` [PATCH v2] " Christian Lamparter
2009-03-23 14:37                           ` Christian Lamparter
2009-03-23  1:00               ` [PATCH] " Randy Dunlap
2009-03-23 14:14               ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090323141320.GC3285@tuxdriver.com \
    --to=linville-2xusbdqka4r54taoqtywwq@public.gmane.org \
    --cc=chunkeey-S0/GAf8tV78@public.gmane.org \
    --cc=kalle.valo-X3B1VOXEql0@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org \
    --cc=randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.