All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robin Holt <holt@sgi.com>
To: Chuck Lever <chuck.lever@oracle.com>, tony.luck@intel.com
Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: kernel unaligned accesses on 2.6.29.
Date: Wed, 25 Mar 2009 01:21:01 +0000	[thread overview]
Message-ID: <20090325012101.GC8908@sgi.com> (raw)
In-Reply-To: <20090325011418.GB8908@sgi.com>

On Tue, Mar 24, 2009 at 08:14:18PM -0500, Robin Holt wrote:
> Had a few minutes to look around.
...
> This one is:
> 	u64 *p = (u64 *)&nsm->sm_priv.data;
> 	...
> 	*p = (unsigned long)nsm;
...
> >     e3d0:       0a 60 28 1c 8d 39       [MMI]       cmp4.eq p12,p13\x10,r14;;
> >     e3d6:       00 a8 95 30 23 00                   st8 [r37]=r53
> 

Well, that was easy.  This is the store part of
	*p++ = timespec_to_ns(&ts);

Again, comes down to &nsm->sm_priv.data not being aligned.

Robin

WARNING: multiple messages have this Message-ID (diff)
From: Robin Holt <holt@sgi.com>
To: Chuck Lever <chuck.lever@oracle.com>, tony.luck@intel.com
Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: kernel unaligned accesses on 2.6.29.
Date: Tue, 24 Mar 2009 20:21:01 -0500	[thread overview]
Message-ID: <20090325012101.GC8908@sgi.com> (raw)
In-Reply-To: <20090325011418.GB8908@sgi.com>

On Tue, Mar 24, 2009 at 08:14:18PM -0500, Robin Holt wrote:
> Had a few minutes to look around.
...
> This one is:
> 	u64 *p = (u64 *)&nsm->sm_priv.data;
> 	...
> 	*p = (unsigned long)nsm;
...
> >     e3d0:       0a 60 28 1c 8d 39       [MMI]       cmp4.eq p12,p13=10,r14;;
> >     e3d6:       00 a8 95 30 23 00                   st8 [r37]=r53
> 

Well, that was easy.  This is the store part of
	*p++ = timespec_to_ns(&ts);

Again, comes down to &nsm->sm_priv.data not being aligned.

Robin

  reply	other threads:[~2009-03-25  1:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-24 17:28 kernel unaligned accesses on 2.6.29 Robin Holt
2009-03-25  1:14 ` Robin Holt
2009-03-25  1:14   ` Robin Holt
2009-03-25  1:21   ` Robin Holt [this message]
2009-03-25  1:21     ` Robin Holt
2009-03-25  2:04   ` David Miller
2009-03-25  2:04     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090325012101.GC8908@sgi.com \
    --to=holt@sgi.com \
    --cc=chuck.lever@oracle.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.