All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: "H. Peter Anvin" <hpa@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Jaswinder Singh Rajput <jaswinder@kernel.org>,
	Ingo Molnar <mingo@elte.hu>, x86 maintainers <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git-pull -tip] x86: include inverse Xmas tree patches
Date: Sat, 28 Mar 2009 22:37:40 +0000	[thread overview]
Message-ID: <20090328223740.GD28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <49CEA3CD.105@kernel.org>

On Sat, Mar 28, 2009 at 03:25:17PM -0700, H. Peter Anvin wrote:
> Sam Ravnborg wrote:
> > 
> > Ordering include based on length of line minimize the
> > risk of merge conflicts.
> > If people just add new includes in the bottom of the list you
> > are certain that a merge conflit happens.
> > 
> > This scheme is starting to be used in several places with the
> > primary advocates being David Miller and Ingo.
> > 
> > It is getting used both for includes _and_ for local variables.
> > 
> 
> Personally I'd prefer alphabetic order, sorting based on length isn't a
> complete ordering.  Nearly all editors can sort alphabetically at the
> push of a key.

*shrug*

FWIW, the real problem is that we have far too many includes in a typical
file; the ordering wouldn't matter if there would be 4-5 #include in
foo.c.  Inventing elaborate policies to cope with that crap instead of
addressing the root cause (namely, cut'n'paste approach to includes) is
rather pointless...

  reply	other threads:[~2009-03-28 22:38 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-28 14:48 [git-pull -tip] x86: include inverse Xmas tree patches Jaswinder Singh Rajput
2009-03-28 15:07 ` Joerg Roedel
2009-03-28 16:48   ` Jaswinder Singh Rajput
2009-03-28 17:16     ` Jaswinder Singh Rajput
2009-03-28 15:07 ` Alexey Dobriyan
2009-03-28 15:55   ` Alan Cox
2009-03-28 15:58     ` Alexey Dobriyan
2009-03-28 16:11       ` Jaswinder Singh Rajput
2009-03-28 16:28       ` Alan Cox
2009-03-28 19:03   ` Sam Ravnborg
2009-03-28 22:25     ` H. Peter Anvin
2009-03-28 22:37       ` Al Viro [this message]
2009-03-28 23:31       ` Thomas Gleixner
2009-03-28 23:34         ` Ingo Molnar
2009-03-28 23:39           ` Thomas Gleixner
2009-03-29  0:00             ` Ingo Molnar
2009-03-29  0:24               ` Al Viro
2009-03-29 10:25               ` Alexey Dobriyan
2009-03-29  0:28             ` Thomas Gleixner
2009-03-29  1:58               ` Ingo Molnar
2009-03-29  7:57       ` Jaswinder Singh Rajput
2009-03-28 15:17 ` Hugh Dickins
2009-03-28 23:40   ` Ingo Molnar
2009-03-29  6:38     ` Jaswinder Singh Rajput
2009-03-29 11:46       ` Thomas Gleixner
2009-03-29 14:38         ` Jaswinder Singh Rajput
2009-03-28 23:35 ` Ingo Molnar
2009-03-29  5:54   ` Jaswinder Singh Rajput

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090328223740.GD28946@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=adobriyan@gmail.com \
    --cc=hpa@kernel.org \
    --cc=jaswinder@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sam@ravnborg.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.