From: Ingo Molnar <mingo@elte.hu>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "H. Peter Anvin" <hpa@kernel.org>,
Sam Ravnborg <sam@ravnborg.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Jaswinder Singh Rajput <jaswinder@kernel.org>,
x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git-pull -tip] x86: include inverse Xmas tree patches
Date: Sun, 29 Mar 2009 03:58:05 +0200 [thread overview]
Message-ID: <20090329015805.GA20846@elte.hu> (raw)
In-Reply-To: <alpine.LFD.2.00.0903290055080.3397@localhost.localdomain>
* Thomas Gleixner <tglx@linutronix.de> wrote:
> I just run the following on current git:
>
> # FS=`find -type f`; for F in $FS; do grep -c "#include" $F; done | sort -n | uniq -c
>
> The top 5 are:
>
> lib/locking-selftest.c: 108 (justified as this includes all the test cases)
> fs/compat_ioctl.c 88 (maybe ok as it is the all in one kitchen sink)
> arch/x86/kernel/setup.c: 76 (completely nuts)
[yep]
> init/main.c: 62 (needs to be looked at)
> security/selinux/hooks.c 61 (needs to be looked at, spotted at least 5 which can be removed)
>
> 1400 files have more than 20 includes. 5375 more than 10.
>
> I think it's well justified to sit down and work on a tool which
> helps us analyse and distangle that mess.
yeah.
Ingo
next prev parent reply other threads:[~2009-03-29 1:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-28 14:48 [git-pull -tip] x86: include inverse Xmas tree patches Jaswinder Singh Rajput
2009-03-28 15:07 ` Joerg Roedel
2009-03-28 16:48 ` Jaswinder Singh Rajput
2009-03-28 17:16 ` Jaswinder Singh Rajput
2009-03-28 15:07 ` Alexey Dobriyan
2009-03-28 15:55 ` Alan Cox
2009-03-28 15:58 ` Alexey Dobriyan
2009-03-28 16:11 ` Jaswinder Singh Rajput
2009-03-28 16:28 ` Alan Cox
2009-03-28 19:03 ` Sam Ravnborg
2009-03-28 22:25 ` H. Peter Anvin
2009-03-28 22:37 ` Al Viro
2009-03-28 23:31 ` Thomas Gleixner
2009-03-28 23:34 ` Ingo Molnar
2009-03-28 23:39 ` Thomas Gleixner
2009-03-29 0:00 ` Ingo Molnar
2009-03-29 0:24 ` Al Viro
2009-03-29 10:25 ` Alexey Dobriyan
2009-03-29 0:28 ` Thomas Gleixner
2009-03-29 1:58 ` Ingo Molnar [this message]
2009-03-29 7:57 ` Jaswinder Singh Rajput
2009-03-28 15:17 ` Hugh Dickins
2009-03-28 23:40 ` Ingo Molnar
2009-03-29 6:38 ` Jaswinder Singh Rajput
2009-03-29 11:46 ` Thomas Gleixner
2009-03-29 14:38 ` Jaswinder Singh Rajput
2009-03-28 23:35 ` Ingo Molnar
2009-03-29 5:54 ` Jaswinder Singh Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090329015805.GA20846@elte.hu \
--to=mingo@elte.hu \
--cc=adobriyan@gmail.com \
--cc=hpa@kernel.org \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.