From: Nathan Froyd <froydnj@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/4] target-ppc: create TCG slots for registers based on CPU
Date: Sat, 28 Mar 2009 17:18:34 -0700 [thread overview]
Message-ID: <20090329001834.GK7336@codesourcery.com> (raw)
In-Reply-To: <20090328225443.GL20944@hall.aurel32.net>
On Sat, Mar 28, 2009 at 11:54:43PM +0100, Aurelien Jarno wrote:
> On Sat, Mar 28, 2009 at 02:30:13PM -0700, Nathan Froyd wrote:
> > I am not a TCG expert, but there are several loops in TCG over all
> > globals and it seems like those loops would go faster if they didn't
> > have to consider registers that would never be touched. If this patch
> > series makes no difference in TCG's performance, then I'd be glad to
> > have an explanation of why that's the case.
>
> Do you actually have run a benchmark with those changes? TCG is
> sometimes a bit strange, and some optimizations does not change the
> execution speed, while others improve it a lot. It is very difficult to
> predict what will give a gain or not.
>
> Suggestions of benchmarks: gzip/bzip2 on a big file using user emulation
> or a compilation in system emulation.
Benchmarking? Pffft. ;)
A benchmarking session with qemu-ppc and bzip2/bunzip2 on ~400MB files
and a 603e emulated CPU suggests that these changes are not terribly
beneficial (maybe 1% improvement, if that). I don't imagine that a
similarly stressful benchmark in system emulation would be much
different. Consider the patch series withdrawn.
-Nathan
next prev parent reply other threads:[~2009-03-29 0:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-28 21:30 [Qemu-devel] [PATCH 0/4] target-ppc: create TCG slots for registers based on CPU Nathan Froyd
2009-03-28 21:30 ` [Qemu-devel] [PATCH 1/4] move PPC insn flags to cpu.h Nathan Froyd
2009-03-28 22:58 ` Aurelien Jarno
2009-03-28 23:07 ` Nathan Froyd
2009-03-28 23:14 ` Aurelien Jarno
2009-03-28 21:30 ` [Qemu-devel] [PATCH 2/4] move ppc_def_t definition " Nathan Froyd
2009-03-28 21:30 ` [Qemu-devel] [PATCH 3/4] pass the cpu definition to ppc_translate_init Nathan Froyd
2009-03-28 21:30 ` [Qemu-devel] [PATCH 4/4] create TCG slots for registers based on CPU Nathan Froyd
2009-03-28 22:54 ` [Qemu-devel] [PATCH 0/4] target-ppc: " Aurelien Jarno
2009-03-29 0:18 ` Nathan Froyd [this message]
2009-03-29 13:34 ` Aurelien Jarno
2009-03-29 14:42 ` Aurelien Jarno
2009-03-29 14:57 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090329001834.GK7336@codesourcery.com \
--to=froydnj@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.