From: Arnd Bergmann <arnd@arndb.de>
To: Harry Ciao <qingtao.cao@windriver.com>
Cc: linuxppc-dev@ozlabs.org, norsk5@yahoo.com,
linux-kernel@vger.kernel.org,
bluesmoke-devel@lists.sourceforge.net
Subject: Re: [v0 PATCH 5/5] EDAC: CPC925 MC platform device setup
Date: Thu, 2 Apr 2009 14:36:44 +0200 [thread overview]
Message-ID: <200904021436.44822.arnd@arndb.de> (raw)
In-Reply-To: <1238652440-9224-6-git-send-email-qingtao.cao@windriver.com>
On Thursday 02 April 2009, Harry Ciao wrote:
> +#ifdef CONFIG_EDAC
> +#define CPC925_MC_START=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A00=
xf8000000
> +#define CPC925_MC_END=A0=A0=A0=A0=A0=A0=A0=A0=A0=A00xf8ffffff /* sizeof =
16MB */
> +/* Register a platform device for CPC925 memory controller */
> +static int __init maple_cpc925_edac_setup(void)
It's not good to have these encoded as magic numbers.
Can't you find the addresses in the device tree? Maybe it's
even possible to make this an of_platform_driver if you
find a good node to bind to.
Does the driver also work on a G5 Mac, or is it limited
to the maple platform?
Arnd <><
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Harry Ciao <qingtao.cao@windriver.com>
Cc: norsk5@yahoo.com, linux-kernel@vger.kernel.org,
bluesmoke-devel@lists.sourceforge.net, linuxppc-dev@ozlabs.org
Subject: Re: [v0 PATCH 5/5] EDAC: CPC925 MC platform device setup
Date: Thu, 2 Apr 2009 14:36:44 +0200 [thread overview]
Message-ID: <200904021436.44822.arnd@arndb.de> (raw)
In-Reply-To: <1238652440-9224-6-git-send-email-qingtao.cao@windriver.com>
On Thursday 02 April 2009, Harry Ciao wrote:
> +#ifdef CONFIG_EDAC
> +#define CPC925_MC_START 0xf8000000
> +#define CPC925_MC_END 0xf8ffffff /* sizeof 16MB */
> +/* Register a platform device for CPC925 memory controller */
> +static int __init maple_cpc925_edac_setup(void)
It's not good to have these encoded as magic numbers.
Can't you find the addresses in the device tree? Maybe it's
even possible to make this an of_platform_driver if you
find a good node to bind to.
Does the driver also work on a G5 Mac, or is it limited
to the maple platform?
Arnd <><
next prev parent reply other threads:[~2009-04-02 12:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-02 6:07 [v0 PATCH 0/5] Add CPC925 Memory Controller EDAC drivers Harry Ciao
2009-04-02 6:07 ` [v0 PATCH 1/5] EDAC: Add CPC925 driver header file Harry Ciao
2009-04-02 6:07 ` [v0 PATCH 2/5] EDAC: Add CPC925 driver source file Harry Ciao
2009-04-02 6:07 ` [v0 PATCH 3/5] EDAC: Add CPC925 driver Kconfig & Makefile Harry Ciao
2009-04-02 6:07 ` [v0 PATCH 4/5] EDAC: Add edac_device_alloc_index() Harry Ciao
2009-04-02 6:07 ` [v0 PATCH 5/5] EDAC: CPC925 MC platform device setup Harry Ciao
2009-04-02 12:36 ` Arnd Bergmann [this message]
2009-04-02 12:36 ` Arnd Bergmann
2009-04-03 3:17 ` Harry Ciao
2009-04-03 3:17 ` Harry Ciao
2009-04-03 5:49 ` Harry Ciao
2009-04-03 5:49 ` Harry Ciao
2009-04-02 12:34 ` [v0 PATCH 3/5] EDAC: Add CPC925 driver Kconfig & Makefile Arnd Bergmann
2009-04-03 3:12 ` Harry Ciao
2009-04-02 12:40 ` [v0 PATCH 2/5] EDAC: Add CPC925 driver source file Arnd Bergmann
2009-04-02 12:40 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904021436.44822.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=bluesmoke-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=norsk5@yahoo.com \
--cc=qingtao.cao@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.