All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ladislav Michl <ladis@linux-mips.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] core ticks/timer code
Date: Thu, 2 Apr 2009 21:16:28 +0200	[thread overview]
Message-ID: <20090402191628.GA16618@localhost.localdomain> (raw)
In-Reply-To: <49D23CE1.9060906@googlemail.com>

Dirk,

On Tue, Mar 31, 2009 at 05:55:13PM +0200, Dirk Behme wrote:
> ... I'd like that we split general ticks/timer code clean 
> up and bug fixes. I'd like that we implement the changes proposed by 
> Mike and Jean-Christophe independent and don't mix them with other 
> fixes for broken timer code like
> 
> http://lists.denx.de/pipermail/u-boot/2009-March/049146.html
> 
> Having proper/fixed (old style) timer code will make it easier to 
> convert to new style afterwards.
> 
>  From my point of view this is similar to rule "don't mix coding style 
> with functional changes".

Well the very same bug is present in OMAP1 and OMAP2 timer code, so you'll
end fixing copied&paste code for no good reason.
At least cpu/arm925t/interrupts.c and cpu/arm926ejs/omap/timer.c deserves the
same fix [*] you sent for OMAP3 code. So what about merging that timer code
first and then fixing it?

	ladis

[*] I have local fix for cpu/arm925t/interrupts.c, but since those copy&pasted
files started diverging just because each of us cares about different piece of
hardware, I do not want to make situation even worse.

  reply	other threads:[~2009-04-02 19:16 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-28  1:30 [U-Boot] core ticks/timer code Mike Frysinger
2009-03-28  7:07 ` Dirk Behme
2009-03-31  1:10   ` Mike Frysinger
2009-03-31 11:41     ` Scott McNutt
2009-03-31 15:48       ` Wolfgang Denk
2009-03-31 21:25         ` Scott Wood
2009-03-31 21:27           ` Wolfgang Denk
2009-04-02 12:38             ` Detlev Zundel
2009-04-02 13:09               ` Scott McNutt
2009-03-31 20:46   ` Wolfgang Denk
2009-03-31  8:17 ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-31  9:13   ` Mike Frysinger
2009-03-31 10:28     ` Wolfgang Denk
2009-03-31 11:25       ` Mike Frysinger
2009-03-31 11:41         ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-31 15:55           ` Dirk Behme
2009-04-02 19:16             ` Ladislav Michl [this message]
2009-04-02 21:18               ` Graeme Russ
2009-04-04 21:35                 ` Wolfgang Denk
2009-03-31 15:46         ` Wolfgang Denk
2009-03-31 11:39       ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-31 15:49         ` Wolfgang Denk
2009-03-31 21:32           ` Scott Wood
2009-04-04 21:14             ` Wolfgang Denk
2009-04-06 19:12               ` Scott Wood
2009-04-06 19:43                 ` Wolfgang Denk
2009-03-31 20:43 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090402191628.GA16618@localhost.localdomain \
    --to=ladis@linux-mips.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.