All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wu Fengguang <fengguang.wu@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ying Han <yinghan@google.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org, mingo@elte.hu,
	mikew@google.com, rientjes@google.com, rohitseth@google.com,
	hugh@veritas.com, a.p.zijlstra@chello.nl, hpa@zytor.com,
	edwintorok@gmail.com, lee.schermerhorn@hp.com, npiggin@suse.de
Subject: [PATCH] vfs: reduce page fault retry code
Date: Fri, 3 Apr 2009 16:55:03 +0800	[thread overview]
Message-ID: <20090403085503.GC6084@localhost> (raw)
In-Reply-To: <20090403083559.GB6084@localhost>

find_lock_page_retry() works the same way as find_lock_page()
when retry_flag=0. And their return value handling shall work
(almost) in the same way, or it will already be a bug.

So the !retry_flag special casing can be eliminated.

Cc: Ying Han <yinghan@google.com>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
 mm/filemap.c |    7 -------
 1 file changed, 7 deletions(-)

--- mm.orig/mm/filemap.c
+++ mm/mm/filemap.c
@@ -1663,13 +1663,6 @@ no_cached_page:
 	 * meantime, we'll just come back here and read it again.
 	 */
 	if (error >= 0) {
-		/*
-		 * If caller cannot tolerate a retry in the ->fault path
-		 * go back to check the page again.
-		 */
-		if (!retry_flag)
-			goto retry_find;
-
 		retry_ret = find_lock_page_retry(mapping, vmf->pgoff,
 					vma, &page, retry_flag);
 		if (retry_ret == VM_FAULT_RETRY)

WARNING: multiple messages have this Message-ID (diff)
From: Wu Fengguang <fengguang.wu@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ying Han <yinghan@google.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org, mingo@elte.hu,
	mikew@google.com, rientjes@google.com, rohitseth@google.com,
	hugh@veritas.com, a.p.zijlstra@chello.nl, hpa@zytor.com,
	edwintorok@gmail.com, lee.schermerhorn@hp.com, npiggin@suse.de
Subject: [PATCH] vfs: reduce page fault retry code
Date: Fri, 3 Apr 2009 16:55:03 +0800	[thread overview]
Message-ID: <20090403085503.GC6084@localhost> (raw)
In-Reply-To: <20090403083559.GB6084@localhost>

find_lock_page_retry() works the same way as find_lock_page()
when retry_flag=0. And their return value handling shall work
(almost) in the same way, or it will already be a bug.

So the !retry_flag special casing can be eliminated.

Cc: Ying Han <yinghan@google.com>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
 mm/filemap.c |    7 -------
 1 file changed, 7 deletions(-)

--- mm.orig/mm/filemap.c
+++ mm/mm/filemap.c
@@ -1663,13 +1663,6 @@ no_cached_page:
 	 * meantime, we'll just come back here and read it again.
 	 */
 	if (error >= 0) {
-		/*
-		 * If caller cannot tolerate a retry in the ->fault path
-		 * go back to check the page again.
-		 */
-		if (!retry_flag)
-			goto retry_find;
-
 		retry_ret = find_lock_page_retry(mapping, vmf->pgoff,
 					vma, &page, retry_flag);
 		if (retry_ret == VM_FAULT_RETRY)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-04-03  8:55 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-05 19:40 [RFC v2][PATCH]page_fault retry with NOPAGE_RETRY Ying Han
2008-12-05 19:40 ` Ying Han
2008-12-06  9:52 ` Török Edwin
2008-12-06  9:52   ` Török Edwin
2008-12-06  9:55   ` Török Edwin
2008-12-06  9:55     ` Török Edwin
2008-12-08  1:43     ` Ying Han
2008-12-08  1:43       ` Ying Han
2008-12-09 17:57       ` Ying Han
2008-12-09 17:57         ` Ying Han
2008-12-09 19:31 ` Andrew Morton
2008-12-09 19:31   ` Andrew Morton
2009-01-26 19:37 ` Andrew Morton
2009-01-26 19:37   ` Andrew Morton
     [not found]   ` <604427e00901261508n7967ea74m3deacd3213c86065@mail.gmail.com>
2009-01-26 23:52     ` Andrew Morton
2009-01-26 23:52       ` Andrew Morton
2009-01-26 23:57       ` Ingo Molnar
2009-01-26 23:57         ` Ingo Molnar
2009-01-27  4:34         ` KOSAKI Motohiro
2009-01-27  4:34           ` KOSAKI Motohiro
2009-03-31 22:00 ` Andrew Morton
2009-03-31 22:00   ` Andrew Morton
2009-04-01  0:17   ` Ying Han
2009-04-01  0:17     ` Ying Han
2009-04-03  8:22   ` [PATCH] vfs: fix find_lock_page_retry() return value parsing Wu Fengguang
2009-04-03  8:22     ` Wu Fengguang
2009-04-03  8:35     ` [PATCH v2] " Wu Fengguang
2009-04-03  8:35       ` Wu Fengguang
2009-04-03  8:55       ` Wu Fengguang [this message]
2009-04-03  8:55         ` [PATCH] vfs: reduce page fault retry code Wu Fengguang
2009-04-03 10:53         ` Wu Fengguang
2009-04-03 10:53           ` Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090403085503.GC6084@localhost \
    --to=fengguang.wu@intel.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=edwintorok@gmail.com \
    --cc=hpa@zytor.com \
    --cc=hugh@veritas.com \
    --cc=lee.schermerhorn@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mikew@google.com \
    --cc=mingo@elte.hu \
    --cc=npiggin@suse.de \
    --cc=rientjes@google.com \
    --cc=rohitseth@google.com \
    --cc=yinghan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.