All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
	cbe-oss-dev@ozlabs.org
Subject: Re: [PATCH] ps3vram: Replace mutex by spinlock + list
Date: Fri, 3 Apr 2009 20:03:17 +0200	[thread overview]
Message-ID: <20090403180317.GB5178@kernel.dk> (raw)
In-Reply-To: <1238763938-7076-4-git-send-email-Geert.Uytterhoeven@sonycom.com>

On Fri, Apr 03 2009, Geert Uytterhoeven wrote:
> Remove the mutex serializing access to the cache.
> Instead, queue up new requests on a list if the driver is busy.
> 
> This improves sequential write performance by ca. 2%.

Great, precisely the method I wanted to see there! I've added your three
patches, thanks Geert.


-- 
Jens Axboe

WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <jens.axboe@oracle.com>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	cbe-oss-dev@ozlabs.org
Subject: Re: [PATCH] ps3vram: Replace mutex by spinlock + list
Date: Fri, 3 Apr 2009 20:03:17 +0200	[thread overview]
Message-ID: <20090403180317.GB5178@kernel.dk> (raw)
In-Reply-To: <1238763938-7076-4-git-send-email-Geert.Uytterhoeven@sonycom.com>

On Fri, Apr 03 2009, Geert Uytterhoeven wrote:
> Remove the mutex serializing access to the cache.
> Instead, queue up new requests on a list if the driver is busy.
> 
> This improves sequential write performance by ca. 2%.

Great, precisely the method I wanted to see there! I've added your three
patches, thanks Geert.


-- 
Jens Axboe


  reply	other threads:[~2009-04-03 18:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-03 13:05 [PATCH] ps3vram: Fix error path (return -EIO) for short read/write Geert Uytterhoeven
2009-04-03 13:05 ` Geert Uytterhoeven
2009-04-03 13:05 ` [PATCH] ps3vram: Use proc_create_data() instead of proc_create() Geert Uytterhoeven
2009-04-03 13:05   ` Geert Uytterhoeven
2009-04-03 13:05   ` [PATCH] ps3vram: Correct exchanged gotos in ps3vram_probe() error path Geert Uytterhoeven
2009-04-03 13:05     ` Geert Uytterhoeven
2009-04-03 13:05     ` [PATCH] ps3vram: Replace mutex by spinlock + list Geert Uytterhoeven
2009-04-03 13:05       ` Geert Uytterhoeven
2009-04-03 18:03       ` Jens Axboe [this message]
2009-04-03 18:03         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090403180317.GB5178@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=cbe-oss-dev@ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.