* [PATCH] Fix build error if CONFIG_CEVT_R4K was not defined
@ 2009-04-06 15:04 Atsushi Nemoto
2009-04-06 15:09 ` Kevin D. Kissell
2009-04-06 15:12 ` Ralf Baechle
0 siblings, 2 replies; 4+ messages in thread
From: Atsushi Nemoto @ 2009-04-06 15:04 UTC (permalink / raw)
To: linux-mips; +Cc: ralf, Kevin D. Kissell
This patch fixes build error introduced by "MIPS: SMTC:
Fix xxx_clockevent_init() naming conflict for SMT".
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
arch/mips/include/asm/time.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/mips/include/asm/time.h b/arch/mips/include/asm/time.h
index e46f23f..df6a430 100644
--- a/arch/mips/include/asm/time.h
+++ b/arch/mips/include/asm/time.h
@@ -61,7 +61,7 @@ static inline int mips_clockevent_init(void)
extern int smtc_clockevent_init(void);
return smtc_clockevent_init();
-#elif CONFIG_CEVT_R4K
+#elif defined(CONFIG_CEVT_R4K)
return r4k_clockevent_init();
#else
return -ENXIO;
--
1.5.6.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix build error if CONFIG_CEVT_R4K was not defined
2009-04-06 15:04 [PATCH] Fix build error if CONFIG_CEVT_R4K was not defined Atsushi Nemoto
@ 2009-04-06 15:09 ` Kevin D. Kissell
2009-04-06 15:14 ` Ralf Baechle
2009-04-06 15:12 ` Ralf Baechle
1 sibling, 1 reply; 4+ messages in thread
From: Kevin D. Kissell @ 2009-04-06 15:09 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: linux-mips, ralf
Drat, and I was *sure* that I'd tested that in a non-SMTC
configuration! Thanks!
Kevin K.
Atsushi Nemoto wrote:
> This patch fixes build error introduced by "MIPS: SMTC:
> Fix xxx_clockevent_init() naming conflict for SMT".
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> ---
> arch/mips/include/asm/time.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/mips/include/asm/time.h b/arch/mips/include/asm/time.h
> index e46f23f..df6a430 100644
> --- a/arch/mips/include/asm/time.h
> +++ b/arch/mips/include/asm/time.h
> @@ -61,7 +61,7 @@ static inline int mips_clockevent_init(void)
> extern int smtc_clockevent_init(void);
>
> return smtc_clockevent_init();
> -#elif CONFIG_CEVT_R4K
> +#elif defined(CONFIG_CEVT_R4K)
> return r4k_clockevent_init();
> #else
> return -ENXIO;
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Fix build error if CONFIG_CEVT_R4K was not defined
2009-04-06 15:09 ` Kevin D. Kissell
@ 2009-04-06 15:14 ` Ralf Baechle
0 siblings, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2009-04-06 15:14 UTC (permalink / raw)
To: Kevin D. Kissell; +Cc: Atsushi Nemoto, linux-mips
On Mon, Apr 06, 2009 at 05:09:36PM +0200, Kevin D. Kissell wrote:
> Drat, and I was *sure* that I'd tested that in a non-SMTC
> configuration! Thanks!
I ran into it when upgrading the IP35 port to master. At least IP27 would
should have been affected by the issue as well. It's may be possible that
you missed the issue due to an ancient compiler.
Ralf
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix build error if CONFIG_CEVT_R4K was not defined
2009-04-06 15:04 [PATCH] Fix build error if CONFIG_CEVT_R4K was not defined Atsushi Nemoto
2009-04-06 15:09 ` Kevin D. Kissell
@ 2009-04-06 15:12 ` Ralf Baechle
1 sibling, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2009-04-06 15:12 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: linux-mips, Kevin D. Kissell
On Tue, Apr 07, 2009 at 12:04:55AM +0900, Atsushi Nemoto wrote:
> This patch fixes build error introduced by "MIPS: SMTC:
> Fix xxx_clockevent_init() naming conflict for SMT".
I've already commited an identical patch last night.
Luckily modern gcc throws an error for this sort of issue; in the past it
used to be subtle breakage ...
Ralf
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-04-06 15:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-06 15:04 [PATCH] Fix build error if CONFIG_CEVT_R4K was not defined Atsushi Nemoto
2009-04-06 15:09 ` Kevin D. Kissell
2009-04-06 15:14 ` Ralf Baechle
2009-04-06 15:12 ` Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.