From: Wu Fengguang <fengguang.wu@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ying Han <yinghan@google.com>,
LKML <linux-kernel@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>, <linux-mm@kvack.org>,
Wu Fengguang <fengguang.wu@intel.com>
Subject: [PATCH 08/14] readahead: remove one unnecessary radix tree lookup
Date: Tue, 07 Apr 2009 15:17:37 +0800 [thread overview]
Message-ID: <20090407072133.639831916@intel.com> (raw)
In-Reply-To: 20090407071729.233579162@intel.com
[-- Attachment #1: readahead-interleaved-offset.patch --]
[-- Type: text/plain, Size: 884 bytes --]
(hit_readahead_marker != 0) means the page at @offset is present,
so we can search for non-present page starting from @offset+1.
Reported-by: Xu Chenfeng <xcf@ustc.edu.cn>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
mm/readahead.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- mm.orig/mm/readahead.c
+++ mm/mm/readahead.c
@@ -420,7 +420,7 @@ ondemand_readahead(struct address_space
pgoff_t start;
rcu_read_lock();
- start = radix_tree_next_hole(&mapping->page_tree, offset,max+1);
+ start = radix_tree_next_hole(&mapping->page_tree, offset+1,max);
rcu_read_unlock();
if (!start || start - offset > max)
--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Wu Fengguang <fengguang.wu@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ying Han <yinghan@google.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
Wu Fengguang <fengguang.wu@intel.com>
Subject: [PATCH 08/14] readahead: remove one unnecessary radix tree lookup
Date: Tue, 07 Apr 2009 15:17:37 +0800 [thread overview]
Message-ID: <20090407072133.639831916@intel.com> (raw)
In-Reply-To: 20090407071729.233579162@intel.com
[-- Attachment #1: readahead-interleaved-offset.patch --]
[-- Type: text/plain, Size: 884 bytes --]
(hit_readahead_marker != 0) means the page at @offset is present,
so we can search for non-present page starting from @offset+1.
Reported-by: Xu Chenfeng <xcf@ustc.edu.cn>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
mm/readahead.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- mm.orig/mm/readahead.c
+++ mm/mm/readahead.c
@@ -420,7 +420,7 @@ ondemand_readahead(struct address_space
pgoff_t start;
rcu_read_lock();
- start = radix_tree_next_hole(&mapping->page_tree, offset,max+1);
+ start = radix_tree_next_hole(&mapping->page_tree, offset+1,max);
rcu_read_unlock();
if (!start || start - offset > max)
--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-04-07 7:17 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 7:17 [PATCH 00/14] filemap and readahead fixes Wu Fengguang
2009-04-07 7:17 ` Wu Fengguang
2009-04-07 7:17 ` [PATCH 01/14] mm: fix find_lock_page_retry() return value parsing Wu Fengguang
2009-04-07 7:17 ` Wu Fengguang
2009-04-07 7:17 ` [PATCH 02/14] mm: fix major/minor fault accounting on retried fault Wu Fengguang
2009-04-07 7:17 ` Wu Fengguang
2009-04-07 19:58 ` Ying Han
2009-04-07 19:58 ` Ying Han
2009-04-07 19:58 ` Ying Han
2009-04-07 22:45 ` Wu Fengguang
2009-04-07 22:45 ` Wu Fengguang
2009-04-07 7:17 ` [PATCH 03/14] mm: remove FAULT_FLAG_RETRY dead code Wu Fengguang
2009-04-07 7:17 ` Wu Fengguang
2009-04-07 20:03 ` Ying Han
2009-04-07 20:03 ` Ying Han
2009-04-07 23:27 ` Wu Fengguang
2009-04-07 23:27 ` Wu Fengguang
2009-04-08 1:17 ` Ying Han
2009-04-08 1:17 ` Ying Han
2009-04-08 2:29 ` Wu Fengguang
2009-04-08 2:29 ` Wu Fengguang
2009-04-07 7:17 ` [PATCH 04/14] mm: reduce duplicate page fault code Wu Fengguang
2009-04-07 7:17 ` Wu Fengguang
2009-04-07 7:17 ` [PATCH 05/14] readahead: account mmap_miss for VM_FAULT_RETRY Wu Fengguang
2009-04-07 7:17 ` Wu Fengguang
2009-04-07 7:17 ` [PATCH 06/14] readahead: move max_sane_readahead() calls into force_page_cache_readahead() Wu Fengguang
2009-04-07 7:17 ` Wu Fengguang
2009-04-07 7:17 ` [PATCH 07/14] readahead: apply max_sane_readahead() limit in ondemand_readahead() Wu Fengguang
2009-04-07 7:17 ` Wu Fengguang
2009-04-07 7:17 ` Wu Fengguang [this message]
2009-04-07 7:17 ` [PATCH 08/14] readahead: remove one unnecessary radix tree lookup Wu Fengguang
2009-04-07 7:17 ` [PATCH 09/14] readahead: increase interleaved readahead size Wu Fengguang
2009-04-07 7:17 ` Wu Fengguang
2009-04-07 7:17 ` [PATCH 10/14] readahead: remove sync/async readahead call dependency Wu Fengguang
2009-04-07 7:17 ` Wu Fengguang
2009-04-07 7:17 ` [PATCH 11/14] readahead: clean up and simplify the code for filemap page fault readahead Wu Fengguang
2009-04-07 7:17 ` Wu Fengguang
2009-04-07 7:17 ` [PATCH 12/14] readahead: sequential mmap readahead Wu Fengguang
2009-04-07 7:17 ` Wu Fengguang
2009-04-07 7:17 ` [PATCH 13/14] readahead: enforce full readahead size on async " Wu Fengguang
2009-04-07 7:17 ` Wu Fengguang
2009-04-07 7:17 ` [PATCH 14/14] readahead: record mmap read-around states in file_ra_state Wu Fengguang
2009-04-07 7:17 ` Wu Fengguang
-- strict thread matches above, loose matches on Subject: below --
2009-04-07 11:50 [PATCH 00/14] filemap and readahead fixes Wu Fengguang
2009-04-07 11:50 ` [PATCH 08/14] readahead: remove one unnecessary radix tree lookup Wu Fengguang
2009-04-07 11:50 ` Wu Fengguang
2009-04-07 11:50 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090407072133.639831916@intel.com \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.