All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: ext Mark Brown <broonie@sirena.org.uk>
Cc: "sakoman@gmail.com" <sakoman@gmail.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"Nikula Jarkko (Nokia-D/Helsinki)" <jarkko.nikula@nokia.com>
Subject: Re: [PATCH 6/6] ASoC: Beagle: Add support for 4 channel mode
Date: Tue, 7 Apr 2009 07:45:31 +0300	[thread overview]
Message-ID: <200904070745.31538.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <20090406125028.GB14169@sirena.org.uk>

On Monday 06 April 2009 15:50:29 ext Mark Brown wrote:
> On Mon, Apr 06, 2009 at 03:19:32PM +0300, Peter Ujfalusi wrote:
> > +	switch (params_channels(params)) {
> > +	case 2: /* Stereo I2S mode */
> > +		fmt =	SND_SOC_DAIFMT_I2S |
> > +			SND_SOC_DAIFMT_NB_NF |
> > +			SND_SOC_DAIFMT_CBM_CFM;
> > +		break;
> > +	case 4: /* Four channel TDM mode */
> > +		fmt =	SND_SOC_DAIFMT_DSP_A |
>
> Might it not be easier to just run in DSP mode all the time?

The reason for this is the fact that twl4030 in TDM mode only supports 4. 
channel.

The Audio interface has three modes:
codec mode (i2s) - Stereo
Left-justified   - Stereo
Right-justified  - Stereo
TDM              - 4 channels

-- 
Péter

  reply	other threads:[~2009-04-07  4:45 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-06 12:19 [PATCH 0/6] ASoC: 4 channel support for twl4030 and omap-mcbsp Peter Ujfalusi
2009-04-06 12:19 ` [PATCH 1/6] ASoC: OMAP mcbsp: Add DSP_A support Peter Ujfalusi
2009-04-06 12:19   ` [PATCH 2/6] ASoC: OMAP mcbsp: Add 4 channel support Peter Ujfalusi
2009-04-06 12:19     ` [PATCH 3/6] ASoC: TWL4030: Enable all audio paths Peter Ujfalusi
2009-04-06 12:19       ` [PATCH 4/6] ASoC: TWL4030: Add 4 channel TDM support Peter Ujfalusi
2009-04-06 12:19         ` [PATCH 5/6] ASoC: TWL4030: Add constraints for 4 channel mode Peter Ujfalusi
2009-04-06 12:19           ` [PATCH 6/6] ASoC: Beagle: Add support " Peter Ujfalusi
2009-04-06 12:50             ` Mark Brown
2009-04-07  4:45               ` Peter Ujfalusi [this message]
2009-04-06 12:45       ` [PATCH 3/6] ASoC: TWL4030: Enable all audio paths Mark Brown
2009-04-07  4:59         ` Peter Ujfalusi
2009-04-07  9:45           ` Mark Brown
2009-04-07 10:30             ` Peter Ujfalusi
2009-04-07 21:02               ` Mark Brown
2009-04-06 12:22   ` [PATCH 1/6] ASoC: OMAP mcbsp: Add DSP_A support Mark Brown
2009-04-06 12:37     ` Peter Ujfalusi
2009-04-07  5:19       ` Peter Ujfalusi
2009-04-07 22:14         ` Mark Brown
2009-04-08  6:01           ` Peter Ujfalusi
2009-04-08  9:30             ` Mark Brown
2009-04-08  6:08           ` Jarkko Nikula
2009-04-08  9:28             ` Mark Brown
2009-04-07  5:45 ` [PATCH 0/6] ASoC: 4 channel support for twl4030 and omap-mcbsp Jarkko Nikula
2009-04-07  6:32   ` Peter Ujfalusi
2009-04-08  6:23 ` Jarkko Nikula
2009-04-08  9:53   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200904070745.31538.peter.ujfalusi@nokia.com \
    --to=peter.ujfalusi@nokia.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@sirena.org.uk \
    --cc=jarkko.nikula@nokia.com \
    --cc=sakoman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.