All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@sirena.org.uk>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: "sakoman@gmail.com" <sakoman@gmail.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"Nikula Jarkko (Nokia-D/Helsinki)" <jarkko.nikula@nokia.com>
Subject: Re: [PATCH 3/6] ASoC: TWL4030: Enable all audio paths
Date: Tue, 7 Apr 2009 10:45:59 +0100	[thread overview]
Message-ID: <20090407094558.GA24788@sirena.org.uk> (raw)
In-Reply-To: <200904070759.19600.peter.ujfalusi@nokia.com>

On Tue, Apr 07, 2009 at 07:59:19AM +0300, Peter Ujfalusi wrote:
> On Monday 06 April 2009 15:45:21 ext Mark Brown wrote:

> > What does this mean by "enable" - I'm guessing it's powering blocks
> > within the CODEC rather than connecting any audio paths?

> The TRM calls these as Audio/Voice digital filters.
> In effect, they enable the shifting out bits from the Capture path to the bus 
> and shifting in bits on the Playback side.

Hrm, so this is a routing thing then - from your description I'm a bit
surprised that this can be turned on unconditionally since it sounds
like it'll give you a sidetone all the time which might not be what
people want.

> But as I said, this is not so nice thing to do, so it need to be revisited.

It needs digital routing.  In the interim another option would be to
provide switches to user space, possibly?

  reply	other threads:[~2009-04-07  9:46 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-06 12:19 [PATCH 0/6] ASoC: 4 channel support for twl4030 and omap-mcbsp Peter Ujfalusi
2009-04-06 12:19 ` [PATCH 1/6] ASoC: OMAP mcbsp: Add DSP_A support Peter Ujfalusi
2009-04-06 12:19   ` [PATCH 2/6] ASoC: OMAP mcbsp: Add 4 channel support Peter Ujfalusi
2009-04-06 12:19     ` [PATCH 3/6] ASoC: TWL4030: Enable all audio paths Peter Ujfalusi
2009-04-06 12:19       ` [PATCH 4/6] ASoC: TWL4030: Add 4 channel TDM support Peter Ujfalusi
2009-04-06 12:19         ` [PATCH 5/6] ASoC: TWL4030: Add constraints for 4 channel mode Peter Ujfalusi
2009-04-06 12:19           ` [PATCH 6/6] ASoC: Beagle: Add support " Peter Ujfalusi
2009-04-06 12:50             ` Mark Brown
2009-04-07  4:45               ` Peter Ujfalusi
2009-04-06 12:45       ` [PATCH 3/6] ASoC: TWL4030: Enable all audio paths Mark Brown
2009-04-07  4:59         ` Peter Ujfalusi
2009-04-07  9:45           ` Mark Brown [this message]
2009-04-07 10:30             ` Peter Ujfalusi
2009-04-07 21:02               ` Mark Brown
2009-04-06 12:22   ` [PATCH 1/6] ASoC: OMAP mcbsp: Add DSP_A support Mark Brown
2009-04-06 12:37     ` Peter Ujfalusi
2009-04-07  5:19       ` Peter Ujfalusi
2009-04-07 22:14         ` Mark Brown
2009-04-08  6:01           ` Peter Ujfalusi
2009-04-08  9:30             ` Mark Brown
2009-04-08  6:08           ` Jarkko Nikula
2009-04-08  9:28             ` Mark Brown
2009-04-07  5:45 ` [PATCH 0/6] ASoC: 4 channel support for twl4030 and omap-mcbsp Jarkko Nikula
2009-04-07  6:32   ` Peter Ujfalusi
2009-04-08  6:23 ` Jarkko Nikula
2009-04-08  9:53   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090407094558.GA24788@sirena.org.uk \
    --to=broonie@sirena.org.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=jarkko.nikula@nokia.com \
    --cc=peter.ujfalusi@nokia.com \
    --cc=sakoman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.