* stat for FreeBSD
@ 2008-12-09 23:26 Andrey Shuvikov
2008-12-14 1:12 ` Robert Millan
0 siblings, 1 reply; 12+ messages in thread
From: Andrey Shuvikov @ 2008-12-09 23:26 UTC (permalink / raw)
To: grub-devel
Hello,
I tried to compile Grub2 under FreeBSD, it compiles but doesn't work (grub-setup). The problem seems to be in the stat() call, which is used to determine disk size. The call returns 0 for st_size, and grub-setup complains for "Read out of range". Is it a known issue? Is there a way to use Grub2 under FreeBSD?
Thank you,
Andrey
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: stat for FreeBSD
2008-12-09 23:26 Andrey Shuvikov
@ 2008-12-14 1:12 ` Robert Millan
2008-12-14 14:26 ` Javier Martín
2008-12-15 17:24 ` Andrey Shuvikov
0 siblings, 2 replies; 12+ messages in thread
From: Robert Millan @ 2008-12-14 1:12 UTC (permalink / raw)
To: The development of GRUB 2
On Tue, Dec 09, 2008 at 03:26:28PM -0800, Andrey Shuvikov wrote:
> Hello,
>
> I tried to compile Grub2 under FreeBSD, it compiles but doesn't work (grub-setup). The problem seems to be in the stat() call, which is used to determine disk size. The call returns 0 for st_size, and grub-setup complains for "Read out of range". Is it a known issue? Is there a way to use Grub2 under FreeBSD?
Do you know how to obtain the disk size on FreeBSD ?
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: stat for FreeBSD
2008-12-14 1:12 ` Robert Millan
@ 2008-12-14 14:26 ` Javier Martín
2008-12-15 17:24 ` Andrey Shuvikov
1 sibling, 0 replies; 12+ messages in thread
From: Javier Martín @ 2008-12-14 14:26 UTC (permalink / raw)
To: The development of GRUB 2
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
El dom, 14-12-2008 a las 02:12 +0100, Robert Millan escribió:
> On Tue, Dec 09, 2008 at 03:26:28PM -0800, Andrey Shuvikov wrote:
> > Hello,
> >
> > I tried to compile Grub2 under FreeBSD, it compiles but doesn't work (grub-setup). The problem seems to be in the stat() call, which is used to determine disk size. The call returns 0 for st_size, and grub-setup complains for "Read out of range". Is it a known issue? Is there a way to use Grub2 under FreeBSD?
>
> Do you know how to obtain the disk size on FreeBSD ?
>
IF parted works on FreeBSD, we could look at what it does, since it's a
GNU project, copyrights assigned to the FSF and all that (isn't it?)
[-- Attachment #2: Esta parte del mensaje está firmada digitalmente --]
[-- Type: application/pgp-signature, Size: 827 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: stat for FreeBSD
2008-12-14 1:12 ` Robert Millan
2008-12-14 14:26 ` Javier Martín
@ 2008-12-15 17:24 ` Andrey Shuvikov
2009-02-07 19:39 ` Robert Millan
1 sibling, 1 reply; 12+ messages in thread
From: Andrey Shuvikov @ 2008-12-15 17:24 UTC (permalink / raw)
To: The development of GRUB 2
[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]
I don't have much experience developing under FreeBSD but this call taken from the fdisk source code seems to work (see attachment also):
error = ioctl(fd, DIOCGMEDIASIZE, &size);
Thanks,
Andrey
--- On Sat, 12/13/08, Robert Millan <rmh@aybabtu.com> wrote:
> From: Robert Millan <rmh@aybabtu.com>
> Subject: Re: stat for FreeBSD
> To: "The development of GRUB 2" <grub-devel@gnu.org>
> Date: Saturday, December 13, 2008, 8:12 PM
> On Tue, Dec 09, 2008 at 03:26:28PM -0800, Andrey Shuvikov
> wrote:
> > Hello,
> >
> > I tried to compile Grub2 under FreeBSD, it compiles
> but doesn't work (grub-setup). The problem seems to be
> in the stat() call, which is used to determine disk size.
> The call returns 0 for st_size, and grub-setup complains for
> "Read out of range". Is it a known issue? Is there
> a way to use Grub2 under FreeBSD?
>
> Do you know how to obtain the disk size on FreeBSD ?
>
> --
> Robert Millan
>
> The DRM opt-in fallacy: "Your data belongs to us. We
> will decide when (and
> how) you may access your data; but nobody's
> threatening your freedom: we
> still allow you to remove your data and not access it at
> all."
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
[-- Attachment #2: getsize.c --]
[-- Type: application/octet-stream, Size: 526 bytes --]
#include <fcntl.h>
#include <stdio.h>
#include <sys/ioctl.h>
#include <sys/disk.h>
int main(int argc, char * argv[]) {
off_t size;
int error;
int fd;
if (argc != 2) {
printf("Usage: getsize <device>\n");
return 1;
}
fd = open(argv[1], O_RDONLY);
if (fd == -1) {
perror("open");
return -1;
}
error = ioctl(fd, DIOCGMEDIASIZE, &size);
if (error == -1) {
perror("ioctl");
} else {
printf("Size: %lld\n", size);
}
close(fd);
return 0;
}
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: stat for FreeBSD
2008-12-15 17:24 ` Andrey Shuvikov
@ 2009-02-07 19:39 ` Robert Millan
2009-03-12 16:24 ` Andrey Shuvikov
0 siblings, 1 reply; 12+ messages in thread
From: Robert Millan @ 2009-02-07 19:39 UTC (permalink / raw)
To: The development of GRUB 2
On Mon, Dec 15, 2008 at 09:24:41AM -0800, Andrey Shuvikov wrote:
> I don't have much experience developing under FreeBSD but this call taken from the fdisk source code seems to work (see attachment also):
>
> error = ioctl(fd, DIOCGMEDIASIZE, &size);
This seems fine. Could you provide a tested patch?
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: stat for FreeBSD
2009-02-07 19:39 ` Robert Millan
@ 2009-03-12 16:24 ` Andrey Shuvikov
0 siblings, 0 replies; 12+ messages in thread
From: Andrey Shuvikov @ 2009-03-12 16:24 UTC (permalink / raw)
To: The development of GRUB 2
[-- Attachment #1: Type: text/plain, Size: 1198 bytes --]
--- On Sat, 2/7/09, Robert Millan <rmh@aybabtu.com> wrote:
> From: Robert Millan <rmh@aybabtu.com>
> Subject: Re: stat for FreeBSD
> To: "The development of GRUB 2" <grub-devel@gnu.org>
> Date: Saturday, February 7, 2009, 2:39 PM
> On Mon, Dec 15, 2008 at 09:24:41AM -0800, Andrey Shuvikov
> wrote:
> > I don't have much experience developing under
> FreeBSD but this call taken from the fdisk source code seems
> to work (see attachment also):
> >
> > error = ioctl(fd, DIOCGMEDIASIZE, &size);
>
> This seems fine. Could you provide a tested patch?
>
> --
> Robert Millan
>
> The DRM opt-in fallacy: "Your data belongs to us. We
> will decide when (and
> how) you may access your data; but nobody's
> threatening your freedom: we
> still allow you to remove your data and not access it at
> all."
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
Here is the patch to make grub-probe working on FreeBSD. It includes this
ioctl call, FreeBSD device names parsing, and accounts for the fact that disk drives are character devices under FreeBSD.
Regards,
Andrey Shuvikov
[-- Attachment #2: grub_probe_freebsd.patch --]
[-- Type: application/octet-stream, Size: 4778 bytes --]
Index: include/grub/util/getroot.h
===================================================================
--- include/grub/util/getroot.h (revision 2028)
+++ include/grub/util/getroot.h (working copy)
@@ -30,5 +30,6 @@
int grub_util_get_dev_abstraction (const char *os_dev);
char *grub_util_get_grub_dev (const char *os_dev);
const char *grub_util_check_block_device (const char *blk_dev);
+const char *grub_util_check_char_device (const char *blk_dev);
#endif /* ! GRUB_UTIL_GETROOT_HEADER */
Index: util/grub-probe.c
===================================================================
--- util/grub-probe.c (revision 2028)
+++ util/grub-probe.c (working copy)
@@ -112,8 +112,13 @@
if (path == NULL)
{
+#if defined(__FreeBSD__)
+ if (! grub_util_check_char_device (device_name))
+ grub_util_error ("%s is not a character device.\n", device_name);
+#else
if (! grub_util_check_block_device (device_name))
grub_util_error ("%s is not a block device.\n", device_name);
+#endif
}
else
device_name = grub_guess_root_device (path);
Index: util/getroot.c
===================================================================
--- util/getroot.c (revision 2028)
+++ util/getroot.c (working copy)
@@ -238,7 +238,11 @@
}
}
+#ifdef __FreeBSD__
+ if (S_ISCHR (st.st_mode) && st.st_rdev == dev)
+#else
if (S_ISBLK (st.st_mode) && st.st_rdev == dev)
+#endif
{
#ifdef __linux__
/* Skip device names like /dev/dm-0, which are short-hand aliases
@@ -519,3 +523,18 @@
else
return 0;
}
+
+const char *
+grub_util_check_char_device (const char *blk_dev)
+{
+ struct stat st;
+
+ if (stat (blk_dev, &st) < 0)
+ grub_util_error ("Cannot stat `%s'", blk_dev);
+
+ if (S_ISCHR (st.st_mode))
+ return (blk_dev);
+ else
+ return 0;
+}
+
Index: util/hostdisk.c
===================================================================
--- util/hostdisk.c (revision 2028)
+++ util/hostdisk.c (working copy)
@@ -86,6 +86,10 @@
# define FLOPPY_MAJOR 2
#endif
+#ifdef __FreeBSD__
+# include <sys/disk.h> /* DIOCGMEDIASIZE */
+#endif
+
struct
{
char *drive;
@@ -179,7 +183,7 @@
return GRUB_ERR_NONE;
}
-#elif defined(__linux__) || defined(__CYGWIN__)
+#elif defined(__linux__) || defined(__CYGWIN__) || defined(__FreeBSD__)
{
unsigned long long nr;
int fd;
@@ -188,13 +192,21 @@
if (fd == -1)
return grub_error (GRUB_ERR_BAD_DEVICE, "cannot open `%s' while attempting to get disk size", map[drive].device);
+#if defined(__FreeBSD__)
+ if (fstat (fd, &st) < 0 || ! S_ISCHR (st.st_mode))
+#else
if (fstat (fd, &st) < 0 || ! S_ISBLK (st.st_mode))
+#endif
{
close (fd);
goto fail;
}
+#if defined(__FreeBSD__)
+ if (ioctl (fd, DIOCGMEDIASIZE, &nr))
+#else
if (ioctl (fd, BLKGETSIZE64, &nr))
+#endif
{
close (fd);
goto fail;
@@ -741,6 +753,22 @@
path[8] = 0;
return path;
+#elif defined(__FreeBSD__)
+ char *path = xstrdup (os_dev);
+ if (strncmp ("/dev/", path, 5) == 0)
+ {
+ char *p;
+ for (p = path + 5; *p; ++p)
+ if (grub_isdigit(*p))
+ {
+ p = strchr (p, 's');
+ if (p)
+ *p = '\0';
+ break;
+ }
+ }
+ return path;
+
#else
# warning "The function `convert_system_partition_to_system_disk' might not work on your OS correctly."
return xstrdup (os_dev);
@@ -788,7 +816,11 @@
return 0;
}
+#if defined(__FreeBSD__)
+ if (! S_ISCHR (st.st_mode))
+#else
if (! S_ISBLK (st.st_mode))
+#endif
return make_device_name (drive, -1, -1);
#if defined(__linux__) || defined(__CYGWIN__)
@@ -933,6 +965,40 @@
return make_device_name (drive, dos_part, bsd_part);
}
+#elif defined(__FreeBSD__)
+ /* FreeBSD uses "/dev/[a-z]+[0-9]+(s[0-9]+[a-z]?)?". */
+ {
+ int dos_part = -1;
+ int bsd_part = -1;
+
+ if (strncmp ("/dev/", os_dev, 5) == 0)
+ {
+ char *p, *q;
+ long int n;
+
+ for (p = os_dev + 5; *p; ++p)
+ if (grub_isdigit(*p))
+ {
+ p = strchr (p, 's');
+ if (p)
+ {
+ p++;
+ n = strtol (p, &q, 10);
+ if (p != q && n != LONG_MIN && n != LONG_MAX)
+ {
+ dos_part = (int) n - 1;
+
+ if (*q >= 'a' && *q <= 'g')
+ bsd_part = *q - 'a';
+ }
+ }
+ break;
+ }
+ }
+
+ return make_device_name (drive, dos_part, bsd_part);
+ }
+
#else
# warning "The function `grub_util_biosdisk_get_grub_dev' might not work on your OS correctly."
return make_device_name (drive, -1, -1);
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: stat for FreeBSD
@ 2009-04-06 15:48 Andrey Shuvikov
2009-04-07 0:35 ` Yoshinori K. Okuji
0 siblings, 1 reply; 12+ messages in thread
From: Andrey Shuvikov @ 2009-04-06 15:48 UTC (permalink / raw)
To: The development of GRUB 2
[-- Attachment #1: Type: text/plain, Size: 2483 bytes --]
--- On Sat, 2/7/09, Robert Millan <rmh@aybabtu.com> wrote:
> From: Robert Millan <rmh@aybabtu.com>
> Subject: Re: stat for FreeBSD
> To: "The development of GRUB 2" <grub-devel@gnu.org>
> Date: Saturday, February 7, 2009, 2:39 PM
> On Mon, Dec 15, 2008 at 09:24:41AM
> -0800, Andrey Shuvikov wrote:
> > I don't have much experience developing under FreeBSD
> but this call taken from the fdisk source code seems to work
> (see attachment also):
> >
> > error = ioctl(fd, DIOCGMEDIASIZE, &size);
>
> This seems fine. Could you provide a tested patch?
>
> --
> Robert Millan
>
> The DRM opt-in fallacy: "Your data belongs to us. We
> will decide when (and
> how) you may access your data; but nobody's
> threatening your freedom: we
> still allow you to remove your data and not access
> it at all."
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
Here is the patch against the latest revision to make grub-probe working on FreeBSD. It includes this ioctl call, FreeBSD device names parsing, and accounts for the fact that disk drives are character devices under FreeBSD. Below is the reply from FSF:
======================================================================
Hello Andrey,
Your GRUB2 assignment/disclaimer process with the FSF is currently
complete; your fully executed PDF will be sent to you in a separate
email immediately following this one.
Please remember to let us know when your employment status changes, as
this may effect your assignment status.
Thank you for your contribution!
All the best,
Donald R. Robertson, III, J.D.
Assignment Administrator
Free Software Foundation
51 Franklin Street, Fifth Floor
Boston, MA 02110
Phone +1-617-542-5942
Fax +1-617-542-2652
cc - maintainer
_______________________________________________________________________
INFORMATION FOR THE MAINTAINER(S)
Here's how the contributor answered the question, “ Did you copy any
files or text written by someone else in these changes?”
Copied some lines from the same project, then modified.
[Which files have you changed so far, and which new files have you written
so far?]
include/grub/util/getroot.h
util/grub-probe.c
util/getroot.c
util/hostdisk.c
======================================================================
Regards,
Andrey Shuvikov
[-- Attachment #2: grub_probe_freebsd.patch --]
[-- Type: application/octet-stream, Size: 4775 bytes --]
Index: include/grub/util/getroot.h
===================================================================
--- include/grub/util/getroot.h (revision 2068)
+++ include/grub/util/getroot.h (working copy)
@@ -30,5 +30,6 @@
int grub_util_get_dev_abstraction (const char *os_dev);
char *grub_util_get_grub_dev (const char *os_dev);
const char *grub_util_check_block_device (const char *blk_dev);
+const char *grub_util_check_char_device (const char *blk_dev);
#endif /* ! GRUB_UTIL_GETROOT_HEADER */
Index: util/grub-probe.c
===================================================================
--- util/grub-probe.c (revision 2068)
+++ util/grub-probe.c (working copy)
@@ -112,8 +112,13 @@
if (path == NULL)
{
+#if defined(__FreeBSD__)
+ if (! grub_util_check_char_device (device_name))
+ grub_util_error ("%s is not a character device.\n", device_name);
+#else
if (! grub_util_check_block_device (device_name))
grub_util_error ("%s is not a block device.\n", device_name);
+#endif
}
else
device_name = grub_guess_root_device (path);
Index: util/getroot.c
===================================================================
--- util/getroot.c (revision 2068)
+++ util/getroot.c (working copy)
@@ -238,7 +238,11 @@
}
}
+#ifdef __FreeBSD__
+ if (S_ISCHR (st.st_mode) && st.st_rdev == dev)
+#else
if (S_ISBLK (st.st_mode) && st.st_rdev == dev)
+#endif
{
#ifdef __linux__
/* Skip device names like /dev/dm-0, which are short-hand aliases
@@ -519,3 +523,18 @@
else
return 0;
}
+
+const char *
+grub_util_check_char_device (const char *blk_dev)
+{
+ struct stat st;
+
+ if (stat (blk_dev, &st) < 0)
+ grub_util_error ("Cannot stat `%s'", blk_dev);
+
+ if (S_ISCHR (st.st_mode))
+ return (blk_dev);
+ else
+ return 0;
+}
+
Index: util/hostdisk.c
===================================================================
--- util/hostdisk.c (revision 2068)
+++ util/hostdisk.c (working copy)
@@ -86,6 +86,10 @@
# define FLOPPY_MAJOR 2
#endif
+#ifdef __FreeBSD__
+# include <sys/disk.h> /* DIOCGMEDIASIZE */
+#endif
+
struct
{
char *drive;
@@ -179,7 +183,7 @@
return GRUB_ERR_NONE;
}
-#elif defined(__linux__) || defined(__CYGWIN__)
+#elif defined(__linux__) || defined(__CYGWIN__) || defined(__FreeBSD__)
{
unsigned long long nr;
int fd;
@@ -188,13 +192,21 @@
if (fd == -1)
return grub_error (GRUB_ERR_BAD_DEVICE, "cannot open `%s' while attempting to get disk size", map[drive].device);
+#if defined(__FreeBSD__)
+ if (fstat (fd, &st) < 0 || ! S_ISCHR (st.st_mode))
+#else
if (fstat (fd, &st) < 0 || ! S_ISBLK (st.st_mode))
+#endif
{
close (fd);
goto fail;
}
+#if defined(__FreeBSD__)
+ if (ioctl (fd, DIOCGMEDIASIZE, &nr))
+#else
if (ioctl (fd, BLKGETSIZE64, &nr))
+#endif
{
close (fd);
goto fail;
@@ -746,6 +758,22 @@
path[8] = 0;
return path;
+#elif defined(__FreeBSD__)
+ char *path = xstrdup (os_dev);
+ if (strncmp ("/dev/", path, 5) == 0)
+ {
+ char *p;
+ for (p = path + 5; *p; ++p)
+ if (grub_isdigit(*p))
+ {
+ p = strchr (p, 's');
+ if (p)
+ *p = '\0';
+ break;
+ }
+ }
+ return path;
+
#else
# warning "The function `convert_system_partition_to_system_disk' might not work on your OS correctly."
return xstrdup (os_dev);
@@ -793,7 +821,11 @@
return 0;
}
+#if defined(__FreeBSD__)
+ if (! S_ISCHR (st.st_mode))
+#else
if (! S_ISBLK (st.st_mode))
+#endif
return make_device_name (drive, -1, -1);
#if defined(__linux__) || defined(__CYGWIN__)
@@ -938,6 +970,40 @@
return make_device_name (drive, dos_part, bsd_part);
}
+#elif defined(__FreeBSD__)
+ /* FreeBSD uses "/dev/[a-z]+[0-9]+(s[0-9]+[a-z]?)?". */
+ {
+ int dos_part = -1;
+ int bsd_part = -1;
+
+ if (strncmp ("/dev/", os_dev, 5) == 0)
+ {
+ char *p, *q;
+ long int n;
+
+ for (p = os_dev + 5; *p; ++p)
+ if (grub_isdigit(*p))
+ {
+ p = strchr (p, 's');
+ if (p)
+ {
+ p++;
+ n = strtol (p, &q, 10);
+ if (p != q && n != LONG_MIN && n != LONG_MAX)
+ {
+ dos_part = (int) n - 1;
+
+ if (*q >= 'a' && *q <= 'g')
+ bsd_part = *q - 'a';
+ }
+ }
+ break;
+ }
+ }
+
+ return make_device_name (drive, dos_part, bsd_part);
+ }
+
#else
# warning "The function `grub_util_biosdisk_get_grub_dev' might not work on your OS correctly."
return make_device_name (drive, -1, -1);
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: stat for FreeBSD
2009-04-06 15:48 stat for FreeBSD Andrey Shuvikov
@ 2009-04-07 0:35 ` Yoshinori K. Okuji
0 siblings, 0 replies; 12+ messages in thread
From: Yoshinori K. Okuji @ 2009-04-07 0:35 UTC (permalink / raw)
To: The development of GRUB 2
On Tuesday 07 April 2009 00:48:37 Andrey Shuvikov wrote:
> Here is the patch against the latest revision to make grub-probe working on
> FreeBSD. It includes this ioctl call, FreeBSD device names parsing, and
> accounts for the fact that disk drives are character devices under FreeBSD.
Do you have an account on Savannah? I can have you to check it in yourself. ;)
Regards,
Okuji
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: stat for FreeBSD
@ 2009-04-08 14:32 Andrey Shuvikov
2009-04-09 23:31 ` Yoshinori K. Okuji
0 siblings, 1 reply; 12+ messages in thread
From: Andrey Shuvikov @ 2009-04-08 14:32 UTC (permalink / raw)
To: The development of GRUB 2
--- On Mon, 4/6/09, Yoshinori K. Okuji <okuji@enbug.org> wrote:
> From: Yoshinori K. Okuji <okuji@enbug.org>
> Subject: Re: stat for FreeBSD
> To: "The development of GRUB 2" <grub-devel@gnu.org>
> Date: Monday, April 6, 2009, 8:35 PM
> On Tuesday 07 April 2009 00:48:37
> Andrey Shuvikov wrote:
> > Here is the patch against the latest revision to make
> grub-probe working on
> > FreeBSD. It includes this ioctl call, FreeBSD device
> names parsing, and
> > accounts for the fact that disk drives are character
> devices under FreeBSD.
>
> Do you have an account on Savannah? I can have you to check
> it in yourself. ;)
>
> Regards,
> Okuji
>
>
No I don't have an account. I was just trying to compile Grub2 under FreeBSD. :-)
Regards,
Andrey
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: stat for FreeBSD
2009-04-08 14:32 Andrey Shuvikov
@ 2009-04-09 23:31 ` Yoshinori K. Okuji
0 siblings, 0 replies; 12+ messages in thread
From: Yoshinori K. Okuji @ 2009-04-09 23:31 UTC (permalink / raw)
To: The development of GRUB 2
On Wednesday 08 April 2009 23:32:18 Andrey Shuvikov wrote:
> --- On Mon, 4/6/09, Yoshinori K. Okuji <okuji@enbug.org> wrote:
> > From: Yoshinori K. Okuji <okuji@enbug.org>
> > Subject: Re: stat for FreeBSD
> > To: "The development of GRUB 2" <grub-devel@gnu.org>
> > Date: Monday, April 6, 2009, 8:35 PM
> > On Tuesday 07 April 2009 00:48:37
> >
> > Andrey Shuvikov wrote:
> > > Here is the patch against the latest revision to make
> >
> > grub-probe working on
> >
> > > FreeBSD. It includes this ioctl call, FreeBSD device
> >
> > names parsing, and
> >
> > > accounts for the fact that disk drives are character
> >
> > devices under FreeBSD.
> >
> > Do you have an account on Savannah? I can have you to check
> > it in yourself. ;)
> >
> > Regards,
> > Okuji
>
> No I don't have an account. I was just trying to compile Grub2 under
> FreeBSD. :-)
Ok, but if you are willing to maintain the FreeBSD port, I think it would be
convenient for you to have an account, otherwise you will have to wait for
someone else to pick up your patch and check it in instead of you all the
time. It's up to you.
Regards,
Okuji
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: stat for FreeBSD
@ 2009-04-10 3:51 Andrey Shuvikov
2009-04-10 7:34 ` Felix Zielcke
0 siblings, 1 reply; 12+ messages in thread
From: Andrey Shuvikov @ 2009-04-10 3:51 UTC (permalink / raw)
To: The development of GRUB 2
--- On Thu, 4/9/09, Yoshinori K. Okuji <okuji@enbug.org> wrote:
> From: Yoshinori K. Okuji <okuji@enbug.org>
> Subject: Re: stat for FreeBSD
> To: "The development of GRUB 2" <grub-devel@gnu.org>
> Date: Thursday, April 9, 2009, 7:31 PM
> On Wednesday 08 April 2009 23:32:18
> Andrey Shuvikov wrote:
> > --- On Mon, 4/6/09, Yoshinori K. Okuji <okuji@enbug.org>
> wrote:
> > > From: Yoshinori K. Okuji <okuji@enbug.org>
> > > Subject: Re: stat for FreeBSD
> > > To: "The development of GRUB 2" <grub-devel@gnu.org>
> > > Date: Monday, April 6, 2009, 8:35 PM
> > > On Tuesday 07 April 2009 00:48:37
> > >
> > > Andrey Shuvikov wrote:
> > > > Here is the patch against the latest
> revision to make
> > >
> > > grub-probe working on
> > >
> > > > FreeBSD. It includes this ioctl call,
> FreeBSD device
> > >
> > > names parsing, and
> > >
> > > > accounts for the fact that disk drives are
> character
> > >
> > > devices under FreeBSD.
> > >
> > > Do you have an account on Savannah? I can have
> you to check
> > > it in yourself. ;)
> > >
> > > Regards,
> > > Okuji
> >
> > No I don't have an account. I was just trying to
> compile Grub2 under
> > FreeBSD. :-)
>
> Ok, but if you are willing to maintain the FreeBSD port, I
> think it would be
> convenient for you to have an account, otherwise you will
> have to wait for
> someone else to pick up your patch and check it in instead
> of you all the
> time. It's up to you.
>
I'm an expert in neither FreeBSD nor Grub, I just wanted to dual-boot FreeBSD to play with it. :-) And frankly I don't know how much time I can devote to it. But I can try. I'm on vacation for the next two weeks anyway and if nobody picks up the patch until then I can check it in myself. What's involved in creating an account?
Thanks,
Andrey
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: stat for FreeBSD
2009-04-10 3:51 Andrey Shuvikov
@ 2009-04-10 7:34 ` Felix Zielcke
0 siblings, 0 replies; 12+ messages in thread
From: Felix Zielcke @ 2009-04-10 7:34 UTC (permalink / raw)
To: The development of GRUB 2
Am Donnerstag, den 09.04.2009, 20:51 -0700 schrieb Andrey Shuvikov:
>
> What's involved in creating an account?
Just like always only accountname + password + email address
See https://savannah.gnu.org/account/register.php
--
Felix Zielcke
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2009-04-10 7:35 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-06 15:48 stat for FreeBSD Andrey Shuvikov
2009-04-07 0:35 ` Yoshinori K. Okuji
-- strict thread matches above, loose matches on Subject: below --
2009-04-10 3:51 Andrey Shuvikov
2009-04-10 7:34 ` Felix Zielcke
2009-04-08 14:32 Andrey Shuvikov
2009-04-09 23:31 ` Yoshinori K. Okuji
2008-12-09 23:26 Andrey Shuvikov
2008-12-14 1:12 ` Robert Millan
2008-12-14 14:26 ` Javier Martín
2008-12-15 17:24 ` Andrey Shuvikov
2009-02-07 19:39 ` Robert Millan
2009-03-12 16:24 ` Andrey Shuvikov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.