All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org
Subject: [PATCH] [7/16] POISON: Add basic support for poisoned pages in fault handler
Date: Tue,  7 Apr 2009 17:10:04 +0200 (CEST)	[thread overview]
Message-ID: <20090407151004.2F5D21D0470@basil.firstfloor.org> (raw)
In-Reply-To: <20090407509.382219156@firstfloor.org>


- Add a new VM_FAULT_POISON error code to handle_mm_fault. Right now
architectures have to explicitely enable poison page support, so
this is forward compatible to all architectures. They only need
to add it when they enable poison page support.
- Add poison page handling in swap in fault code

Signed-off-by: Andi Kleen <ak@linux.intel.com>

---
 include/linux/mm.h |    3 ++-
 mm/memory.c        |   17 ++++++++++++++---
 2 files changed, 16 insertions(+), 4 deletions(-)

Index: linux/mm/memory.c
===================================================================
--- linux.orig/mm/memory.c	2009-04-07 16:39:24.000000000 +0200
+++ linux/mm/memory.c	2009-04-07 16:43:06.000000000 +0200
@@ -1315,7 +1315,8 @@
 				if (ret & VM_FAULT_ERROR) {
 					if (ret & VM_FAULT_OOM)
 						return i ? i : -ENOMEM;
-					else if (ret & VM_FAULT_SIGBUS)
+					if (ret &
+					    (VM_FAULT_POISON|VM_FAULT_SIGBUS))
 						return i ? i : -EFAULT;
 					BUG();
 				}
@@ -2426,8 +2427,15 @@
 		goto out;
 
 	entry = pte_to_swp_entry(orig_pte);
-	if (is_migration_entry(entry)) {
-		migration_entry_wait(mm, pmd, address);
+	if (unlikely(non_swap_entry(entry))) {
+		if (is_migration_entry(entry)) {
+			migration_entry_wait(mm, pmd, address);
+		} else if (is_poison_entry(entry)) {
+			ret = VM_FAULT_POISON;
+		} else {
+			print_bad_pte(vma, address, pte, NULL);
+			ret = VM_FAULT_OOM;
+		}
 		goto out;
 	}
 	delayacct_set_flag(DELAYACCT_PF_SWAPIN);
@@ -2451,6 +2459,9 @@
 		/* Had to read the page from swap area: Major fault */
 		ret = VM_FAULT_MAJOR;
 		count_vm_event(PGMAJFAULT);
+	} else if (PagePoison(page)) {
+		ret = VM_FAULT_POISON;
+		goto out;
 	}
 
 	lock_page(page);
Index: linux/include/linux/mm.h
===================================================================
--- linux.orig/include/linux/mm.h	2009-04-07 16:39:24.000000000 +0200
+++ linux/include/linux/mm.h	2009-04-07 16:43:05.000000000 +0200
@@ -702,11 +702,12 @@
 #define VM_FAULT_SIGBUS	0x0002
 #define VM_FAULT_MAJOR	0x0004
 #define VM_FAULT_WRITE	0x0008	/* Special case for get_user_pages */
+#define VM_FAULT_POISON 0x0010	/* Hit poisoned page */
 
 #define VM_FAULT_NOPAGE	0x0100	/* ->fault installed the pte, not return page */
 #define VM_FAULT_LOCKED	0x0200	/* ->fault locked the returned page */
 
-#define VM_FAULT_ERROR	(VM_FAULT_OOM | VM_FAULT_SIGBUS)
+#define VM_FAULT_ERROR	(VM_FAULT_OOM | VM_FAULT_SIGBUS | VM_FAULT_POISON)
 
 /*
  * Can be called by the pagefault handler when it gets a VM_FAULT_OOM.

WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org
Subject: [PATCH] [7/16] POISON: Add basic support for poisoned pages in fault handler
Date: Tue,  7 Apr 2009 17:10:04 +0200 (CEST)	[thread overview]
Message-ID: <20090407151004.2F5D21D0470@basil.firstfloor.org> (raw)
In-Reply-To: <20090407509.382219156@firstfloor.org>


- Add a new VM_FAULT_POISON error code to handle_mm_fault. Right now
architectures have to explicitely enable poison page support, so
this is forward compatible to all architectures. They only need
to add it when they enable poison page support.
- Add poison page handling in swap in fault code

Signed-off-by: Andi Kleen <ak@linux.intel.com>

---
 include/linux/mm.h |    3 ++-
 mm/memory.c        |   17 ++++++++++++++---
 2 files changed, 16 insertions(+), 4 deletions(-)

Index: linux/mm/memory.c
===================================================================
--- linux.orig/mm/memory.c	2009-04-07 16:39:24.000000000 +0200
+++ linux/mm/memory.c	2009-04-07 16:43:06.000000000 +0200
@@ -1315,7 +1315,8 @@
 				if (ret & VM_FAULT_ERROR) {
 					if (ret & VM_FAULT_OOM)
 						return i ? i : -ENOMEM;
-					else if (ret & VM_FAULT_SIGBUS)
+					if (ret &
+					    (VM_FAULT_POISON|VM_FAULT_SIGBUS))
 						return i ? i : -EFAULT;
 					BUG();
 				}
@@ -2426,8 +2427,15 @@
 		goto out;
 
 	entry = pte_to_swp_entry(orig_pte);
-	if (is_migration_entry(entry)) {
-		migration_entry_wait(mm, pmd, address);
+	if (unlikely(non_swap_entry(entry))) {
+		if (is_migration_entry(entry)) {
+			migration_entry_wait(mm, pmd, address);
+		} else if (is_poison_entry(entry)) {
+			ret = VM_FAULT_POISON;
+		} else {
+			print_bad_pte(vma, address, pte, NULL);
+			ret = VM_FAULT_OOM;
+		}
 		goto out;
 	}
 	delayacct_set_flag(DELAYACCT_PF_SWAPIN);
@@ -2451,6 +2459,9 @@
 		/* Had to read the page from swap area: Major fault */
 		ret = VM_FAULT_MAJOR;
 		count_vm_event(PGMAJFAULT);
+	} else if (PagePoison(page)) {
+		ret = VM_FAULT_POISON;
+		goto out;
 	}
 
 	lock_page(page);
Index: linux/include/linux/mm.h
===================================================================
--- linux.orig/include/linux/mm.h	2009-04-07 16:39:24.000000000 +0200
+++ linux/include/linux/mm.h	2009-04-07 16:43:05.000000000 +0200
@@ -702,11 +702,12 @@
 #define VM_FAULT_SIGBUS	0x0002
 #define VM_FAULT_MAJOR	0x0004
 #define VM_FAULT_WRITE	0x0008	/* Special case for get_user_pages */
+#define VM_FAULT_POISON 0x0010	/* Hit poisoned page */
 
 #define VM_FAULT_NOPAGE	0x0100	/* ->fault installed the pte, not return page */
 #define VM_FAULT_LOCKED	0x0200	/* ->fault locked the returned page */
 
-#define VM_FAULT_ERROR	(VM_FAULT_OOM | VM_FAULT_SIGBUS)
+#define VM_FAULT_ERROR	(VM_FAULT_OOM | VM_FAULT_SIGBUS | VM_FAULT_POISON)
 
 /*
  * Can be called by the pagefault handler when it gets a VM_FAULT_OOM.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2009-04-07 15:21 UTC|newest]

Thread overview: 150+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-07 15:09 [PATCH] [0/16] POISON: Intro Andi Kleen
2009-04-07 15:09 ` Andi Kleen
2009-04-07 15:09 ` [PATCH] [1/16] POISON: Add support for high priority work items Andi Kleen
2009-04-07 15:09   ` Andi Kleen
2009-04-07 15:09 ` [PATCH] [2/16] POISON: Add page flag for poisoned pages Andi Kleen
2009-04-07 15:09   ` Andi Kleen
2009-04-07 21:07   ` Christoph Lameter
2009-04-07 21:07     ` Christoph Lameter
2009-04-08  0:29   ` Russ Anderson
2009-04-08  0:29     ` Russ Anderson
2009-04-08  6:26     ` Andi Kleen
2009-04-08  6:26       ` Andi Kleen
2009-04-08  5:14   ` Andrew Morton
2009-04-08  5:14     ` Andrew Morton
2009-04-08  6:24     ` Andi Kleen
2009-04-08  6:24       ` Andi Kleen
2009-04-08  7:00       ` Andrew Morton
2009-04-08  7:00         ` Andrew Morton
2009-04-08  9:38         ` Andi Kleen
2009-04-08  9:38           ` Andi Kleen
2009-04-07 15:09 ` [PATCH] [3/16] POISON: Handle poisoned pages in page free Andi Kleen
2009-04-07 15:09   ` Andi Kleen
2009-04-07 23:21   ` Minchan Kim
2009-04-07 23:21     ` Minchan Kim
2009-04-08  6:51     ` Andi Kleen
2009-04-08  6:51       ` Andi Kleen
2009-04-08  7:39       ` Minchan Kim
2009-04-08  7:39         ` Minchan Kim
2009-04-08  9:41         ` Andi Kleen
2009-04-08  9:41           ` Andi Kleen
2009-04-08 10:05           ` Minchan Kim
2009-04-08 10:05             ` Minchan Kim
2009-04-07 15:10 ` [PATCH] [4/16] POISON: Export some rmap vma locking to outside world Andi Kleen
2009-04-07 15:10   ` Andi Kleen
2009-04-07 15:10 ` [PATCH] [5/16] POISON: Add support for poison swap entries Andi Kleen
2009-04-07 15:10   ` Andi Kleen
2009-04-07 21:11   ` Christoph Lameter
2009-04-07 21:11     ` Christoph Lameter
2009-04-07 21:56     ` Andi Kleen
2009-04-07 21:56       ` Andi Kleen
2009-04-07 21:56       ` Christoph Lameter
2009-04-07 21:56         ` Christoph Lameter
2009-04-07 22:25         ` Andi Kleen
2009-04-07 22:25           ` Andi Kleen
2009-04-07 15:10 ` [PATCH] [6/16] POISON: Add new SIGBUS error codes for poison signals Andi Kleen
2009-04-07 15:10   ` Andi Kleen
2009-04-07 15:10 ` Andi Kleen [this message]
2009-04-07 15:10   ` [PATCH] [7/16] POISON: Add basic support for poisoned pages in fault handler Andi Kleen
2009-05-26 12:55   ` Hidehiro Kawai
2009-05-26 12:55     ` Hidehiro Kawai
2009-05-26 13:18     ` Andi Kleen
2009-05-26 13:18       ` Andi Kleen
2009-04-07 15:10 ` [PATCH] [8/16] POISON: Add various poison checks in mm/memory.c Andi Kleen
2009-04-07 15:10   ` Andi Kleen
2009-04-07 19:03   ` Johannes Weiner
2009-04-07 19:03     ` Johannes Weiner
2009-04-07 19:31     ` Andi Kleen
2009-04-07 19:31       ` Andi Kleen
2009-04-07 20:17       ` Johannes Weiner
2009-04-07 20:17         ` Johannes Weiner
2009-04-07 20:24         ` Andi Kleen
2009-04-07 20:24           ` Andi Kleen
2009-04-07 20:36           ` Johannes Weiner
2009-04-07 20:36             ` Johannes Weiner
2009-04-07 15:10 ` [PATCH] [9/16] POISON: x86: Add VM_FAULT_POISON handling to x86 page fault handler Andi Kleen
2009-04-07 15:10   ` Andi Kleen
2009-04-07 15:10 ` [PATCH] [10/16] POISON: Use bitmask/action code for try_to_unmap behaviour Andi Kleen
2009-04-07 15:10   ` Andi Kleen
2009-04-07 21:19   ` Christoph Lameter
2009-04-07 21:19     ` Christoph Lameter
2009-04-07 21:59     ` Andi Kleen
2009-04-07 21:59       ` Andi Kleen
2009-04-07 22:04       ` Christoph Lameter
2009-04-07 22:04         ` Christoph Lameter
2009-04-07 22:35         ` Andi Kleen
2009-04-07 22:35           ` Andi Kleen
2009-04-07 15:10 ` [PATCH] [11/16] POISON: Handle poisoned pages in try_to_unmap Andi Kleen
2009-04-07 15:10   ` Andi Kleen
2009-04-07 15:10 ` [PATCH] [12/16] POISON: Handle poisoned pages in set_page_dirty() Andi Kleen
2009-04-07 15:10   ` Andi Kleen
2009-04-07 15:10 ` [PATCH] [13/16] POISON: The high level memory error handler in the VM Andi Kleen
2009-04-07 15:10   ` Andi Kleen
2009-04-07 16:03   ` Rik van Riel
2009-04-07 16:03     ` Rik van Riel
2009-04-07 16:30     ` Andi Kleen
2009-04-07 16:30       ` Andi Kleen
2009-04-07 18:51   ` Johannes Weiner
2009-04-07 18:51     ` Johannes Weiner
2009-04-07 19:40     ` Andi Kleen
2009-04-07 19:40       ` Andi Kleen
2009-04-08 17:03   ` Chris Mason
2009-04-08 17:03     ` Chris Mason
2009-04-09  7:29     ` Andi Kleen
2009-04-09  7:29       ` Andi Kleen
2009-04-09  7:58       ` [PATCH] [13/16] POISON: The high level memory error handler in the VM II Andi Kleen
2009-04-09  7:58         ` Andi Kleen
2009-04-09 13:30         ` Chris Mason
2009-04-09 13:30           ` Chris Mason
2009-04-09 14:02           ` Andi Kleen
2009-04-09 14:02             ` Andi Kleen
2009-04-09 14:37             ` Chris Mason
2009-04-09 14:37               ` Chris Mason
2009-04-09 14:57               ` Andi Kleen
2009-04-09 14:57                 ` Andi Kleen
2009-04-29  8:16               ` Wu Fengguang
2009-04-29  8:16                 ` Wu Fengguang
2009-04-29  8:21                 ` btrfs BUG on creating huge sparse file Wu Fengguang
2009-04-29  8:21                   ` Wu Fengguang
2009-04-29 11:40                   ` Chris Mason
2009-04-29 11:40                     ` Chris Mason
2009-04-29 11:45                     ` Wu Fengguang
2009-04-29 11:45                       ` Wu Fengguang
2009-04-29  8:36                 ` [PATCH] [13/16] POISON: The high level memory error handler in the VM II Andi Kleen
2009-04-29  8:36                   ` Andi Kleen
2009-04-29  9:05                   ` Wu Fengguang
2009-04-29  9:05                     ` Wu Fengguang
2009-04-29 11:27                     ` Chris Mason
2009-04-29 11:27                       ` Chris Mason
2009-04-07 15:10 ` [PATCH] [14/16] x86: MCE: Rename mce_notify_user to mce_notify_irq Andi Kleen
2009-04-07 15:10   ` Andi Kleen
2009-04-07 15:10 ` [PATCH] [15/16] x86: MCE: Support action-optional machine checks Andi Kleen
2009-04-07 15:10   ` Andi Kleen
2009-04-07 15:10 ` [PATCH] [16/16] POISON: Add madvise() based injector for poisoned data Andi Kleen
2009-04-07 15:10   ` Andi Kleen
2009-04-07 19:13 ` [PATCH] [0/16] POISON: Intro Robin Holt
2009-04-07 19:13   ` Robin Holt
2009-04-07 19:38   ` Andi Kleen
2009-04-07 19:38     ` Andi Kleen
2009-04-08  5:15 ` Andrew Morton
2009-04-08  5:15   ` Andrew Morton
2009-04-08  6:15   ` Andi Kleen
2009-04-08  6:15     ` Andi Kleen
2009-04-08 17:29     ` Roland Dreier
2009-04-08 17:29       ` Roland Dreier
2009-04-09  7:22       ` Andi Kleen
2009-04-09  7:22         ` Andi Kleen
2009-04-08  5:47 ` Andrew Morton
2009-04-08  5:47   ` Andrew Morton
2009-04-08  6:21   ` Andi Kleen
2009-04-08  6:21     ` Andi Kleen
2009-04-13 13:18   ` Wu Fengguang
2009-04-13 13:18     ` Wu Fengguang
2009-05-26 12:50 ` Hidehiro Kawai
2009-05-26 12:50   ` Hidehiro Kawai
2009-05-26 13:29   ` Andi Kleen
2009-05-26 13:29     ` Andi Kleen
2009-05-28  4:37     ` Hidehiro Kawai
2009-05-28  4:37       ` Hidehiro Kawai
2009-05-28  8:00       ` Andi Kleen
2009-05-28  8:00         ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090407151004.2F5D21D0470@basil.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.