Re: [Qemu-devel] [PATCH] Fix incorrect attempt to clear a flag in vnc.c

[Aurelien Jarno <aurelien@aurel32.net>]

On Sat, Feb 14, 2009 at 04:20:51PM -0500, Brian Kress wrote:
> Anthony Liguori wrote:
>> Brian Kress wrote:
>>> In vnc.c in pixel_format_message, the code tries to clear the  
>>> QEMU_ALLOCATED_FLAG
>>> from the client display surface, however it uses the wrong operator  
>>> and ends up enabling all
>>> other flags.  Most notably this enables the big endian flag and  
>>> causes some chaos.
>> Can you add a Signed-off-by line?
>>
> Signed-off-by: Brian Kress <kressb@moose.net>

Thanks, applied.

> Index: vnc.c
> ===================================================================
> --- vnc.c	(revision 6619)
> +++ vnc.c	(working copy)
> @@ -1421,7 +1421,7 @@
>     else if (vs->ds->surface->pf.bits_per_pixel == 8)
>         vs->send_hextile_tile = send_hextile_tile_8;
>     vs->clientds = *(vs->ds->surface);
> -    vs->clientds.flags |= ~QEMU_ALLOCATED_FLAG;
> +    vs->clientds.flags &= ~QEMU_ALLOCATED_FLAG;
>     vs->write_pixels = vnc_write_pixels_copy;
>
>     vnc_write(vs, pad, 3);           /* padding */
>
>
>
>

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net