New build error?

New build error?

[Russell King - ARM Linux]

Caused by: 4a694dc915c9a223044ce21fc0d99e63facd1d64

    omap_hsmmc: Fix response type for busy after response

Error:

drivers/mmc/host/omap_hsmmc.c: In function 'mmc_omap_xfer_done':
drivers/mmc/host/omap_hsmmc.c:301: error: implicit declaration of function 'mmc_omap_fclk_lazy_disable'

Please submit a fix to Pierre for this, thanks.

[PATCH] mmc: Fix compile for omap_hsmmc.c (Re: New build error?)

[Tony Lindgren]

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

* Russell King - ARM Linux <linux@arm.linux.org.uk> [090407 12:55]:
> Caused by: 4a694dc915c9a223044ce21fc0d99e63facd1d64
> 
>     omap_hsmmc: Fix response type for busy after response
> 
> Error:
> 
> drivers/mmc/host/omap_hsmmc.c: In function 'mmc_omap_xfer_done':
> drivers/mmc/host/omap_hsmmc.c:301: error: implicit declaration of function 'mmc_omap_fclk_lazy_disable'
> 
> Please submit a fix to Pierre for this, thanks.

Thanks for notifying about this. Pierre, here's a fix for this.

Tony

[-- Attachment #2: hsmmc-fix-compile.patch --]
[-- Type: text/x-diff, Size: 945 bytes --]

>From 880d2674e036b566f5596bef1b45911508cd37a1 Mon Sep 17 00:00:00 2001
From: Tony Lindgren <tony@atomide.com>
Date: Tue, 7 Apr 2009 17:04:33 -0700
Subject: [PATCH] mmc: Fix compile for omap_hsmmc.c

This fixes the issue noted by Russell King:

drivers/mmc/host/omap_hsmmc.c: In function 'mmc_omap_xfer_done':
drivers/mmc/host/omap_hsmmc.c:301: error: implicit declaration of function 'mmc_omap_fclk_lazy_disable'

This got broken by 4a694dc915c9a223044ce21fc0d99e63facd1d64.

Signed-off-by: Tony Lindgren <tony@atomide.com>

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index a752788..d765df2 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -298,7 +298,6 @@ mmc_omap_xfer_done(struct mmc_omap_host *host, struct mmc_data *data)
 		struct mmc_request *mrq = host->mrq;
 
 		host->mrq = NULL;
-		mmc_omap_fclk_lazy_disable(host);
 		mmc_request_done(host->mmc, mrq);
 		return;
 	}

Re: [PATCH] mmc: Fix compile for omap_hsmmc.c (Re: New build error?)

[Pierre Ossman]

[-- Attachment #1: Type: text/plain, Size: 847 bytes --]

On Tue, 7 Apr 2009 17:13:27 -0700
Tony Lindgren <tony@atomide.com> wrote:

> * Russell King - ARM Linux <linux@arm.linux.org.uk> [090407 12:55]:
> > Caused by: 4a694dc915c9a223044ce21fc0d99e63facd1d64
> > 
> >     omap_hsmmc: Fix response type for busy after response
> > 
> > Error:
> > 
> > drivers/mmc/host/omap_hsmmc.c: In function 'mmc_omap_xfer_done':
> > drivers/mmc/host/omap_hsmmc.c:301: error: implicit declaration of function 'mmc_omap_fclk_lazy_disable'
> > 
> > Please submit a fix to Pierre for this, thanks.
> 
> Thanks for notifying about this. Pierre, here's a fix for this.
> 

Queued.

-- 
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]