* [PATCH 04/30] ipcns: add create_ipc_ns()
@ 2009-04-10 2:33 ` Alexey Dobriyan
0 siblings, 0 replies; 8+ messages in thread
From: Alexey Dobriyan @ 2009-04-10 2:33 UTC (permalink / raw)
To: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA
Cc: xemul-bzQdu9zFT3WakBO8gow8eQ, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8, hch-wEGCiKHe2LqWVfeAwA7xHQ,
mingo-X9Un+BFzKDI, torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b
clone_ipc_ns() is misnamed, it doesn't clone anything and doesn't uses passed
parameter. Rename it.
create_ipc_ns() will be used by C/R to create ipcns on restart.
Signed-off-by: Alexey Dobriyan <adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
include/linux/ipc_namespace.h | 1 +
ipc/namespace.c | 9 ++-------
2 files changed, 3 insertions(+), 7 deletions(-)
--- a/include/linux/ipc_namespace.h
+++ b/include/linux/ipc_namespace.h
@@ -97,6 +97,7 @@ static inline int mq_init_ns(struct ipc_namespace *ns) { return 0; }
#if defined(CONFIG_IPC_NS)
extern void free_ipc_ns(struct ipc_namespace *ns);
+struct ipc_namespace *create_ipc_ns(void);
extern struct ipc_namespace *copy_ipcs(unsigned long flags,
struct ipc_namespace *ns);
extern void free_ipcs(struct ipc_namespace *ns, struct ipc_ids *ids,
--- a/ipc/namespace.c
+++ b/ipc/namespace.c
@@ -14,7 +14,7 @@
#include "util.h"
-static struct ipc_namespace *clone_ipc_ns(struct ipc_namespace *old_ns)
+struct ipc_namespace *create_ipc_ns(void)
{
struct ipc_namespace *ns;
int err;
@@ -48,14 +48,9 @@ static struct ipc_namespace *clone_ipc_ns(struct ipc_namespace *old_ns)
struct ipc_namespace *copy_ipcs(unsigned long flags, struct ipc_namespace *ns)
{
- struct ipc_namespace *new_ns;
-
if (!(flags & CLONE_NEWIPC))
return get_ipc_ns(ns);
-
- new_ns = clone_ipc_ns(ns);
-
- return new_ns;
+ return create_ipc_ns();
}
/*
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 04/30] ipcns: add create_ipc_ns()
@ 2009-04-10 2:33 ` Alexey Dobriyan
0 siblings, 0 replies; 8+ messages in thread
From: Alexey Dobriyan @ 2009-04-10 2:33 UTC (permalink / raw)
To: akpm, containers
Cc: xemul, serue, dave, mingo, orenl, hch, torvalds, linux-kernel
clone_ipc_ns() is misnamed, it doesn't clone anything and doesn't uses passed
parameter. Rename it.
create_ipc_ns() will be used by C/R to create ipcns on restart.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
include/linux/ipc_namespace.h | 1 +
ipc/namespace.c | 9 ++-------
2 files changed, 3 insertions(+), 7 deletions(-)
--- a/include/linux/ipc_namespace.h
+++ b/include/linux/ipc_namespace.h
@@ -97,6 +97,7 @@ static inline int mq_init_ns(struct ipc_namespace *ns) { return 0; }
#if defined(CONFIG_IPC_NS)
extern void free_ipc_ns(struct ipc_namespace *ns);
+struct ipc_namespace *create_ipc_ns(void);
extern struct ipc_namespace *copy_ipcs(unsigned long flags,
struct ipc_namespace *ns);
extern void free_ipcs(struct ipc_namespace *ns, struct ipc_ids *ids,
--- a/ipc/namespace.c
+++ b/ipc/namespace.c
@@ -14,7 +14,7 @@
#include "util.h"
-static struct ipc_namespace *clone_ipc_ns(struct ipc_namespace *old_ns)
+struct ipc_namespace *create_ipc_ns(void)
{
struct ipc_namespace *ns;
int err;
@@ -48,14 +48,9 @@ static struct ipc_namespace *clone_ipc_ns(struct ipc_namespace *old_ns)
struct ipc_namespace *copy_ipcs(unsigned long flags, struct ipc_namespace *ns)
{
- struct ipc_namespace *new_ns;
-
if (!(flags & CLONE_NEWIPC))
return get_ipc_ns(ns);
-
- new_ns = clone_ipc_ns(ns);
-
- return new_ns;
+ return create_ipc_ns();
}
/*
^ permalink raw reply [flat|nested] 8+ messages in thread[parent not found: <20090410023358.GE27788-2ev+ksY9ol182hYKe6nXyg@public.gmane.org>]
* Re: [PATCH 04/30] ipcns: add create_ipc_ns()
2009-04-10 2:33 ` Alexey Dobriyan
@ 2009-04-10 9:01 ` Ingo Molnar
-1 siblings, 0 replies; 8+ messages in thread
From: Ingo Molnar @ 2009-04-10 9:01 UTC (permalink / raw)
To: Alexey Dobriyan, Andy Whitcroft
Cc: xemul-bzQdu9zFT3WakBO8gow8eQ,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8, hch-wEGCiKHe2LqWVfeAwA7xHQ,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b,
torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b
* Alexey Dobriyan <adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> --- a/include/linux/ipc_namespace.h
> +++ b/include/linux/ipc_namespace.h
> @@ -97,6 +97,7 @@ static inline int mq_init_ns(struct ipc_namespace *ns) { return 0; }
>
> #if defined(CONFIG_IPC_NS)
> extern void free_ipc_ns(struct ipc_namespace *ns);
> +struct ipc_namespace *create_ipc_ns(void);
> extern struct ipc_namespace *copy_ipcs(unsigned long flags,
> struct ipc_namespace *ns);
> extern void free_ipcs(struct ipc_namespace *ns, struct ipc_ids *ids,
Hm, doesnt the existing, correct pattern strike your eyes out:
extern foo1();
extern foo2();
extern foo3();
and then you add a new method in this inconsistent way:
extern foo1();
foox();
extern foo2();
extern foo3();
Instead of continuing the existing pattern via:
extern foo1();
extern foox();
extern foo2();
extern foo3();
?
I think we need a new checkpatch warning for such things. It might
be a small detail in the big picture, but a thousand small details
create a big mess easily so we have to try to get all the small
details right, all the time - that is the only way to create a
better kernel in the end.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 04/30] ipcns: add create_ipc_ns()
@ 2009-04-10 9:01 ` Ingo Molnar
0 siblings, 0 replies; 8+ messages in thread
From: Ingo Molnar @ 2009-04-10 9:01 UTC (permalink / raw)
To: Alexey Dobriyan, Andy Whitcroft
Cc: akpm, containers, xemul, serue, dave, orenl, hch, torvalds,
linux-kernel
* Alexey Dobriyan <adobriyan@gmail.com> wrote:
> --- a/include/linux/ipc_namespace.h
> +++ b/include/linux/ipc_namespace.h
> @@ -97,6 +97,7 @@ static inline int mq_init_ns(struct ipc_namespace *ns) { return 0; }
>
> #if defined(CONFIG_IPC_NS)
> extern void free_ipc_ns(struct ipc_namespace *ns);
> +struct ipc_namespace *create_ipc_ns(void);
> extern struct ipc_namespace *copy_ipcs(unsigned long flags,
> struct ipc_namespace *ns);
> extern void free_ipcs(struct ipc_namespace *ns, struct ipc_ids *ids,
Hm, doesnt the existing, correct pattern strike your eyes out:
extern foo1();
extern foo2();
extern foo3();
and then you add a new method in this inconsistent way:
extern foo1();
foox();
extern foo2();
extern foo3();
Instead of continuing the existing pattern via:
extern foo1();
extern foox();
extern foo2();
extern foo3();
?
I think we need a new checkpatch warning for such things. It might
be a small detail in the big picture, but a thousand small details
create a big mess easily so we have to try to get all the small
details right, all the time - that is the only way to create a
better kernel in the end.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 8+ messages in thread[parent not found: <20090410090149.GD17962-X9Un+BFzKDI@public.gmane.org>]
* Re: [PATCH 04/30] ipcns: add create_ipc_ns()
[not found] ` <20090410090149.GD17962-X9Un+BFzKDI@public.gmane.org>
@ 2009-04-10 11:25 ` Alexey Dobriyan
0 siblings, 0 replies; 8+ messages in thread
From: Alexey Dobriyan @ 2009-04-10 11:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: xemul-bzQdu9zFT3WakBO8gow8eQ,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8, hch-wEGCiKHe2LqWVfeAwA7xHQ,
Andy Whitcroft, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b,
torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b
On Fri, Apr 10, 2009 at 11:01:49AM +0200, Ingo Molnar wrote:
>
> * Alexey Dobriyan <adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
> > --- a/include/linux/ipc_namespace.h
> > +++ b/include/linux/ipc_namespace.h
> > @@ -97,6 +97,7 @@ static inline int mq_init_ns(struct ipc_namespace *ns) { return 0; }
> >
> > #if defined(CONFIG_IPC_NS)
> > extern void free_ipc_ns(struct ipc_namespace *ns);
> > +struct ipc_namespace *create_ipc_ns(void);
> > extern struct ipc_namespace *copy_ipcs(unsigned long flags,
> > struct ipc_namespace *ns);
> > extern void free_ipcs(struct ipc_namespace *ns, struct ipc_ids *ids,
>
> Hm, doesnt the existing, correct pattern strike your eyes out:
>
> extern foo1();
> extern foo2();
> extern foo3();
>
> and then you add a new method in this inconsistent way:
>
> extern foo1();
> foox();
> extern foo2();
> extern foo3();
>
> Instead of continuing the existing pattern via:
>
> extern foo1();
> extern foox();
> extern foo2();
> extern foo3();
>
> ?
>
> I think we need a new checkpatch warning for such things. It might
> be a small detail in the big picture, but a thousand small details
> create a big mess easily so we have to try to get all the small
> details right, all the time - that is the only way to create a
> better kernel in the end.
We (OK, I don't care anyway) should remove extern in front of prototypes.
They slow down compilation, they make easier to overcome 80-column limit resulting in
multiline prototypes which are ugly.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 04/30] ipcns: add create_ipc_ns()
2009-04-10 9:01 ` Ingo Molnar
(?)
(?)
@ 2009-04-10 11:25 ` Alexey Dobriyan
-1 siblings, 0 replies; 8+ messages in thread
From: Alexey Dobriyan @ 2009-04-10 11:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: Andy Whitcroft, akpm, containers, xemul, serue, dave, orenl, hch,
torvalds, linux-kernel
On Fri, Apr 10, 2009 at 11:01:49AM +0200, Ingo Molnar wrote:
>
> * Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> > --- a/include/linux/ipc_namespace.h
> > +++ b/include/linux/ipc_namespace.h
> > @@ -97,6 +97,7 @@ static inline int mq_init_ns(struct ipc_namespace *ns) { return 0; }
> >
> > #if defined(CONFIG_IPC_NS)
> > extern void free_ipc_ns(struct ipc_namespace *ns);
> > +struct ipc_namespace *create_ipc_ns(void);
> > extern struct ipc_namespace *copy_ipcs(unsigned long flags,
> > struct ipc_namespace *ns);
> > extern void free_ipcs(struct ipc_namespace *ns, struct ipc_ids *ids,
>
> Hm, doesnt the existing, correct pattern strike your eyes out:
>
> extern foo1();
> extern foo2();
> extern foo3();
>
> and then you add a new method in this inconsistent way:
>
> extern foo1();
> foox();
> extern foo2();
> extern foo3();
>
> Instead of continuing the existing pattern via:
>
> extern foo1();
> extern foox();
> extern foo2();
> extern foo3();
>
> ?
>
> I think we need a new checkpatch warning for such things. It might
> be a small detail in the big picture, but a thousand small details
> create a big mess easily so we have to try to get all the small
> details right, all the time - that is the only way to create a
> better kernel in the end.
We (OK, I don't care anyway) should remove extern in front of prototypes.
They slow down compilation, they make easier to overcome 80-column limit resulting in
multiline prototypes which are ugly.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 04/30] ipcns: add create_ipc_ns()
[not found] ` <20090410023358.GE27788-2ev+ksY9ol182hYKe6nXyg@public.gmane.org>
2009-04-10 9:01 ` Ingo Molnar
@ 2009-04-10 22:29 ` Serge E. Hallyn
1 sibling, 0 replies; 8+ messages in thread
From: Serge E. Hallyn @ 2009-04-10 22:29 UTC (permalink / raw)
To: Alexey Dobriyan
Cc: xemul-bzQdu9zFT3WakBO8gow8eQ,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8, hch-wEGCiKHe2LqWVfeAwA7xHQ,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b,
torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b, mingo-X9Un+BFzKDI
Quoting Alexey Dobriyan (adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org):
> clone_ipc_ns() is misnamed, it doesn't clone anything and doesn't uses passed
> parameter. Rename it.
>
> create_ipc_ns() will be used by C/R to create ipcns on restart.
>
> Signed-off-by: Alexey Dobriyan <adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Acked-by: Serge Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> ---
>
> include/linux/ipc_namespace.h | 1 +
> ipc/namespace.c | 9 ++-------
> 2 files changed, 3 insertions(+), 7 deletions(-)
>
> --- a/include/linux/ipc_namespace.h
> +++ b/include/linux/ipc_namespace.h
> @@ -97,6 +97,7 @@ static inline int mq_init_ns(struct ipc_namespace *ns) { return 0; }
>
> #if defined(CONFIG_IPC_NS)
> extern void free_ipc_ns(struct ipc_namespace *ns);
> +struct ipc_namespace *create_ipc_ns(void);
> extern struct ipc_namespace *copy_ipcs(unsigned long flags,
> struct ipc_namespace *ns);
> extern void free_ipcs(struct ipc_namespace *ns, struct ipc_ids *ids,
> --- a/ipc/namespace.c
> +++ b/ipc/namespace.c
> @@ -14,7 +14,7 @@
>
> #include "util.h"
>
> -static struct ipc_namespace *clone_ipc_ns(struct ipc_namespace *old_ns)
> +struct ipc_namespace *create_ipc_ns(void)
> {
> struct ipc_namespace *ns;
> int err;
> @@ -48,14 +48,9 @@ static struct ipc_namespace *clone_ipc_ns(struct ipc_namespace *old_ns)
>
> struct ipc_namespace *copy_ipcs(unsigned long flags, struct ipc_namespace *ns)
> {
> - struct ipc_namespace *new_ns;
> -
> if (!(flags & CLONE_NEWIPC))
> return get_ipc_ns(ns);
> -
> - new_ns = clone_ipc_ns(ns);
> -
> - return new_ns;
> + return create_ipc_ns();
> }
>
> /*
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 04/30] ipcns: add create_ipc_ns()
2009-04-10 2:33 ` Alexey Dobriyan
(?)
(?)
@ 2009-04-10 22:29 ` Serge E. Hallyn
-1 siblings, 0 replies; 8+ messages in thread
From: Serge E. Hallyn @ 2009-04-10 22:29 UTC (permalink / raw)
To: Alexey Dobriyan
Cc: akpm, containers, xemul, dave, mingo, orenl, hch, torvalds,
linux-kernel
Quoting Alexey Dobriyan (adobriyan@gmail.com):
> clone_ipc_ns() is misnamed, it doesn't clone anything and doesn't uses passed
> parameter. Rename it.
>
> create_ipc_ns() will be used by C/R to create ipcns on restart.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Acked-by: Serge Hallyn <serue@us.ibm.com>
> ---
>
> include/linux/ipc_namespace.h | 1 +
> ipc/namespace.c | 9 ++-------
> 2 files changed, 3 insertions(+), 7 deletions(-)
>
> --- a/include/linux/ipc_namespace.h
> +++ b/include/linux/ipc_namespace.h
> @@ -97,6 +97,7 @@ static inline int mq_init_ns(struct ipc_namespace *ns) { return 0; }
>
> #if defined(CONFIG_IPC_NS)
> extern void free_ipc_ns(struct ipc_namespace *ns);
> +struct ipc_namespace *create_ipc_ns(void);
> extern struct ipc_namespace *copy_ipcs(unsigned long flags,
> struct ipc_namespace *ns);
> extern void free_ipcs(struct ipc_namespace *ns, struct ipc_ids *ids,
> --- a/ipc/namespace.c
> +++ b/ipc/namespace.c
> @@ -14,7 +14,7 @@
>
> #include "util.h"
>
> -static struct ipc_namespace *clone_ipc_ns(struct ipc_namespace *old_ns)
> +struct ipc_namespace *create_ipc_ns(void)
> {
> struct ipc_namespace *ns;
> int err;
> @@ -48,14 +48,9 @@ static struct ipc_namespace *clone_ipc_ns(struct ipc_namespace *old_ns)
>
> struct ipc_namespace *copy_ipcs(unsigned long flags, struct ipc_namespace *ns)
> {
> - struct ipc_namespace *new_ns;
> -
> if (!(flags & CLONE_NEWIPC))
> return get_ipc_ns(ns);
> -
> - new_ns = clone_ipc_ns(ns);
> -
> - return new_ns;
> + return create_ipc_ns();
> }
>
> /*
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2009-04-10 22:29 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-10 2:33 [PATCH 04/30] ipcns: add create_ipc_ns() Alexey Dobriyan
2009-04-10 2:33 ` Alexey Dobriyan
[not found] ` <20090410023358.GE27788-2ev+ksY9ol182hYKe6nXyg@public.gmane.org>
2009-04-10 9:01 ` Ingo Molnar
2009-04-10 9:01 ` Ingo Molnar
[not found] ` <20090410090149.GD17962-X9Un+BFzKDI@public.gmane.org>
2009-04-10 11:25 ` Alexey Dobriyan
2009-04-10 11:25 ` Alexey Dobriyan
2009-04-10 22:29 ` Serge E. Hallyn
2009-04-10 22:29 ` Serge E. Hallyn
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.