From: "Yoshinori K. Okuji" <okuji@enbug.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Preboot support
Date: Sat, 11 Apr 2009 19:16:05 +0900 [thread overview]
Message-ID: <200904111916.06107.okuji@enbug.org> (raw)
In-Reply-To: <49DFDAB7.1080009@gmail.com>
On Saturday 11 April 2009 08:48:07 phcoder wrote:
> Hello, here is the preboot hooks support. Apply on top of my bootmove
> patch. They are very useful for patches like sendkey (my old patch that
> I'll rediff), badram, acpi (2 patches in separate threads) or drivemap
Some comments about the design.
- register/unregister is more appropriate than add/remove.
- preboot is ambigous. preboot_hook is better.
- Using an int value for the priority is quetionable. Very often, this style
of priority system leads to chaos, because everyone picks up arbitrary
numbers randomly. I prefer to define enums with a careful analysis.
Regards,
Okuji
next prev parent reply other threads:[~2009-04-11 10:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-10 23:48 [PATCH] Preboot support phcoder
2009-04-11 10:16 ` Yoshinori K. Okuji [this message]
2009-04-11 15:44 ` phcoder
2009-04-12 17:19 ` phcoder
2009-04-14 14:42 ` Yoshinori K. Okuji
2009-04-15 8:23 ` phcoder
2009-04-15 8:40 ` John Stanley
2009-04-26 14:38 ` Vladimir 'phcoder' Serbinenko
2009-04-27 16:49 ` Vladimir 'phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904111916.06107.okuji@enbug.org \
--to=okuji@enbug.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.