From: Matthew Garrett <mjg59@srcf.ucam.org>
To: akpm@linux-foundation.org
Cc: lenb@kernel.org, linux-acpi@vger.kernel.org, rafi@seas.upenn.edu,
E.A.B.Piel@tudelft.nl, len.brown@intel.com
Subject: Re: [patch 4/4] dell-wmi: support additional keys
Date: Mon, 13 Apr 2009 15:55:23 +0100 [thread overview]
Message-ID: <20090413145522.GC10976@srcf.ucam.org> (raw)
In-Reply-To: <200904110616.n3B6GXsp026164@imap1.linux-foundation.org>
On Fri, Apr 10, 2009 at 11:16:32PM -0700, akpm@linux-foundation.org wrote:
> From: Rafi Rubin <rafi@seas.upenn.edu>
>
> Added key codes generated by screen rotation on the Latitude XT. 0xe046
> is sent when changing to tablet mode, and 0xe047 when it returns to
> desktop mode.
>
> Signed-off-by: Rafi Rubin <rafi@seas.upenn.edu>
> Cc: Matthew Garrett <mjg@redhat.com>
> Cc: Len Brown <len.brown@intel.com>
> Cc: Eric Piel <E.A.B.Piel@tudelft.nl>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
I don't like this - it should really be using the switch event, not
sending random programmable buttons.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-04-13 14:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-11 6:16 [patch 4/4] dell-wmi: support additional keys akpm
2009-04-13 14:55 ` Matthew Garrett [this message]
2009-04-15 14:04 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090413145522.GC10976@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=E.A.B.Piel@tudelft.nl \
--cc=akpm@linux-foundation.org \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rafi@seas.upenn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.